S3: support MethodNotAllowed for Object Lock Configuration #10657
Conversation
Some environments do not support Bucket Object Lock Configuration which was causing errors when reading the bucket configuration. This change allows us to ignore Object Lock Configuration if the endpoint responds with MethodNotAllowed. Resolves hashicorp#10153
ghost
added
size/XS
bflad
added
bug
There was a problem hiding this comment.
Looks great, thanks @anowell 🚀
Did not run. Can follow up if needed. Would that be make testacc TESTARGS='-run=TestAccAWSS3Bucket_'?
Correct 😄 Go's test runner accepts a regular expression and we use the underscores in the acceptance testing naming so its easier to run just a single Terraform resource. More information about the Terraform acceptance testing framework can be in our Contributing Guide and in the Extending Terraform documentation.
|
This has been released in version 2.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Some environments do not support Bucket Object Lock Configuration which was causing errors when reading the bucket configuration. This changes allows us to ignore Object Lock Configuration
if the endpoint responds with
MethodNotAllowed.Community Note
Closes #10153
Release note for CHANGELOG:
Output from acceptance testing:
Did not run. Can follow up if needed. Would that be
make testacc TESTARGS='-run=TestAccAWSS3Bucket_'?Did test using the provider with this change to create an S3 bucket in the environment that originally motivated opening #10153.