Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/secretsmanager: Refactor tagging logic to keyvaluetags package #10745

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 4, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #10688

Release note for CHANGELOG:

NONE

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsSecretsManagerSecret_Basic (5.99s)
--- PASS: TestAccAwsSecretsManagerSecret_Basic (13.99s)
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (14.02s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecret_ARN (15.28s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecret_Policy (16.05s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecret_Name (16.35s)
--- PASS: TestAccAwsSecretsManagerSecret_policy (17.75s)
--- PASS: TestAccAwsSecretsManagerSecret_Description (21.89s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (38.69s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (39.41s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (50.42s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (50.55s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (53.23s)

Reference: #10688

Output from acceptance testing:

```
--- PASS: TestAccDataSourceAwsSecretsManagerSecret_Basic (5.99s)
--- PASS: TestAccAwsSecretsManagerSecret_Basic (13.99s)
--- PASS: TestAccAwsSecretsManagerSecret_withNamePrefix (14.02s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecret_ARN (15.28s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecret_Policy (16.05s)
--- PASS: TestAccDataSourceAwsSecretsManagerSecret_Name (16.35s)
--- PASS: TestAccAwsSecretsManagerSecret_policy (17.75s)
--- PASS: TestAccAwsSecretsManagerSecret_Description (21.89s)
--- PASS: TestAccAwsSecretsManagerSecret_Tags (38.69s)
--- PASS: TestAccAwsSecretsManagerSecret_RecoveryWindowInDays_Recreate (39.41s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationRules (50.42s)
--- PASS: TestAccAwsSecretsManagerSecret_RotationLambdaARN (50.55s)
--- PASS: TestAccAwsSecretsManagerSecret_KmsKeyID (53.23s)
```
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Nov 4, 2019
@bflad bflad requested a review from a team November 4, 2019 23:20
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 4, 2019
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad added this to the v2.37.0 milestone Nov 15, 2019
@bflad bflad merged commit 43ae107 into master Nov 15, 2019
@bflad bflad deleted the td-secretsmanager-keyvaluetags branch November 15, 2019 18:43
@ghost
Copy link

ghost commented Nov 18, 2019

This has been released in version 2.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/secretsmanager Issues and PRs that pertain to the secretsmanager service. size/L Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants