Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-10824: Fix importing queue into state on apply #10832

Closed
wants to merge 1 commit into from

Conversation

opetch
Copy link

@opetch opetch commented Nov 10, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10824

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSQSQueue_*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSQSQueue_* -timeout 120m
=== RUN   TestAccAWSSQSQueuePolicy_basic
=== PAUSE TestAccAWSSQSQueuePolicy_basic
=== RUN   TestAccAWSSQSQueue_basic
=== PAUSE TestAccAWSSQSQueue_basic
=== RUN   TestAccAWSSQSQueue_tags
=== PAUSE TestAccAWSSQSQueue_tags
=== RUN   TestAccAWSSQSQueue_namePrefix
=== PAUSE TestAccAWSSQSQueue_namePrefix
=== RUN   TestAccAWSSQSQueue_namePrefix_fifo
=== PAUSE TestAccAWSSQSQueue_namePrefix_fifo
=== RUN   TestAccAWSSQSQueue_policy
=== PAUSE TestAccAWSSQSQueue_policy
=== RUN   TestAccAWSSQSQueue_queueDeletedRecently
=== PAUSE TestAccAWSSQSQueue_queueDeletedRecently
=== RUN   TestAccAWSSQSQueue_redrivePolicy
=== PAUSE TestAccAWSSQSQueue_redrivePolicy
=== RUN   TestAccAWSSQSQueue_Policybasic
=== PAUSE TestAccAWSSQSQueue_Policybasic
=== RUN   TestAccAWSSQSQueue_FIFO
=== PAUSE TestAccAWSSQSQueue_FIFO
=== RUN   TestAccAWSSQSQueue_FIFOExpectNameError
=== PAUSE TestAccAWSSQSQueue_FIFOExpectNameError
=== RUN   TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication
=== PAUSE TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication
=== RUN   TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError
=== PAUSE TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError
=== RUN   TestAccAWSSQSQueue_Encryption
=== PAUSE TestAccAWSSQSQueue_Encryption
=== RUN   TestAccAWSSQSQueue_NameConflict
=== PAUSE TestAccAWSSQSQueue_NameConflict
=== CONT  TestAccAWSSQSQueuePolicy_basic
=== CONT  TestAccAWSSQSQueue_Policybasic
=== CONT  TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError
=== CONT  TestAccAWSSQSQueue_Encryption
=== CONT  TestAccAWSSQSQueue_namePrefix_fifo
=== CONT  TestAccAWSSQSQueue_redrivePolicy
=== CONT  TestAccAWSSQSQueue_queueDeletedRecently
=== CONT  TestAccAWSSQSQueue_policy
=== CONT  TestAccAWSSQSQueue_tags
=== CONT  TestAccAWSSQSQueue_NameConflict
=== CONT  TestAccAWSSQSQueue_namePrefix
=== CONT  TestAccAWSSQSQueue_FIFOExpectNameError
=== CONT  TestAccAWSSQSQueue_FIFO
=== CONT  TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication
=== CONT  TestAccAWSSQSQueue_basic
--- PASS: TestAccAWSSQSQueue_FIFOExpectNameError (9.86s)
--- PASS: TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError (10.02s)
--- PASS: TestAccAWSSQSQueue_FIFO (29.59s)
--- PASS: TestAccAWSSQSQueue_namePrefix_fifo (29.95s)
--- PASS: TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication (30.01s)
--- PASS: TestAccAWSSQSQueue_namePrefix (30.56s)
--- PASS: TestAccAWSSQSQueue_Encryption (30.71s)
--- PASS: TestAccAWSSQSQueuePolicy_basic (33.43s)
--- PASS: TestAccAWSSQSQueue_redrivePolicy (37.59s)
--- PASS: TestAccAWSSQSQueue_policy (40.43s)
--- PASS: TestAccAWSSQSQueue_Policybasic (40.45s)
--- PASS: TestAccAWSSQSQueue_basic (68.75s)
--- PASS: TestAccAWSSQSQueue_tags (71.03s)
--- PASS: TestAccAWSSQSQueue_NameConflict (76.26s)
--- PASS: TestAccAWSSQSQueue_queueDeletedRecently (109.85s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       111.230s
...

@opetch opetch requested a review from a team November 10, 2019 22:55
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. service/sqs Issues and PRs that pertain to the sqs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 10, 2019
Base automatically changed from master to main January 23, 2021 00:56
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:56
@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Apr 13, 2021
@YakDriver
Copy link
Member

I'm going to remove the triage label. This is a recurring problem that needs to be addressed. However, rather than have fixes shoot off in all different directions, hopefully one good way of handling this issue will arise. Please see #14394 for the broader conversation.

@ewbankkit
Copy link
Contributor

Closing as we wait for a generic solution - see this comment.

@ewbankkit ewbankkit closed this Jun 15, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/sqs Issues and PRs that pertain to the sqs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Applying a plan with SQS queue with attributes matching an existing queue results in an import not a creation.
3 participants