-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d/api_gateway_rest_api - add attributes #10971
d/api_gateway_rest_api - add attributes #10971
Conversation
fa17eba
to
ad714b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks so much, @DrFaust92 🚀
Output from acceptance testing:
--- PASS: TestAccDataSourceAwsApiGatewayRestApi (8.90s)
}, | ||
}, | ||
}, | ||
"execution_arn": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New attribute is missing documentation, will add on merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that, this happened to me more than once and got me thinking if we can have some sort of validation for this with a linter. ill take a look if i can hack something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its partially possible today, but requires the output of terraform providers schema -json
, which is not PR friendly without some Terraform CLI and plugin directory setup in CI. We're hoping to allow the provider binary to output its own form of that JSON instead (with all data; Terraform core does not receive the full schema information from providers) to remove the Terraform CLI and ancillary setup, but that's likely a few weeks out.
I have some centralized tooling issues available here (bflad/tfproviderdocs#15 / bflad/tfproviderdocs#16), but we'd likely also want Markdown AST parsing in that tooling (rather than regular expressions, for example) before implementing a lot of the Markdown checking to prevent false positives.
… add missing execution_arn attribute Reference: #10971
This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates #10688
Release note for CHANGELOG:
Output from acceptance testing: