Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/rds: Refactor to use keyvaluetags package #11255

Merged
merged 1 commit into from
Dec 17, 2019
Merged

service/rds: Refactor to use keyvaluetags package #11255

merged 1 commit into from
Dec 17, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 11, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #10688

Release note for CHANGELOG:

NONE

Output from acceptance testing (test failures present on master):

--- PASS: TestAccAWSDBClusterSnapshot_basic (145.21s)
--- PASS: TestAccAWSDBClusterSnapshot_Tags (167.89s)

--- PASS: TestAccAWSDbClusterSnapshotDataSource_DbClusterIdentifier (134.49s)
--- PASS: TestAccAWSDbClusterSnapshotDataSource_DbClusterSnapshotIdentifier (175.55s)
--- PASS: TestAccAWSDbClusterSnapshotDataSource_MostRecent (170.03s)

--- PASS: TestAccAWSDBEventSubscription_basicUpdate (109.85s)
--- PASS: TestAccAWSDBEventSubscription_categoryUpdate (109.93s)
--- PASS: TestAccAWSDBEventSubscription_disappears (73.12s)
--- PASS: TestAccAWSDBEventSubscription_withPrefix (72.51s)
--- PASS: TestAccAWSDBEventSubscription_withSourceIds (79.37s)

--- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (622.45s)
--- PASS: TestAccAWSDBInstance_basic (437.80s)
--- PASS: TestAccAWSDBInstance_CACertificateIdentifier (558.71s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfiguration (577.71s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfigurationUpdate (801.15s)
--- PASS: TestAccAWSDBInstance_DeletionProtection (612.92s)
--- PASS: TestAccAWSDBInstance_ec2Classic (479.20s)
--- FAIL: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (2.88s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (519.28s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier (846.65s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier_SkipFinalSnapshot (866.07s)
--- PASS: TestAccAWSDBInstance_generatedName (508.16s)
--- PASS: TestAccAWSDBInstance_iamAuth (628.98s)
--- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (553.98s)
--- PASS: TestAccAWSDBInstance_kmsKey (455.16s)
--- PASS: TestAccAWSDBInstance_MaxAllocatedStorage (619.67s)
--- PASS: TestAccAWSDBInstance_MinorVersion (422.63s)
--- PASS: TestAccAWSDBInstance_MonitoringInterval (1073.44s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (727.35s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (763.44s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (601.73s)
--- PASS: TestAccAWSDBInstance_MSSQL_Domain (3112.62s)
--- PASS: TestAccAWSDBInstance_MSSQL_DomainSnapshotRestore (3000.13s)
--- PASS: TestAccAWSDBInstance_MSSQL_TZ (1443.14s)
--- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (1939.69s)
--- PASS: TestAccAWSDBInstance_namePrefix (448.21s)
--- FAIL: TestAccAWSDBInstance_optionGroup (10.65s)
--- PASS: TestAccAWSDBInstance_Password (515.57s)
--- PASS: TestAccAWSDBInstance_portUpdate (517.92s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb (1614.83s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllocatedStorage (1655.29s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllowMajorVersionUpgrade (1341.52s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AutoMinorVersionUpgrade (1705.39s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AvailabilityZone (1646.29s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupRetentionPeriod (1979.15s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupWindow (1664.98s)
--- SKIP: TestAccAWSDBInstance_ReplicateSourceDb_DeletionProtection (0.00s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_IamDatabaseAuthenticationEnabled (1660.09s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaintenanceWindow (1675.43s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaxAllocatedStorage (1415.38s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1526.31s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MultiAZ (1957.97s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_ParameterGroupName (1402.12s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_PerformanceInsightsEnabled (1687.20s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Port (1646.21s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds (1475.53s)
--- FAIL: TestAccAWSDBInstance_S3Import (812.70s)
--- PASS: TestAccAWSDBInstance_separate_iops_update (742.36s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier (1220.05s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllocatedStorage (1814.70s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllowMajorVersionUpgrade (2191.21s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AutoMinorVersionUpgrade (1200.33s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AvailabilityZone (1333.15s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1452.61s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset (1603.77s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1253.51s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1337.59s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (1472.50s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Io1Storage (1684.81s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1330.32s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaxAllocatedStorage (1311.72s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1325.95s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ (1920.10s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ_SQLServer (4366.30s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1301.06s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_PerformanceInsightsEnabled (1574.36s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Port (1150.01s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Tags (1300.72s)
--- SKIP: TestAccAWSDBInstance_SnapshotIdentifier_Tags_Unset (0.00s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds (1284.07s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1414.07s)
--- PASS: TestAccAWSDBInstance_subnetGroup (1157.60s)

--- PASS: TestAccAWSDbInstanceDataSource_basic (631.27s)
--- PASS: TestAccAWSDbInstanceDataSource_ec2Classic (446.53s)

--- PASS: TestAccAWSDBOptionGroup_basic (7.60s)
--- PASS: TestAccAWSDBOptionGroup_basicDestroyWithInstance (524.56s)
--- PASS: TestAccAWSDBOptionGroup_generatedName (7.45s)
--- PASS: TestAccAWSDBOptionGroup_multipleOptions (7.75s)
--- PASS: TestAccAWSDBOptionGroup_namePrefix (7.60s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings (13.80s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_IAMRole (26.61s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_MultipleNonDefault (13.35s)
--- PASS: TestAccAWSDBOptionGroup_OracleOptionsUpdate (14.46s)
--- PASS: TestAccAWSDBOptionGroup_sqlServerOptionsUpdate (13.06s)
--- PASS: TestAccAWSDBOptionGroup_Tags (17.70s)
--- PASS: TestAccAWSDBOptionGroup_Tags_WithOptions (18.13s)
--- PASS: TestAccAWSDBOptionGroup_timeoutBlock (7.67s)

--- PASS: TestAccAWSDBParameterGroup_basic (15.85s)
--- PASS: TestAccAWSDBParameterGroup_Disappears (6.81s)
--- PASS: TestAccAWSDBParameterGroup_generatedName (15.17s)
--- PASS: TestAccAWSDBParameterGroup_limit (44.08s)
--- PASS: TestAccAWSDBParameterGroup_MatchDefault (8.51s)
--- PASS: TestAccAWSDBParameterGroup_namePrefix (23.95s)
--- PASS: TestAccAWSDBParameterGroup_Only (9.13s)
--- PASS: TestAccAWSDBParameterGroup_withApplyMethod (12.54s)

--- PASS: TestAccAWSDBSecurityGroup_basic (29.86s)

--- PASS: TestAccAWSDBSnapshot_basic (683.27s)
--- PASS: TestAccAWSDBSnapshot_disappears (753.38s)
--- PASS: TestAccAWSDBSnapshot_tags (709.04s)

--- PASS: TestAccAWSDBSubnetGroup_basic (11.68s)
--- PASS: TestAccAWSDBSubnetGroup_generatedName (11.34s)
--- PASS: TestAccAWSDBSubnetGroup_namePrefix (11.54s)
--- PASS: TestAccAWSDBSubnetGroup_updateDescription (18.54s)
--- PASS: TestAccAWSDBSubnetGroup_withUndocumentedCharacters (11.60s)

@bflad
service/rds: Refactor to use keyvaluetags package
5ca6c8c 
Reference: #10688

Output from acceptance testing (test failures present on master):

```
--- PASS: TestAccAWSDBClusterSnapshot_basic (145.21s)
--- PASS: TestAccAWSDBClusterSnapshot_Tags (167.89s)

--- PASS: TestAccAWSDbClusterSnapshotDataSource_DbClusterIdentifier (134.49s)
--- PASS: TestAccAWSDbClusterSnapshotDataSource_DbClusterSnapshotIdentifier (175.55s)
--- PASS: TestAccAWSDbClusterSnapshotDataSource_MostRecent (170.03s)

--- PASS: TestAccAWSDBEventSubscription_basicUpdate (109.85s)
--- PASS: TestAccAWSDBEventSubscription_categoryUpdate (109.93s)
--- PASS: TestAccAWSDBEventSubscription_disappears (73.12s)
--- PASS: TestAccAWSDBEventSubscription_withPrefix (72.51s)
--- PASS: TestAccAWSDBEventSubscription_withSourceIds (79.37s)

--- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (622.45s)
--- PASS: TestAccAWSDBInstance_basic (437.80s)
--- PASS: TestAccAWSDBInstance_CACertificateIdentifier (558.71s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfiguration (577.71s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfigurationUpdate (801.15s)
--- PASS: TestAccAWSDBInstance_DeletionProtection (612.92s)
--- PASS: TestAccAWSDBInstance_ec2Classic (479.20s)
--- FAIL: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (2.88s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (519.28s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier (846.65s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier_SkipFinalSnapshot (866.07s)
--- PASS: TestAccAWSDBInstance_generatedName (508.16s)
--- PASS: TestAccAWSDBInstance_iamAuth (628.98s)
--- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (553.98s)
--- PASS: TestAccAWSDBInstance_kmsKey (455.16s)
--- PASS: TestAccAWSDBInstance_MaxAllocatedStorage (619.67s)
--- PASS: TestAccAWSDBInstance_MinorVersion (422.63s)
--- PASS: TestAccAWSDBInstance_MonitoringInterval (1073.44s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (727.35s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (763.44s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (601.73s)
--- PASS: TestAccAWSDBInstance_MSSQL_Domain (3112.62s)
--- PASS: TestAccAWSDBInstance_MSSQL_DomainSnapshotRestore (3000.13s)
--- PASS: TestAccAWSDBInstance_MSSQL_TZ (1443.14s)
--- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (1939.69s)
--- PASS: TestAccAWSDBInstance_namePrefix (448.21s)
--- FAIL: TestAccAWSDBInstance_optionGroup (10.65s)
--- PASS: TestAccAWSDBInstance_Password (515.57s)
--- PASS: TestAccAWSDBInstance_portUpdate (517.92s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb (1614.83s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllocatedStorage (1655.29s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllowMajorVersionUpgrade (1341.52s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AutoMinorVersionUpgrade (1705.39s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AvailabilityZone (1646.29s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupRetentionPeriod (1979.15s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupWindow (1664.98s)
--- SKIP: TestAccAWSDBInstance_ReplicateSourceDb_DeletionProtection (0.00s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_IamDatabaseAuthenticationEnabled (1660.09s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaintenanceWindow (1675.43s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaxAllocatedStorage (1415.38s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1526.31s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MultiAZ (1957.97s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_ParameterGroupName (1402.12s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_PerformanceInsightsEnabled (1687.20s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Port (1646.21s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds (1475.53s)
--- FAIL: TestAccAWSDBInstance_S3Import (812.70s)
--- PASS: TestAccAWSDBInstance_separate_iops_update (742.36s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier (1220.05s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllocatedStorage (1814.70s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllowMajorVersionUpgrade (2191.21s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AutoMinorVersionUpgrade (1200.33s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AvailabilityZone (1333.15s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1452.61s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset (1603.77s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1253.51s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1337.59s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (1472.50s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Io1Storage (1684.81s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1330.32s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaxAllocatedStorage (1311.72s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1325.95s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ (1920.10s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ_SQLServer (4366.30s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1301.06s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_PerformanceInsightsEnabled (1574.36s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Port (1150.01s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Tags (1300.72s)
--- SKIP: TestAccAWSDBInstance_SnapshotIdentifier_Tags_Unset (0.00s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds (1284.07s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1414.07s)
--- PASS: TestAccAWSDBInstance_subnetGroup (1157.60s)

--- PASS: TestAccAWSDbInstanceDataSource_basic (631.27s)
--- PASS: TestAccAWSDbInstanceDataSource_ec2Classic (446.53s)

--- PASS: TestAccAWSDBOptionGroup_basic (7.60s)
--- PASS: TestAccAWSDBOptionGroup_basicDestroyWithInstance (524.56s)
--- PASS: TestAccAWSDBOptionGroup_generatedName (7.45s)
--- PASS: TestAccAWSDBOptionGroup_multipleOptions (7.75s)
--- PASS: TestAccAWSDBOptionGroup_namePrefix (7.60s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings (13.80s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_IAMRole (26.61s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_MultipleNonDefault (13.35s)
--- PASS: TestAccAWSDBOptionGroup_OracleOptionsUpdate (14.46s)
--- PASS: TestAccAWSDBOptionGroup_sqlServerOptionsUpdate (13.06s)
--- PASS: TestAccAWSDBOptionGroup_Tags (17.70s)
--- PASS: TestAccAWSDBOptionGroup_Tags_WithOptions (18.13s)
--- PASS: TestAccAWSDBOptionGroup_timeoutBlock (7.67s)

--- PASS: TestAccAWSDBParameterGroup_basic (15.85s)
--- PASS: TestAccAWSDBParameterGroup_Disappears (6.81s)
--- PASS: TestAccAWSDBParameterGroup_generatedName (15.17s)
--- PASS: TestAccAWSDBParameterGroup_limit (44.08s)
--- PASS: TestAccAWSDBParameterGroup_MatchDefault (8.51s)
--- PASS: TestAccAWSDBParameterGroup_namePrefix (23.95s)
--- PASS: TestAccAWSDBParameterGroup_Only (9.13s)
--- PASS: TestAccAWSDBParameterGroup_withApplyMethod (12.54s)

--- PASS: TestAccAWSDBSecurityGroup_basic (29.86s)

--- PASS: TestAccAWSDBSnapshot_basic (683.27s)
--- PASS: TestAccAWSDBSnapshot_disappears (753.38s)
--- PASS: TestAccAWSDBSnapshot_tags (709.04s)

--- PASS: TestAccAWSDBSubnetGroup_basic (11.68s)
--- PASS: TestAccAWSDBSubnetGroup_generatedName (11.34s)
--- PASS: TestAccAWSDBSubnetGroup_namePrefix (11.54s)
--- PASS: TestAccAWSDBSubnetGroup_updateDescription (18.54s)
--- PASS: TestAccAWSDBSubnetGroup_withUndocumentedCharacters (11.60s)
```
@bflad bflad added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Dec 11, 2019
@bflad bflad requested a review from a team December 11, 2019 20:27
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 11, 2019
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Dec 11, 2019
gdavison
gdavison approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@bflad bflad added this to the v2.43.0 milestone Dec 17, 2019
@bflad bflad merged commit dee9367 into master Dec 17, 2019
@bflad bflad deleted the td-rds-keyvaluetags branch December 17, 2019 21:39
@ghost
Copy link

ghost commented Dec 19, 2019

This has been released in version 2.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.43.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @gdavison