-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Data Source: aws_directory_service_directory #11282
New Data Source: aws_directory_service_directory #11282
Conversation
@bflad Please could you guide me on why does
I thought it could be because of the sensitive nature of |
@gdavison Hi, could you help me with |
Hi @Tensho. The API doesn't return the password. That's definitely a good thing for security! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A couple tweaks to make and removing password
.
|
||
# Data Source: aws_directory_service_directory | ||
|
||
Get attributes of AWS Directory Service directory (SimpleAD, Managed AD, AD Connector). It's especially useful to refer AWS Managed AD or on-premis AD in AD Connector configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling: should be "on-premise"
|
||
func testAccDataSourceAwsDirectoryServiceDirectoryConfig_SimpleAD(alias string) string { | ||
return fmt.Sprintf(` | ||
%s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use return fmt.Sprintf(...) + testAccDataSourceAwsDirectoryServiceDirectoryConfig_Prerequisites("simple-ad")
|
||
func testAccDataSourceAwsDirectoryServiceDirectoryConfig_MicrosoftAD(alias string) string { | ||
return fmt.Sprintf(` | ||
%s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use return fmt.Sprintf(...) + testAccDataSourceAwsDirectoryServiceDirectoryConfig_Prerequisites("microsoft-ad")
a515200
to
e73d1ff
Compare
@gdavison Thank you, TBH, I thought sensitive attributes are returned back from the state on read as they were set there on create. Fixed typo |
@gdavison Please let me know if I can do anything else here 🙇 It would be nice to squash all review commits on merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_SimpleAD (506.62s)
--- PASS: TestAccDataSourceAwsDirectoryServiceDirectory_MicrosoftAD (1834.16s)
This has been released in version 2.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Release note for CHANGELOG:
Example
Acceptance Tests
References