-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #459 - EBS information required during cluster config change #1131
Merged
radeksimko
merged 10 commits into
hashicorp:master
from
dsalbert:fix_issue_459-resource_aws_elasticsearch
Jul 31, 2017
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b0a8352
Issue #459 - EBS information required during cluster configuration ch…
40a82fe
fix formatting
7071e77
add test for #459
268a455
fix and adjust testing method
eaa9795
fix function name for as an entrypoint for Config
d94f173
test: Randomize name of the cluster
radeksimko b24b01a
test: Use even number of data nodes
radeksimko 53ccd7c
test: Specify valid snapshot hours
radeksimko 700bb88
test: Fix test functions
radeksimko 9a41771
Fix tests
radeksimko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly is the reason for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason is purely cosmetic. In case where there is an error, function will
return
from function so there is no need to keepelse
. From other side, by using 'else' we can show that there is a relation betweensetTagsElasticsearchService
andd.SetPartial("tags")
, so if there is any relation between them maybe we should keepelse
:>btw. In documentation there is no
else
block -https://www.terraform.io/docs/plugins/provider.htmlThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you're right, good point. Early return FTW 👍