Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor WorkSpaces resources to use keyvaluetags package #11645

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Refactor WorkSpaces resources to use keyvaluetags package #11645

merged 2 commits into from
Mar 6, 2020

Commits on Feb 25, 2020

  1. r/aws_workspaces_ip_group: Modify acceptance test to have a tag value… 

    … that doesn't change across update.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsWorkspacesIpGroup_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAwsWorkspacesIpGroup_basic -timeout 120m
=== RUN   TestAccAwsWorkspacesIpGroup_basic
=== PAUSE TestAccAwsWorkspacesIpGroup_basic
=== CONT  TestAccAwsWorkspacesIpGroup_basic
--- PASS: TestAccAwsWorkspacesIpGroup_basic (45.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	45.454s
    @ewbankkit
    ewbankkit authored and Kit Ewbank committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    1ea3898 View commit details
    Browse the repository at this point in the history

  2. Remove generated 'WorkspacesUpdateTags' and replace with a custom ver… 

    …sion.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsWorkspacesDirectory/basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAwsWorkspacesDirectory/basic -timeout 120m
=== RUN   TestAccAwsWorkspacesDirectory
=== RUN   TestAccAwsWorkspacesDirectory/basic
--- PASS: TestAccAwsWorkspacesDirectory (661.39s)
    --- PASS: TestAccAwsWorkspacesDirectory/basic (661.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	661.429s
    @ewbankkit
    ewbankkit authored and Kit Ewbank committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    ebfceef View commit details
    Browse the repository at this point in the history