Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/ec2: Refactor Security Group data sources and resources to use keyvaluetags package #11918

Merged
merged 3 commits into from
Mar 6, 2020

Commits on Feb 5, 2020

  1. service/ec2: Refactor Security Group data sources and resources to us…

    …e keyvaluetags package
    
    Reference: #10688
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSSecurityGroup_allowAll (44.69s)
    --- PASS: TestAccAWSSecurityGroup_basic (27.94s)
    --- PASS: TestAccAWSSecurityGroup_change (48.94s)
    --- PASS: TestAccAWSSecurityGroup_CIDRandGroups (39.04s)
    --- PASS: TestAccAWSSecurityGroup_defaultEgressClassic (14.64s)
    --- PASS: TestAccAWSSecurityGroup_defaultEgressVPC (55.75s)
    --- PASS: TestAccAWSSecurityGroup_drift (32.13s)
    --- PASS: TestAccAWSSecurityGroup_driftComplex (41.61s)
    --- PASS: TestAccAWSSecurityGroup_egressConfigMode (128.21s)
    --- PASS: TestAccAWSSecurityGroup_egressWithPrefixList (93.23s)
    --- PASS: TestAccAWSSecurityGroup_failWithDiffMismatch (38.89s)
    --- PASS: TestAccAWSSecurityGroup_forceRevokeRulesFalse (673.09s)
    --- PASS: TestAccAWSSecurityGroup_forceRevokeRulesTrue (673.67s)
    --- PASS: TestAccAWSSecurityGroup_generatedName (55.38s)
    --- PASS: TestAccAWSSecurityGroup_ingressConfigMode (61.07s)
    --- PASS: TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic (56.63s)
    --- PASS: TestAccAWSSecurityGroup_ingressWithCidrAndSGsVPC (35.05s)
    --- PASS: TestAccAWSSecurityGroup_ingressWithPrefixList (53.06s)
    --- PASS: TestAccAWSSecurityGroup_invalidCIDRBlock (2.90s)
    --- PASS: TestAccAWSSecurityGroup_IPRangeAndSecurityGroupWithSameRules (38.69s)
    --- PASS: TestAccAWSSecurityGroup_IPRangesWithSameRules (16.98s)
    --- PASS: TestAccAWSSecurityGroup_ipv4andipv6Egress (27.30s)
    --- PASS: TestAccAWSSecurityGroup_ipv6 (29.00s)
    --- PASS: TestAccAWSSecurityGroup_multiIngress (36.79s)
    --- PASS: TestAccAWSSecurityGroup_namePrefix (34.11s)
    --- PASS: TestAccAWSSecurityGroup_ruleDescription (82.71s)
    --- PASS: TestAccAWSSecurityGroup_ruleGathering (46.13s)
    --- PASS: TestAccAWSSecurityGroup_rulesDropOnError (97.70s)
    --- PASS: TestAccAWSSecurityGroup_self (40.21s)
    --- PASS: TestAccAWSSecurityGroup_sourceSecurityGroup (28.61s)
    --- PASS: TestAccAWSSecurityGroup_tags (94.81s)
    --- PASS: TestAccAWSSecurityGroup_vpc (33.60s)
    --- PASS: TestAccAWSSecurityGroup_vpcNegOneIngress (33.31s)
    --- PASS: TestAccAWSSecurityGroup_vpcProtoNumIngress (35.97s)
    
    --- PASS: TestAccAWSDefaultSecurityGroup_basic (14.07s)
    --- PASS: TestAccAWSDefaultSecurityGroup_classic (10.75s)
    
    --- PASS: TestAccDataSourceAwsSecurityGroup_basic (18.86s)
    
    --- PASS: TestAccDataSourceAwsSecurityGroups_filter (16.63s)
    --- PASS: TestAccDataSourceAwsSecurityGroups_tag (16.73s)
    ```
    bflad committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    d73726e View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2020

  1. Configuration menu
    Copy the full SHA
    81dc92e View commit details
    Browse the repository at this point in the history
  2. service/ec2: Remove now unused setTags and diffTags functions

    Output from acceptance testing:
    
    ```
    --- PASS: TestAccDataSourceAwsSecurityGroup_basic (37.66s)
    
    --- PASS: TestAccDataSourceAwsSecurityGroups_tag (37.81s)
    --- PASS: TestAccDataSourceAwsSecurityGroups_filter (38.43s)
    
    --- PASS: TestAccAWSDefaultSecurityGroup_basic (33.65s)
    --- PASS: TestAccAWSDefaultSecurityGroup_classic (10.22s)
    
    --- PASS: TestAccAWSSecurityGroup_allowAll (64.34s)
    --- PASS: TestAccAWSSecurityGroup_basic (33.11s)
    --- PASS: TestAccAWSSecurityGroup_change (73.42s)
    --- PASS: TestAccAWSSecurityGroup_CIDRandGroups (59.48s)
    --- PASS: TestAccAWSSecurityGroup_defaultEgressClassic (70.38s)
    --- PASS: TestAccAWSSecurityGroup_defaultEgressVPC (43.71s)
    --- PASS: TestAccAWSSecurityGroup_drift (20.32s)
    --- PASS: TestAccAWSSecurityGroup_driftComplex (38.09s)
    --- PASS: TestAccAWSSecurityGroup_egressConfigMode (77.34s)
    --- PASS: TestAccAWSSecurityGroup_egressWithPrefixList (62.50s)
    --- PASS: TestAccAWSSecurityGroup_failWithDiffMismatch (49.74s)
    --- PASS: TestAccAWSSecurityGroup_forceRevokeRulesFalse (690.01s)
    --- PASS: TestAccAWSSecurityGroup_forceRevokeRulesTrue (732.92s)
    --- PASS: TestAccAWSSecurityGroup_generatedName (40.25s)
    --- PASS: TestAccAWSSecurityGroup_ingressConfigMode (57.14s)
    --- PASS: TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic (27.95s)
    --- PASS: TestAccAWSSecurityGroup_ingressWithCidrAndSGsVPC (45.17s)
    --- PASS: TestAccAWSSecurityGroup_ingressWithPrefixList (51.39s)
    --- PASS: TestAccAWSSecurityGroup_invalidCIDRBlock (2.23s)
    --- PASS: TestAccAWSSecurityGroup_IPRangeAndSecurityGroupWithSameRules (43.29s)
    --- PASS: TestAccAWSSecurityGroup_IPRangesWithSameRules (45.55s)
    --- PASS: TestAccAWSSecurityGroup_ipv4andipv6Egress (41.18s)
    --- PASS: TestAccAWSSecurityGroup_ipv6 (34.86s)
    --- PASS: TestAccAWSSecurityGroup_multiIngress (53.10s)
    --- PASS: TestAccAWSSecurityGroup_namePrefix (53.10s)
    --- PASS: TestAccAWSSecurityGroup_ruleDescription (104.82s)
    --- PASS: TestAccAWSSecurityGroup_ruleGathering (65.55s)
    --- PASS: TestAccAWSSecurityGroup_ruleLimitCidrBlockExceededAppend (75.12s)
    --- PASS: TestAccAWSSecurityGroup_ruleLimitExceededAllNew (83.09s)
    --- PASS: TestAccAWSSecurityGroup_ruleLimitExceededAppend (73.30s)
    --- PASS: TestAccAWSSecurityGroup_ruleLimitExceededPrepend (74.60s)
    --- PASS: TestAccAWSSecurityGroup_rulesDropOnError (73.15s)
    --- PASS: TestAccAWSSecurityGroup_self (39.02s)
    --- PASS: TestAccAWSSecurityGroup_sourceSecurityGroup (40.50s)
    --- PASS: TestAccAWSSecurityGroup_tags (83.69s)
    --- PASS: TestAccAWSSecurityGroup_vpc (53.47s)
    --- PASS: TestAccAWSSecurityGroup_vpcNegOneIngress (36.25s)
    --- PASS: TestAccAWSSecurityGroup_vpcProtoNumIngress (66.03s)
    ```
    bflad committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    ddde357 View commit details
    Browse the repository at this point in the history