Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/ec2: Refactor Spot Instance and Fleet resources to use keyvaluetags package #11934

Merged
merged 1 commit into from
Mar 3, 2020

Commits on Feb 6, 2020

  1. service/ec2: Refactor Spot Instance and Fleet resources to use keyval…

    …uetags package
    
    Reference: #10688
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (274.60s)
    --- PASS: TestAccAWSSpotFleetRequest_basic (283.14s)
    --- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (522.10s)
    --- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (298.59s)
    --- PASS: TestAccAWSSpotFleetRequest_fleetType (282.73s)
    --- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (276.40s)
    --- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (274.55s)
    --- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (165.46s)
    --- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (174.06s)
    --- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (292.48s)
    --- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (290.78s)
    --- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (296.09s)
    --- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (289.26s)
    --- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (297.04s)
    --- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (298.03s)
    --- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (297.99s)
    --- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (62.05s)
    --- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (482.51s)
    --- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (839.04s)
    --- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (281.29s)
    --- PASS: TestAccAWSSpotFleetRequest_WithELBs (337.32s)
    --- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (255.23s)
    --- PASS: TestAccAWSSpotFleetRequest_withTags (275.65s)
    --- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (413.66s)
    --- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (369.73s)
    
    --- PASS: TestAccAWSSpotInstanceRequest_withBlockDuration (83.23s)
    --- PASS: TestAccAWSSpotInstanceRequest_validUntil (93.46s)
    --- PASS: TestAccAWSSpotInstanceRequest_withoutSpotPrice (104.36s)
    --- PASS: TestAccAWSSpotInstanceRequest_SubnetAndSGAndPublicIpAddress (113.97s)
    --- PASS: TestAccAWSSpotInstanceRequest_basic (114.64s)
    --- PASS: TestAccAWSSpotInstanceRequest_vpc (122.18s)
    --- PASS: TestAccAWSSpotInstanceRequest_NetworkInterfaceAttributes (126.37s)
    --- PASS: TestAccAWSSpotInstanceRequest_withLaunchGroup (126.68s)
    --- PASS: TestAccAWSSpotInstanceRequest_getPasswordData (247.92s)
    ```
    bflad committed Feb 6, 2020
    Configuration menu
    Copy the full SHA
    3976d71 View commit details
    Browse the repository at this point in the history