Refactor S3 Bucket Metric resource to use keyvaluetags package.

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSS3BucketMetric_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSS3BucketMetric_ -timeout 120m
=== RUN   TestAccAWSS3BucketMetric_basic
=== PAUSE TestAccAWSS3BucketMetric_basic
=== RUN   TestAccAWSS3BucketMetric_WithEmptyFilter
=== PAUSE TestAccAWSS3BucketMetric_WithEmptyFilter
=== RUN   TestAccAWSS3BucketMetric_WithFilterPrefix
=== PAUSE TestAccAWSS3BucketMetric_WithFilterPrefix
=== RUN   TestAccAWSS3BucketMetric_WithFilterPrefixAndMultipleTags
=== PAUSE TestAccAWSS3BucketMetric_WithFilterPrefixAndMultipleTags
=== RUN   TestAccAWSS3BucketMetric_WithFilterPrefixAndSingleTag
=== PAUSE TestAccAWSS3BucketMetric_WithFilterPrefixAndSingleTag
=== RUN   TestAccAWSS3BucketMetric_WithFilterMultipleTags
=== PAUSE TestAccAWSS3BucketMetric_WithFilterMultipleTags
=== RUN   TestAccAWSS3BucketMetric_WithFilterSingleTag
=== PAUSE TestAccAWSS3BucketMetric_WithFilterSingleTag
=== CONT  TestAccAWSS3BucketMetric_basic
=== CONT  TestAccAWSS3BucketMetric_WithFilterPrefixAndSingleTag
=== CONT  TestAccAWSS3BucketMetric_WithFilterSingleTag
=== CONT  TestAccAWSS3BucketMetric_WithFilterMultipleTags
=== CONT  TestAccAWSS3BucketMetric_WithFilterPrefix
=== CONT  TestAccAWSS3BucketMetric_WithEmptyFilter
=== CONT  TestAccAWSS3BucketMetric_WithFilterPrefixAndMultipleTags
--- PASS: TestAccAWSS3BucketMetric_WithEmptyFilter (38.19s)
--- PASS: TestAccAWSS3BucketMetric_basic (40.86s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndMultipleTags (65.30s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndSingleTag (65.90s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterSingleTag (65.91s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefix (65.95s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterMultipleTags (66.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.254s

[gdavison]

LGTM 🚀

--- PASS: TestExpandS3MetricsFilter (0.00s)
--- PASS: TestResourceAwsS3BucketMetricParseID (0.00s)
--- PASS: TestFlattenS3MetricsFilter (0.00s)
--- PASS: TestAccAWSS3BucketMetric_WithEmptyFilter (11.85s)
--- PASS: TestAccAWSS3BucketMetric_basic (12.18s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefix (18.20s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterMultipleTags (18.56s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndSingleTag (18.80s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndMultipleTags (19.06s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterSingleTag (19.21s)

[ghost]

This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!