r/aws_flow_log - add tagging support

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12245

Release note for CHANGELOG:

resource_aws_flow_log: add tagging support

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSFlowLog_'
--- PASS: TestAccAWSFlowLog_VPCID (205.42s)
--- PASS: TestAccAWSFlowLog_LogFormat (274.04s)
--- PASS: TestAccAWSFlowLog_SubnetID (205.10s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs (154.09s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3 (144.37s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_Invalid (73.61s)
--- PASS: TestAccAWSFlowLog_tags (344.29s)
--- PASS: TestAccAWSFlowLog_disappears (149.67s)

[ewbankkit]

Verified acceptance tests:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSFlowLog_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 1 -run=TestAccAWSFlowLog_ -timeout 120m
=== RUN   TestAccAWSFlowLog_VPCID
=== PAUSE TestAccAWSFlowLog_VPCID
=== RUN   TestAccAWSFlowLog_LogFormat
=== PAUSE TestAccAWSFlowLog_LogFormat
=== RUN   TestAccAWSFlowLog_SubnetID
=== PAUSE TestAccAWSFlowLog_SubnetID
=== RUN   TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs
=== PAUSE TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3
=== RUN   TestAccAWSFlowLog_LogDestinationType_S3_Invalid
=== PAUSE TestAccAWSFlowLog_LogDestinationType_S3_Invalid
=== RUN   TestAccAWSFlowLog_tags
=== PAUSE TestAccAWSFlowLog_tags
=== RUN   TestAccAWSFlowLog_disappears
=== PAUSE TestAccAWSFlowLog_disappears
=== CONT  TestAccAWSFlowLog_VPCID
--- PASS: TestAccAWSFlowLog_VPCID (59.42s)
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3_Invalid
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_Invalid (22.28s)
=== CONT  TestAccAWSFlowLog_disappears
--- PASS: TestAccAWSFlowLog_disappears (32.86s)
=== CONT  TestAccAWSFlowLog_tags
--- PASS: TestAccAWSFlowLog_tags (83.21s)
=== CONT  TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs
--- PASS: TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs (37.56s)
=== CONT  TestAccAWSFlowLog_LogDestinationType_S3
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3 (41.06s)
=== CONT  TestAccAWSFlowLog_SubnetID
--- PASS: TestAccAWSFlowLog_SubnetID (40.12s)
=== CONT  TestAccAWSFlowLog_LogFormat
--- PASS: TestAccAWSFlowLog_LogFormat (62.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	380.756s

[bflad]

One little thing, then should be good to go. Hopefully we can address some of the issues with the Terraform Plugin SDK using interface{} all over with something like hashicorp/terraform-plugin-sdk#229

[bflad]

Looks great, thanks so much, @DrFaust92 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_Invalid (8.49s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs (11.92s)
--- PASS: TestAccAWSFlowLog_disappears (12.09s)
--- PASS: TestAccAWSFlowLog_SubnetID (13.39s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3 (13.66s)
--- PASS: TestAccAWSFlowLog_VPCID (18.86s)
--- PASS: TestAccAWSFlowLog_LogFormat (19.77s)
--- PASS: TestAccAWSFlowLog_tags (25.10s)

Output from acceptance testing in AWS GovCloud (US) (test failure unrelated due to hardcoded partition):

--- FAIL: TestAccAWSFlowLog_LogDestinationType_S3_Invalid (7.31s)
--- PASS: TestAccAWSFlowLog_disappears (9.71s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs (10.66s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3 (11.05s)
--- PASS: TestAccAWSFlowLog_SubnetID (14.48s)
--- PASS: TestAccAWSFlowLog_VPCID (16.45s)
--- PASS: TestAccAWSFlowLog_LogFormat (17.23s)
--- PASS: TestAccAWSFlowLog_tags (19.83s)

[ghost]

This has been released in version 2.53.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!