Add AT005 lint rule and fix tests

[FrancisLfg]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11862

Release note for CHANGELOG:

NONE

previously

make lint                                                                                                                                                        
==> Checking source code against linters...                                                                                                                                                                        
terraform-provider-aws/aws/resource_aws_elastic_beanstalk_application_test.go:65:1: AT005: acceptance test function name should begin with TestAcc                                        
64                                                                                                                                                                                                                 
65      func TestAWSElasticBeanstalkApplication_importBasic(t *testing.T) {                                                                                                                                        
66              resourceName := "aws_elastic_beanstalk_application.tftest"                                                                                                                                         
make: *** [GNUmakefile:63: lint] Error 3

and

make lint
==> Checking source code against linters...
terraform-provider-aws/aws/resource_aws_elastic_beanstalk_application_test.go:65:6: AT002: acceptance test function name should not include import
64
65      func TestAccAWSElasticBeanstalkApplication_importBasic(t *testing.T) {
66              resourceName := "aws_elastic_beanstalk_application.tftest"
make: *** [GNUmakefile:63: lint] Error 3

now :

==> Checking source code against linters...

Output from acceptance testing:

TF_ACC=1 go test ./aws -v -run=TestAccAWSElasticBeanstalkApplication_basic
=== RUN   TestAccAWSElasticBeanstalkApplication_basic
=== PAUSE TestAccAWSElasticBeanstalkApplication_basic
=== CONT  TestAccAWSElasticBeanstalkApplication_basic
--- PASS: TestAccAWSElasticBeanstalkApplication_basic (24.32s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       24.343s

...

[bflad]

Thank you for fixing this, @FrancisLfg 🚀

[ghost]

This has been released in version 2.53.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!