Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support manually providing a private IPv4 address for an internal network load balancer #12331

Closed
wants to merge 1 commit into from

Conversation

arnogeurts
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12329

Release note for CHANGELOG:

resource/aws_lb: Add optional `private_ipv4_address` argument to the `subnet_mappings` block

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLB_networkLoadbalancerPrivateIPv4Address'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLB_networkLoadbalancerPrivateIPv4Address -timeout 120m
=== RUN   TestAccAWSLB_networkLoadbalancerPrivateIPv4Address
=== PAUSE TestAccAWSLB_networkLoadbalancerPrivateIPv4Address
=== CONT  TestAccAWSLB_networkLoadbalancerPrivateIPv4Address
--- PASS: TestAccAWSLB_networkLoadbalancerPrivateIPv4Address (235.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	235.228s

@arnogeurts arnogeurts requested a review from a team March 10, 2020 15:27
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elbv2 Issues and PRs that pertain to the elbv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Mar 10, 2020
@ewbankkit
Copy link
Contributor

ewbankkit commented Mar 21, 2020

Closes #11044.
Closes #11887.
Closes #11403.
Closes #11674.

Similar: #11404.

Related: #2901, #11000.

@ewbankkit
Copy link
Contributor

Verified acceptance test:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLB_networkLoadbalancerPrivateIPv4Address'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSLB_networkLoadbalancerPrivateIPv4Address -timeout 120m
=== RUN   TestAccAWSLB_networkLoadbalancerPrivateIPv4Address
=== PAUSE TestAccAWSLB_networkLoadbalancerPrivateIPv4Address
=== CONT  TestAccAWSLB_networkLoadbalancerPrivateIPv4Address
--- PASS: TestAccAWSLB_networkLoadbalancerPrivateIPv4Address (226.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	226.349s

@michalmedvecky
Copy link

I can happily confirm that it works for me <3

@abohne
Copy link

abohne commented Apr 20, 2020

Is there anything we can do to get this merged? I've got some work that is blocked until this functionality is available.

@ericrichtert
Copy link
Contributor

When can this be released, I need this and this will prevent me from using cloudformation.

@DrFaust92
Copy link
Collaborator

Hey @arnogeurts, closing this in favor of #11404

@DrFaust92 DrFaust92 closed this Jun 14, 2020
@ghost
Copy link

ghost commented Jul 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 15, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support manually providing a private IPv4 address for an internal network load balancer
8 participants