Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_route53_zone: Remove deprecated (helper/schema.ResourceData).Partial() and (helper/schema.ResourceData).SetPartial() #12475

Merged
merged 1 commit into from
Mar 30, 2020
Merged

resource/aws_route53_zone: Remove deprecated (helper/schema.ResourceData).Partial() and (helper/schema.ResourceData).SetPartial() #12475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions aws/resource_aws_route53_zone.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,6 @@ func resourceAwsRoute53ZoneUpdate(d *schema.ResourceData, meta interface{}) erro
conn := meta.(*AWSClient).r53conn
region := meta.(*AWSClient).region

d.Partial(true)

if d.HasChange("comment") {
input := route53.UpdateHostedZoneCommentInput{
Id: aws.String(d.Id()),
Expand All @@ -255,8 +253,6 @@ func resourceAwsRoute53ZoneUpdate(d *schema.ResourceData, meta interface{}) erro
if err != nil {
return fmt.Errorf("error updating Route53 Hosted Zone (%s) comment: %s", d.Id(), err)
}

d.SetPartial("comment")
}

if d.HasChange("tags") {
Expand Down Expand Up @@ -298,12 +294,8 @@ func resourceAwsRoute53ZoneUpdate(d *schema.ResourceData, meta interface{}) erro
return err
}
}

d.SetPartial("vpc")
}

d.Partial(false)

return resourceAwsRoute53ZoneRead(d, meta)
}

Expand Down