Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: WAF/Regional Subscribed rule group #12478

Closed
wants to merge 4 commits into from
Closed

New Data Source: WAF/Regional Subscribed rule group #12478

wants to merge 4 commits into from

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12407

Release note for CHANGELOG:

data_source_aws_wafregional_subscribed_rule_group: add new data source
data_source_aws_waf_subscribed_rule_group: add new data source

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsWafRegionalSubscribedRuleGroup_Basic'
--- PASS: TestAccDataSourceAwsWafRegionalSubscribedRuleGroup_Basic (53.61s)

$ make testacc TESTARGS='-run=TestAccDataSourceAwsWafSubscribedRuleGroup_Basic'
--- PASS: TestAccDataSourceAwsWafSubscribedRuleGroup_Basic (52.60s)

@DrFaust92 DrFaust92 requested a review from a team March 19, 2020 09:41
@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Mar 19, 2020
@DrFaust92
Copy link
Collaborator Author

DrFaust92 commented Mar 19, 2020 •
edited
Loading

FYI, this is a bit tricky to test as it requires having subscribed to a rule which cannot be achieved via API.

@DrFaust92
Copy link
Collaborator Author

closed in favor of #10563

@DrFaust92 DrFaust92 closed this Mar 22, 2020
@DrFaust92 DrFaust92 deleted the waf_subscribed_rule-data-source branch March 22, 2020 21:46
@ghost
Copy link

ghost commented Apr 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 21, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/waf Issues and PRs that pertain to the waf service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Data Source: WAF Subscribed rule group
2 participants
@DrFaust92 @breathingdust