Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_snapshot_create_volume_permission: Remove extraneous Exists function #13045

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9953.

Includes testAccCheckResourceDisappears() from #12864.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSnapshotCreateVolumePermission_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSSnapshotCreateVolumePermission_ -timeout 120m
=== RUN   TestAccAWSSnapshotCreateVolumePermission_Basic
=== PAUSE TestAccAWSSnapshotCreateVolumePermission_Basic
=== RUN   TestAccAWSSnapshotCreateVolumePermission_disappears
=== PAUSE TestAccAWSSnapshotCreateVolumePermission_disappears
=== CONT  TestAccAWSSnapshotCreateVolumePermission_Basic
=== CONT  TestAccAWSSnapshotCreateVolumePermission_disappears
--- PASS: TestAccAWSSnapshotCreateVolumePermission_disappears (78.06s)
--- PASS: TestAccAWSSnapshotCreateVolumePermission_Basic (78.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	78.969s

@ewbankkit ewbankkit requested a review from a team April 27, 2020 19:39
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 27, 2020
@bflad bflad self-assigned this Apr 28, 2020
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 28, 2020
@appilon appilon assigned appilon and unassigned bflad Apr 29, 2020
@bflad
Copy link
Contributor

bflad commented Apr 29, 2020

#12864 has been merged so that functionality does not need to be reviewed again. 👍

@appilon appilon added this to the v2.60.0 milestone Apr 29, 2020
@appilon appilon merged commit 8c769c5 into hashicorp:master Apr 29, 2020
@ewbankkit ewbankkit deleted the issue-9953.aws_snapshot_create_volume_permission branch April 30, 2020 11:13
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants