r/aws_redshift_snapshot_copy_grant: Remove extraneous Exists function

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9953.

Includes testAccCheckResourceDisappears() from #12864.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRedshiftSnapshotCopyGrant_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRedshiftSnapshotCopyGrant_ -timeout 120m
=== RUN   TestAccAWSRedshiftSnapshotCopyGrant_Basic
=== PAUSE TestAccAWSRedshiftSnapshotCopyGrant_Basic
=== RUN   TestAccAWSRedshiftSnapshotCopyGrant_Update
=== PAUSE TestAccAWSRedshiftSnapshotCopyGrant_Update
=== RUN   TestAccAWSRedshiftSnapshotCopyGrant_disappears
=== PAUSE TestAccAWSRedshiftSnapshotCopyGrant_disappears
=== CONT  TestAccAWSRedshiftSnapshotCopyGrant_Basic
=== CONT  TestAccAWSRedshiftSnapshotCopyGrant_disappears
=== CONT  TestAccAWSRedshiftSnapshotCopyGrant_Update
--- PASS: TestAccAWSRedshiftSnapshotCopyGrant_disappears (18.83s)
--- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Basic (24.47s)
--- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Update (39.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.376s

[bflad]

#12864 has been merged so that functionality does not need to be reviewed again. 👍

[appilon]

Just one minor pedantic question

[appilon]

if err == nil is it guaranteed this slice has at least 1 item?

[ewbankkit]

In all my testing that was the case, err != nil => out != nil && len(out.SnapshotCopyGrants), but you are correct in that the previous code would have handled opposite by returning nil for the grant. It's minor to add that back (plus change some of the callers to check for a nil grant).

[appilon]

Okay if you don't mind, once that change is made this will get merged! Thank you for helping with all the tech debt.

[ewbankkit]

@appilon Made the suggested changes and added the additional check to make lint as this now closes #9953.

Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSRedshiftSnapshotCopyGrant_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSRedshiftSnapshotCopyGrant_ -timeout 120m
=== RUN   TestAccAWSRedshiftSnapshotCopyGrant_Basic
=== PAUSE TestAccAWSRedshiftSnapshotCopyGrant_Basic
=== RUN   TestAccAWSRedshiftSnapshotCopyGrant_Update
=== PAUSE TestAccAWSRedshiftSnapshotCopyGrant_Update
=== RUN   TestAccAWSRedshiftSnapshotCopyGrant_disappears
=== PAUSE TestAccAWSRedshiftSnapshotCopyGrant_disappears
=== CONT  TestAccAWSRedshiftSnapshotCopyGrant_Update
=== CONT  TestAccAWSRedshiftSnapshotCopyGrant_Basic
=== CONT  TestAccAWSRedshiftSnapshotCopyGrant_disappears
--- PASS: TestAccAWSRedshiftSnapshotCopyGrant_disappears (18.44s)
--- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Basic (23.83s)
--- PASS: TestAccAWSRedshiftSnapshotCopyGrant_Update (53.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	53.354s

[ghost]

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!