Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech debt: enable S018 linter rule #13335

Merged
merged 3 commits into from
Jun 5, 2020
Merged

tech debt: enable S018 linter rule #13335

merged 3 commits into from
Jun 5, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented May 15, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9956

Release note for CHANGELOG:

enable S018 linter rule

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. labels May 15, 2020
@anGie44 anGie44 added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label May 15, 2020
@anGie44 anGie44 marked this pull request as ready for review May 15, 2020 16:19
@anGie44 anGie44 requested a review from a team May 15, 2020 16:19
@anGie44 anGie44 linked an issue May 15, 2020 that may be closed by this pull request
Fix and enable tfproviderlint S018 check: Use TypeList and MaxItems: 1 #9956
Closed
28 tasks
@gdavison gdavison self-assigned this May 19, 2020
gdavison
gdavison previously approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gdavison gdavison dismissed their stale review May 19, 2020 19:41

Travis failure

@gdavison gdavison removed their assignment May 19, 2020
@anGie44 anGie44 removed a link to an issue May 19, 2020
Fix and enable tfproviderlint S018 check: Use TypeList and MaxItems: 1 #9956
Closed
28 tasks
@anGie44 anGie44 requested a review from gdavison June 5, 2020 19:09
gdavison
gdavison approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@anGie44 anGie44 merged commit d15a5fe into master Jun 5, 2020
@anGie44 anGie44 deleted the ap_typelist_gnumakefile branch June 5, 2020 19:49
@ghost
Copy link

ghost commented Jul 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 6, 2020
@breathingdust breathingdust added the linter Pertains to changes to or issues with the various linters. label Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees
No one assigned
Labels
linter Pertains to changes to or issues with the various linters. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix and enable tfproviderlint S018 check: Use TypeList and MaxItems: 1
3 participants
@anGie44 @gdavison @breathingdust