r/aws_ses_event_destination: Refresh resource state in the Read method

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13464.
Relates #13344.

Release note for CHANGELOG:

resource/aws_ses_event_destination: Correctly refresh resource state

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSESEventDestination_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSSESEventDestination_ -timeout 120m
=== RUN   TestAccAWSSESEventDestination_basic
=== PAUSE TestAccAWSSESEventDestination_basic
=== RUN   TestAccAWSSESEventDestination_disappears
=== PAUSE TestAccAWSSESEventDestination_disappears
=== CONT  TestAccAWSSESEventDestination_basic
=== CONT  TestAccAWSSESEventDestination_disappears
--- PASS: TestAccAWSSESEventDestination_disappears (120.14s)
--- PASS: TestAccAWSSESEventDestination_basic (122.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	122.122s

[ewbankkit]

$ grep -Pzo "Read\(d\s+\*schema\.ResourceData,\s+meta\s+interface\{\}\)\s+error\s+{\s+return\s+nil\s+" aws/*.go
aws/resource_aws_ses_event_destination.go:Read(d *schema.ResourceData, meta interface{}) error {

	return nil

aws_ses_event_destination seems to be the only resource which has this behavior.

[ewbankkit]

Re-ran acceptance tests:

n_ -timeout 120m
=== RUN   TestAccAWSSESEventDestination_basic
=== PAUSE TestAccAWSSESEventDestination_basic
=== RUN   TestAccAWSSESEventDestination_disappears
=== PAUSE TestAccAWSSESEventDestination_disappears
=== CONT  TestAccAWSSESEventDestination_basic
=== CONT  TestAccAWSSESEventDestination_disappears
--- PASS: TestAccAWSSESEventDestination_disappears (122.44s)
--- PASS: TestAccAWSSESEventDestination_basic (137.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	137.132s

[bflad]

Looks good to me, thanks so much, @ewbankkit 🚀

Output from acceptance testing:

--- PASS: TestAccAWSSESEventDestination_disappears (79.94s)
--- PASS: TestAccAWSSESEventDestination_basic (90.04s)

[ghost]

This has been released in version 2.64.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!