Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeSetCheck: Treat unset values as matched #13807

Merged
merged 2 commits into from
Jun 17, 2020
Merged

TypeSetCheck: Treat unset values as matched #13807

merged 2 commits into from
Jun 17, 2020

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Jun 17, 2020

This allows matching Set elements where a key was deliberately unset (therefore not present in state). You must however, provide a value map with at least 1 non-empty value.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13556

Release note for CHANGELOG:

NONE

Output from acceptance testing:

/usr/local/bin/go test -timeout 30s github.com/terraform-providers/terraform-provider-aws/aws/internal/tfawsresource -run ^(TestTestCheckTypeSetElemAttr|TestTestCheckTypeSetElemNestedAttrs)$

ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/tfawsresource

@appilon appilon requested a review from a team June 17, 2020 19:02
@ghost ghost added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 17, 2020
@appilon appilon changed the title Treat unset values as matched TypeSetCheck: Treat unset values as matched Jun 17, 2020
bflad
bflad approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock on! 🎸

@appilon appilon merged commit 02b813c into master Jun 17, 2020
@appilon appilon deleted the b-typeset-check-unset branch June 17, 2020 20:05
@ghost
Copy link

ghost commented Jul 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@appilon @bflad