Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Sources: Cloudwatch Event Rule(s) #14467

Closed
wants to merge 2 commits into from
Closed

New Data Sources: Cloudwatch Event Rule(s) #14467

wants to merge 2 commits into from

Conversation

surminus
Copy link
Contributor

@surminus surminus commented Aug 4, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

New Data Source: aws_cloudwatch_event_rule
New Data Source: aws_cloudwatch_event_rules

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudwatchEventRule.*DataSource'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudwatchEventRule.*DataSource -timeout 120m
=== RUN   TestAccAWSCloudwatchEventRuleDataSource
=== PAUSE TestAccAWSCloudwatchEventRuleDataSource
=== RUN   TestAccAWSCloudwatchEventRulesDataSource
=== PAUSE TestAccAWSCloudwatchEventRulesDataSource
=== CONT  TestAccAWSCloudwatchEventRuleDataSource
=== CONT  TestAccAWSCloudwatchEventRulesDataSource
--- PASS: TestAccAWSCloudwatchEventRuleDataSource (21.32s)
--- PASS: TestAccAWSCloudwatchEventRulesDataSource (21.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	21.370s

API reference for aws_cloudwatch_event_rule

API reference for aws_cloudwatch_event_rules

@surminus surminus requested a review from a team August 4, 2020 18:12
@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudwatchevents tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 4, 2020
@surminus surminus force-pushed the lm-data-cloudwatch-event-rules branch from 6b48f01 to 536673e Compare August 5, 2020 11:11
@surminus
Add cloudwatch_event_rules data source
c6d3f62 
This is a data source used to query event rules by name_prefix, and
returns a list of rules names.

The motivation for this data source is that I have a deployment that
create event rules outside of Terraform, but I wish to be able to create
different resources based upon the event rules that have been created.

I also intend to add a cloudwatch_event_rule data source that provides
full details for an event rule object.
@surminus
Add cloudwatch_event_rule data source
829bd14 
This returns details about a specific cloudwatch event rule.
@surminus surminus force-pushed the lm-data-cloudwatch-event-rules branch from 536673e to 829bd14 Compare August 5, 2020 11:21
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Aug 5, 2020
@teamterraform
Copy link

Notification of Recent and Upcoming Changes to Contributions

Thank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization.

If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items.

For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the technical-debt label on issues.

As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported.

Terraform 0.12 Syntax

Reference: #8950
Reference: #14417

Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations (some_attribute = "${aws_service_thing.example.id}") should be updated to the newer syntax (some_attribute = aws_service_thing.example.id). Contribution testing will automatically fail on older syntax in the near future. Please see the referenced issues for additional information.

Action Required: Terraform Plugin SDK Version 2

Reference: #14551

The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information.

Removal of website/aws.erb File

Reference: #14712

Any changes to the website/aws.erb file are no longer necessary and should be removed from this contribution to prevent merge issues in the near future when the file is removed from the repository. Please see the referenced issue for additional information.

Upcoming Change of Git Branch Naming

Reference: #14292

Development environments will need their upstream Git branch updated from master to main in the near future. Please see the referenced issue for additional information and scheduling.

Upcoming Change of GitHub Organization

Reference: #14715

This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including terraform-providers can remain for now. Please see the referenced issue for additional information and scheduling.

@gdavison gdavison added service/eventbridge new-data-source Introduces a new data source. labels Oct 30, 2020
Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 8, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@surminus
Copy link
Contributor Author

Closing because I no longer require this.

@surminus surminus closed this Oct 20, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@surminus @teamterraform @zhelding @breathingdust @gdavison @hc-github-team-terraform-aws