Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data source config formatting, 0.12 up to regions #14479

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Aug 5, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #8950

Release note for CHANGELOG:

NONE

The output from acceptance testing:

(Note that TestAccDataSourceAWSLambdaFunction_vpc failed on TC, re-ran locally and it passed.)

--- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (9.35s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (26.39s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (26.71s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (27.65s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (29.03s)
--- PASS: TestAccDataSourceAwsNetworkAcls_VpcID (31.90s)
--- PASS: TestAccDataSourceAwsNetworkInterface_filters (32.51s)
--- PASS: TestAccDataSourceAwsNetworkAcls_Filter (33.99s)
--- PASS: TestAccDataSourceAwsNetworkInterface_basic (34.55s)
--- PASS: TestAccDataSourceAwsNetworkAcls_Tags (35.78s)
--- PASS: TestAccDataSourceAwsNetworkInterfaces_Filter (32.27s)
--- PASS: TestAccAWSPartition_basic (19.25s)
--- PASS: TestAccDataSourceAwsNetworkAcls_basic (47.57s)
--- PASS: TestAccDataSourceAwsPrefixList_basic (20.88s)
--- PASS: TestAccDataSourceAwsPrefixList_filter (20.32s)
--- PASS: TestAccDataSourceAWSLambdaFunction_layers (50.93s)
--- PASS: TestAccDataSourceAWSLambdaFunction_basic (51.36s)
--- PASS: TestAccDataSourceAwsNetworkInterfaces_Tags (26.90s)
--- PASS: TestAccDataSourceAwsPricingProduct_ec2 (24.80s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (56.90s)
--- PASS: TestAccDataSourceAwsPricingProduct_redshift (25.01s)
--- PASS: TestAccDataSourceAwsRamResourceShare_Tags (23.26s)
--- PASS: TestAccAWSRedshiftServiceAccount_basic (13.30s)
--- PASS: TestAccDataSourceAWSLambdaFunction_environment (63.26s)
--- PASS: TestAccAWSRedshiftServiceAccount_Region (13.04s)
--- PASS: TestAccDataSourceAwsRegions_basic (12.90s)
--- PASS: TestAccDataSourceAwsRegions_Filter (12.22s)
--- PASS: TestAccDataSourceAWSLambdaFunction_alias (65.60s)
--- PASS: TestAccDataSourceAwsRegions_AllRegions (10.15s)
--- PASS: TestAccDataSourceAWSLambdaFunction_version (71.14s)
--- PASS: TestAccDataSourceAwsRamResourceShare_basic (38.99s)
--- PASS: TestAccDataSourceAwsQLDBLedger_basic (55.82s)
--- PASS: TestAccDataSourceAwsNatGateway_basic (201.02s)
--- PASS: TestAccDataSourceAWSRDSCluster_basic (180.35s)
--- PASS: TestAccAWSDataSourceRedshiftCluster_basic (365.11s)
--- PASS: TestAccDataSourceAWSLambdaFunction_vpc (414.08s)
--- PASS: TestAccAWSDataSourceRedshiftCluster_logging (421.25s)
--- PASS: TestAccAWSDataSourceRedshiftCluster_vpc (521.89s)
--- PASS: TestAccDataSourceAWSLambdaFunction_fileSystemConfig (654.90s)

@YakDriver YakDriver requested a review from a team August 5, 2020 18:27
@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. service/lambda Issues and PRs that pertain to the lambda service. service/organizations Issues and PRs that pertain to the organizations service. service/pricing Issues and PRs that pertain to the pricing service. service/qldb Issues and PRs that pertain to the qldb service. service/ram Issues and PRs that pertain to the ram service. service/rds Issues and PRs that pertain to the rds service. service/redshift Issues and PRs that pertain to the redshift service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 5, 2020
@YakDriver YakDriver marked this pull request as draft August 5, 2020 18:30
@YakDriver YakDriver force-pushed the td-config-format-ds6 branch from 00a8231 to ae3e1cf Compare August 5, 2020 20:19
@YakDriver YakDriver marked this pull request as ready for review August 5, 2020 20:26
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@YakDriver YakDriver added this to the v3.1.0 milestone Aug 6, 2020
@YakDriver YakDriver merged commit c0f2194 into master Aug 6, 2020
@YakDriver YakDriver deleted the td-config-format-ds6 branch August 6, 2020 14:08
@ghost
Copy link

ghost commented Aug 7, 2020

This has been released in version 3.1.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Aug 27, 2020
@ghost
Copy link

ghost commented Sep 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. service/lambda Issues and PRs that pertain to the lambda service. service/organizations Issues and PRs that pertain to the organizations service. service/pricing Issues and PRs that pertain to the pricing service. service/qldb Issues and PRs that pertain to the qldb service. service/ram Issues and PRs that pertain to the ram service. service/rds Issues and PRs that pertain to the rds service. service/redshift Issues and PRs that pertain to the redshift service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants