-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
f/aws_fsx_lustre_file_system specify custom KMS Key #15057
Merged
bflad
merged 18 commits into
hashicorp:master
from
nikhil-goenka:aws_fsx_lustre_file_system-custom-KMS-Key
Sep 22, 2020
Merged
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1cf3995
aws_fsx_lustre_file_system specify custom KMS Key
nikhil-goenka 1138cb1
aws_fsx_lustre_file_system specify custom KMS Key
nikhil-goenka 9f6f591
aws_fsx_lustre_file_system specify custom KMS Key
nikhil-goenka 62af651
Merge branch 'master' into aws_fsx_lustre_file_system-custom-KMS-Key
nikhil-goenka bc0219f
aws_fsx_lustre_file_system specify custom KMS Key
nikhil-goenka 4875d2f
aws_fsx_lustre_file_system specify custom KMS Key
nikhil-goenka 55a1184
aws_fsx_lustre_file_system specify custom KMS Key
nikhil-goenka d5889b1
Merge remote-tracking branch 'origin/aws_fsx_lustre_file_system-custo…
nikhil-goenka 8b564f7
aws_fsx_lustre_file_system specify custom KMS Key
nikhil-goenka 919a1d5
aws_fsx_lustre_file_system specify custom KMS Key
nikhil-goenka 1a0f5dd
aws_fsx_lustre_file_system specify custom KMS Key
nikhil-goenka 9305b8b
Merge remote-tracking branch 'origin/aws_fsx_lustre_file_system-custo…
nikhil-goenka 36c9331
Merge branch 'master' into aws_fsx_lustre_file_system-custom-KMS-Key
nikhil-goenka 9eab2ac
tech-debt/aws_rds_cluster:TestAccAWSRDSCluster_SnapshotIdentifier_Pre…
nikhil-goenka e372705
tech-debt/aws_rds_cluster:TestAccAWSRDSCluster_SnapshotIdentifier_Pre…
nikhil-goenka 2301bd0
tech-debt/aws_rds_cluster:TestAccAWSRDSCluster_SnapshotIdentifier_Pre…
nikhil-goenka ca7d23a
f/aws_fsx_lustre_file_system specify custom KMS Key
nikhil-goenka 07ac294
f/aws_fsx_lustre_file_system specify custom KMS Key
nikhil-goenka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,8 +32,9 @@ The following arguments are supported: | |
* `security_group_ids` - (Optional) A list of IDs for the security groups that apply to the specified network interfaces created for file system access. These security groups will apply to all network interfaces. | ||
* `tags` - (Optional) A map of tags to assign to the file system. | ||
* `weekly_maintenance_start_time` - (Optional) The preferred start time (in `d:HH:MM` format) to perform weekly maintenance, in the UTC time zone. | ||
* `deployment_type` - (Optional) The filesystem deployment type. One of: `SCRATCH_1`, `SCRATCH_2`, `PERSISTENT_1`. | ||
* `per_unit_storage_throughput` - (Optional) Describes the amount of read and write throughput for each 1 tebibyte of storage, in MB/s/TiB, required for the `PERSISTENT_1` deployment_type. For valid values, see the [AWS documentation](https://docs.aws.amazon.com/fsx/latest/APIReference/API_CreateFileSystemLustreConfiguration.html). | ||
* `deployment_type` - (Optional) - The filesystem deployment type. One of: `SCRATCH_1`, `SCRATCH_2`, `PERSISTENT_1`. | ||
* `kms_key_id` - (Optional) ARN for the KMS Key to encrypt the file system at rest. Defaults to an AWS managed KMS Key, required for the `PERSISTENT_1`. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Its not really required as the default key is used if not passed, let remove the required comment is misleading, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. updated the comment. |
||
* `per_unit_storage_throughput` - (Optional) - Describes the amount of read and write throughput for each 1 tebibyte of storage, in MB/s/TiB, required for the `PERSISTENT_1` deployment_type. For valid values, see the [AWS documentation](https://docs.aws.amazon.com/fsx/latest/APIReference/API_CreateFileSystemLustreConfiguration.html). | ||
* `automatic_backup_retention_days` - (Optional) The number of days to retain automatic backups. Setting this to 0 disables automatic backups. You can retain automatic backups for a maximum of 35 days. only valid for `PERSISTENT_1` deployment_type. | ||
|
||
## Attributes Reference | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let remove the type check, AFAIK this kind of check isn't usually done in terraform as this should return an error to the user as the actual API would for an illegal combination.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can add a comment that this is relevant only for
TypePersistent1
instead of the required oneThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed