Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/resource/aws_elasticsearch_domain: Use multierror in sweeper and skip domains stuck in deleting status #16648

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 8, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

NONE

Workaround for buggy API.

Output from sweeper in AWS Commercial:

2020/12/08 12:52:28 [DEBUG] Running Sweepers for region (us-west-2):
2020/12/08 12:52:28 [DEBUG] Running Sweeper (aws_elasticsearch_domain) in region (us-west-2)
2020/12/08 12:52:30 [INFO] Skipping Elasticsearch Domain (tf-test-5082256297594881822) with deleted status
2020/12/08 12:52:30 [INFO] Skipping Elasticsearch Domain (tf-test-841758105109071952) with deleted status
2020/12/08 12:52:30 Sweeper Tests ran successfully:
	- aws_elasticsearch_domain
2020/12/08 12:52:30 [DEBUG] Running Sweepers for region (us-east-1):
2020/12/08 12:52:30 [DEBUG] Running Sweeper (aws_elasticsearch_domain) in region (us-east-1)
2020/12/08 12:52:31 Sweeper Tests ran successfully:
	- aws_elasticsearch_domain
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.998s

Output from sweeper in AWS GovCloud (US):

2020/12/08 12:54:08 [DEBUG] Running Sweepers for region (us-gov-west-1):
2020/12/08 12:54:08 [DEBUG] Running Sweeper (aws_elasticsearch_domain) in region (us-gov-west-1)
2020/12/08 12:54:10 [DEBUG] Deleting ElasticSearch domain: "tf-test-579248222605063900"
2020/12/08 12:54:11 [DEBUG] Waiting for ElasticSearch domain "tf-test-579248222605063900" to be deleted
2020/12/08 12:56:54 Sweeper Tests ran successfully:
	- aws_elasticsearch_domain
ok  	github.com/terraform-providers/terraform-provider-aws/aws	168.818s

…d skip domains stuck in deleting status

Workaround for buggy API.

Output from sweeper in AWS Commercial:

```
2020/12/08 12:52:28 [DEBUG] Running Sweepers for region (us-west-2):
2020/12/08 12:52:28 [DEBUG] Running Sweeper (aws_elasticsearch_domain) in region (us-west-2)
2020/12/08 12:52:30 [INFO] Skipping Elasticsearch Domain (tf-test-5082256297594881822) with deleted status
2020/12/08 12:52:30 [INFO] Skipping Elasticsearch Domain (tf-test-841758105109071952) with deleted status
2020/12/08 12:52:30 Sweeper Tests ran successfully:
	- aws_elasticsearch_domain
2020/12/08 12:52:30 [DEBUG] Running Sweepers for region (us-east-1):
2020/12/08 12:52:30 [DEBUG] Running Sweeper (aws_elasticsearch_domain) in region (us-east-1)
2020/12/08 12:52:31 Sweeper Tests ran successfully:
	- aws_elasticsearch_domain
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.998s
```

Output from sweeper in AWS GovCloud (US):

```
2020/12/08 12:54:08 [DEBUG] Running Sweepers for region (us-gov-west-1):
2020/12/08 12:54:08 [DEBUG] Running Sweeper (aws_elasticsearch_domain) in region (us-gov-west-1)
2020/12/08 12:54:10 [DEBUG] Deleting ElasticSearch domain: "tf-test-579248222605063900"
2020/12/08 12:54:11 [DEBUG] Waiting for ElasticSearch domain "tf-test-579248222605063900" to be deleted
2020/12/08 12:56:54 Sweeper Tests ran successfully:
	- aws_elasticsearch_domain
ok  	github.com/terraform-providers/terraform-provider-aws/aws	168.818s
```
@bflad bflad requested a review from a team as a code owner December 8, 2020 18:04
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 8, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v3.22.0 milestone Dec 16, 2020
@bflad bflad merged commit aba6707 into master Dec 16, 2020
@bflad bflad deleted the t-aws_elasticsearch_domain-sweeper-deleting branch December 16, 2020 21:14
@ghost
Copy link

ghost commented Dec 18, 2020

This has been released in version 3.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 16, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/elasticsearch Issues and PRs that pertain to the elasticsearch service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants