Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BatchbuildConfig to Codebuild #16729

Closed

Conversation

tocy1
Copy link

@tocy1 tocy1 commented Dec 11, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeBuildProject_BuildBatchConfig_BuildTimeout'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeBuildProject_BuildBatchConfig_BuildTimeout -timeout 120m
=== RUN   TestAccAWSCodeBuildProject_BuildBatchConfig_BuildTimeout
=== PAUSE TestAccAWSCodeBuildProject_BuildBatchConfig_BuildTimeout
=== CONT  TestAccAWSCodeBuildProject_BuildBatchConfig_BuildTimeout
--- PASS: TestAccAWSCodeBuildProject_BuildBatchConfig_BuildTimeout (113.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	115.433s
...
$ make testacc TESTARGS='-run=TestAccAWSCodeBuildProject_BuildBatchConfig_CombineArtifacts'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeBuildProject_BuildBatchConfig_CombineArtifacts -timeout 120m
=== RUN   TestAccAWSCodeBuildProject_BuildBatchConfig_CombineArtifacts
=== PAUSE TestAccAWSCodeBuildProject_BuildBatchConfig_CombineArtifacts
=== CONT  TestAccAWSCodeBuildProject_BuildBatchConfig_CombineArtifacts
--- PASS: TestAccAWSCodeBuildProject_BuildBatchConfig_CombineArtifacts (113.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	115.088s
...

@tocy1 tocy1 requested a review from a team as a code owner December 11, 2020 23:10
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/codebuild Issues and PRs that pertain to the codebuild service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 11, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 11, 2020
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @tocy1 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

Base automatically changed from master to main January 23, 2021 00:59
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 29, 2021
@ewbankkit
Copy link
Contributor

@tocy1 Thanks for the contribution 👏.
There is a duplicate PR (#14534) with fewer conflicts that will allow a quicker merge.
Closing this one.

@ewbankkit ewbankkit closed this Apr 29, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/codebuild Issues and PRs that pertain to the codebuild service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants