resource/aws_ecs_service: Add support for deployment circuit breaker

[shuheiktgw]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16499
Closes #18364

Release note for CHANGELOG:

resource/aws_ecs_service: Add support for deployment circuit breaker

Output from acceptance testing:

$  make testacc TESTARGS='-run=TestAccAWSEcsService_withDeploymentCircuitBreaker'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsService_withDeploymentCircuitBreaker -timeout 120m
=== RUN   TestAccAWSEcsService_withDeploymentCircuitBreaker
=== PAUSE TestAccAWSEcsService_withDeploymentCircuitBreaker
=== CONT  TestAccAWSEcsService_withDeploymentCircuitBreaker
--- PASS: TestAccAWSEcsService_withDeploymentCircuitBreaker (101.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	103.757s

Thank you for your review! 👍

[shuheiktgw]

goreleaser failure seems to happen in other PRs so I don't think that is due to this PR.

[hanswesterbeek]

Looking forward to seeing this merged. @bflad Can you have a look?

[berchev]

Hello Team,

Do you have any ETA when this PR is going to get merged?
We have TF Cloud customer (Team & Governance) interested on that.
Thank you in advance!

Regards,
Georgi Berchev

[mimozell]

Any updates on this? Looking forward to using it 😊

[YakDriver]

Looks great! 🎉

Acceptance tests on GovCloud:

--- PASS: TestAccAWSEcsService_withPlacementStrategy_Type_Missing (4.23s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (50.26s)
--- PASS: TestAccAWSEcsService_withARN (65.87s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_External (68.57s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (79.76s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (81.37s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (82.06s)
--- PASS: TestAccAWSEcsService_withForceNewDeployment (96.36s)
--- PASS: TestAccAWSEcsService_withDeploymentCircuitBreaker (96.72s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (96.72s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (96.75s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (61.96s)
--- PASS: TestAccAWSEcsService_withLbChanges (113.90s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (127.01s)
--- SKIP: TestAccAWSEcsService_withServiceRegistries_container (0.00s)
--- SKIP: TestAccAWSEcsService_withServiceRegistriesChanges (0.00s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (139.11s)
--- PASS: TestAccAWSEcsService_withIamRole (77.44s)
--- SKIP: TestAccAWSEcsService_withServiceRegistries (0.00s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndWaitForSteadyState (161.14s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (166.51s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (86.25s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (86.41s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (181.89s)
--- PASS: TestAccAWSEcsService_disappears (73.27s)
--- PASS: TestAccAWSEcsService_ExecuteCommand (92.51s)
--- PASS: TestAccAWSEcsService_basicImport (78.56s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndUpdateWaitForSteadyState (192.59s)
--- PASS: TestAccAWSEcsService_withMultipleCapacityProviderStrategies (140.81s)
--- PASS: TestAccAWSEcsService_Tags (117.88s)
--- PASS: TestAccAWSEcsService_ManagedTags (89.38s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (89.08s)
--- PASS: TestAccAWSEcsService_withMultipleTargetGroups (234.90s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (89.02s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (251.49s)
--- PASS: TestAccAWSEcsService_withAlb (257.87s)
--- PASS: TestAccAWSEcsService_PropagateTags (194.66s)
--- PASS: TestAccAWSEcsService_withCapacityProviderStrategy (210.47s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (301.17s)

Acceptance tests on commercial:

--- PASS: TestAccAWSEcsService_withPlacementStrategy_Type_Missing (5.38s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (50.59s)
--- PASS: TestAccAWSEcsService_withForceNewDeployment (62.61s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (64.58s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (66.14s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (81.91s)
--- PASS: TestAccAWSEcsService_withARN (93.24s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (97.12s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (112.69s)
--- PASS: TestAccAWSEcsService_withLbChanges (118.49s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (121.83s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (85.89s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (79.95s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_External (57.08s)
--- PASS: TestAccAWSEcsService_Tags (92.85s)
--- PASS: TestAccAWSEcsService_ExecuteCommand (97.77s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (170.84s)
--- PASS: TestAccAWSEcsService_withIamRole (64.78s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (95.57s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndUpdateWaitForSteadyState (188.66s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (189.72s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (186.38s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndWaitForSteadyState (194.75s)
--- PASS: TestAccAWSEcsService_disappears (69.89s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (85.73s)
--- PASS: TestAccAWSEcsService_withCapacityProviderStrategy (207.89s)
--- PASS: TestAccAWSEcsService_withMultipleCapacityProviderStrategies (120.70s)
--- PASS: TestAccAWSEcsService_ManagedTags (70.19s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (85.27s)
--- PASS: TestAccAWSEcsService_basicImport (73.15s)
--- PASS: TestAccAWSEcsService_withAlb (245.39s)
--- PASS: TestAccAWSEcsService_withMultipleTargetGroups (246.50s)
--- PASS: TestAccAWSEcsService_withDeploymentCircuitBreaker (86.10s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (86.12s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (264.41s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (156.41s)
--- PASS: TestAccAWSEcsService_PropagateTags (184.23s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (242.54s)
--- PASS: TestAccAWSEcsService_withServiceRegistriesChanges (366.84s)

[ghost]

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!