Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/efs_file_system - add attributes + refactor to use waiter package #17969

Merged
merged 10 commits into from
Mar 26, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEFSFileSystem_'
--- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (28.50s)
--- PASS: TestAccAWSEFSFileSystem_pagedTags (53.94s)
--- PASS: TestAccAWSEFSFileSystem_disappears (53.99s)
--- PASS: TestAccAWSEFSFileSystem_kmsKey (78.62s)
--- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (90.30s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy (94.44s)
--- PASS: TestAccAWSEFSFileSystem_ThroughputMode (94.75s)
--- PASS: TestAccAWSEFSFileSystem_basic (103.86s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_removal (107.29s)
--- PASS: TestAccAWSEFSFileSystem_tags (180.87s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_update (183.95s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner March 6, 2021 15:03
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/efs Issues and PRs that pertain to the efs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 6, 2021
@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSEFSFileSystem_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEFSFileSystem_ -timeout 120m
=== RUN   TestAccAWSEFSFileSystem_basic
=== PAUSE TestAccAWSEFSFileSystem_basic
=== RUN   TestAccAWSEFSFileSystem_tags
=== PAUSE TestAccAWSEFSFileSystem_tags
=== RUN   TestAccAWSEFSFileSystem_pagedTags
=== PAUSE TestAccAWSEFSFileSystem_pagedTags
=== RUN   TestAccAWSEFSFileSystem_kmsKey
=== PAUSE TestAccAWSEFSFileSystem_kmsKey
=== RUN   TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption
=== PAUSE TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption
=== RUN   TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps
=== PAUSE TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps
=== RUN   TestAccAWSEFSFileSystem_ThroughputMode
=== PAUSE TestAccAWSEFSFileSystem_ThroughputMode
=== RUN   TestAccAWSEFSFileSystem_lifecyclePolicy
=== PAUSE TestAccAWSEFSFileSystem_lifecyclePolicy
=== RUN   TestAccAWSEFSFileSystem_lifecyclePolicy_update
=== PAUSE TestAccAWSEFSFileSystem_lifecyclePolicy_update
=== RUN   TestAccAWSEFSFileSystem_lifecyclePolicy_removal
=== PAUSE TestAccAWSEFSFileSystem_lifecyclePolicy_removal
=== RUN   TestAccAWSEFSFileSystem_disappears
=== PAUSE TestAccAWSEFSFileSystem_disappears
=== CONT  TestAccAWSEFSFileSystem_basic
=== CONT  TestAccAWSEFSFileSystem_ThroughputMode
=== CONT  TestAccAWSEFSFileSystem_disappears
=== CONT  TestAccAWSEFSFileSystem_lifecyclePolicy_removal
=== CONT  TestAccAWSEFSFileSystem_lifecyclePolicy_update
=== CONT  TestAccAWSEFSFileSystem_lifecyclePolicy
=== CONT  TestAccAWSEFSFileSystem_kmsKey
=== CONT  TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps
=== CONT  TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption
=== CONT  TestAccAWSEFSFileSystem_pagedTags
=== CONT  TestAccAWSEFSFileSystem_tags
--- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (17.69s)
--- PASS: TestAccAWSEFSFileSystem_kmsKey (61.96s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_update (70.51s)
--- PASS: TestAccAWSEFSFileSystem_basic (74.90s)
--- PASS: TestAccAWSEFSFileSystem_pagedTags (99.69s)
--- PASS: TestAccAWSEFSFileSystem_ThroughputMode (101.77s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy (104.60s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_removal (106.78s)
--- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (128.89s)
--- PASS: TestAccAWSEFSFileSystem_disappears (134.35s)
--- PASS: TestAccAWSEFSFileSystem_tags (140.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	140.282s

DrFaust92 and others added 5 commits March 7, 2021 09:41
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@bflad bflad self-assigned this Mar 26, 2021
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 26, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you, @DrFaust92 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (15.26s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy (29.48s)
--- PASS: TestAccAWSEFSFileSystem_disappears (37.95s)
--- PASS: TestAccAWSEFSFileSystem_kmsKey (54.93s)
--- PASS: TestAccAWSEFSFileSystem_ThroughputMode (65.88s)
--- PASS: TestAccAWSEFSFileSystem_basic (83.23s)
--- PASS: TestAccAWSEFSFileSystem_pagedTags (85.76s)
--- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (94.41s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_removal (96.71s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_update (107.04s)
--- PASS: TestAccAWSEFSFileSystem_tags (142.76s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (19.51s)
--- PASS: TestAccAWSEFSFileSystem_pagedTags (58.12s)
--- PASS: TestAccAWSEFSFileSystem_kmsKey (64.15s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy (67.15s)
--- PASS: TestAccAWSEFSFileSystem_disappears (85.41s)
--- PASS: TestAccAWSEFSFileSystem_basic (95.51s)
--- PASS: TestAccAWSEFSFileSystem_ThroughputMode (101.41s)
--- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (103.19s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_update (105.87s)
--- PASS: TestAccAWSEFSFileSystem_tags (149.67s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_removal (151.51s)

@bflad bflad merged commit 79998b1 into hashicorp:main Mar 26, 2021
@github-actions github-actions bot added this to the v3.35.0 milestone Mar 26, 2021
@ghost
Copy link

ghost commented Apr 1, 2021

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the r/efs_fs_refactor branch April 15, 2021 10:35
@ghost
Copy link

ghost commented Apr 26, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/efs Issues and PRs that pertain to the efs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants