tests/provider: Fix compilation-time randomization in test configuration, enable semgrep rule to catch coding issue

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #18175
Closes #18204

Also adds ErrorCheck while adjusting these tests.

Previously:

aws/data_source_aws_cloudfront_distribution_test.go
severity:warning rule:helper-acctest-RandInt-compiled: Using `acctest.RandInt()` in constant or variable declaration will execute during compilation and not randomize, pass into string generating function instead
36:var testAccAWSCloudFrontDistributionData = fmt.Sprintf(`
37:%s
38:
39:data "aws_cloudfront_distribution" "test" {
40:  id = aws_cloudfront_distribution.s3_distribution.id
41:}
42:`, fmt.Sprintf(testAccAWSCloudFrontDistributionS3ConfigWithTags, acctest.RandInt(), originBucket, logBucket, testAccAWSCloudFrontDistributionRetainConfig()))

aws/data_source_aws_ecs_cluster_test.go
severity:warning rule:helper-acctest-RandInt-compiled: Using `acctest.RandInt()` in constant or variable declaration will execute during compilation and not randomize, pass into string generating function instead
50:var testAccCheckAwsEcsClusterDataSourceConfig = fmt.Sprintf(`
51:resource "aws_ecs_cluster" "default" {
52:  name = "default-%d"
53:}
54:
55:data "aws_ecs_cluster" "default" {
56:  cluster_name = aws_ecs_cluster.default.name
57:}
58:`, acctest.RandInt())
--------------------------------------------------------------------------------
60:var testAccCheckAwsEcsClusterDataSourceConfigContainerInsights = fmt.Sprintf(`
61:resource "aws_ecs_cluster" "default" {
62:  name = "default-%d"
63:
64:  setting {
65:    name  = "containerInsights"
66:    value = "enabled"
67:  }
68:}
69:
-------- [hid 4 additional lines, adjust with --max-lines-per-finding] ---------

aws/data_source_aws_ecs_service_test.go
severity:warning rule:helper-acctest-RandInt-compiled: Using `acctest.RandInt()` in constant or variable declaration will execute during compilation and not randomize, pass into string generating function instead
34:var testAccCheckAwsEcsServiceDataSourceConfig = fmt.Sprintf(`
35:resource "aws_ecs_cluster" "test" {
36:  name = "tf-acc-%d"
37:}
38:
39:resource "aws_ecs_task_definition" "test" {
40:  family = "mongodb"
41:
42:  container_definitions = <<DEFINITION
43:[
-------- [hid 24 additional lines, adjust with --max-lines-per-finding] --------

aws/resource_aws_cloudfront_distribution_test.go
severity:warning rule:helper-acctest-RandInt-compiled: Using `acctest.RandInt()` in constant or variable declaration will execute during compilation and not randomize, pass into string generating function instead
1439:var testAccAWSCloudFrontDistributionCustomConfig = fmt.Sprintf(`
1440:variable rand_id {
1441:  default = %d
1442:}
1443:
1444:# log bucket
1445:%s
1446:
1447:resource "aws_cloudfront_distribution" "custom_distribution" {
1448:  origin {
-------- [hid 59 additional lines, adjust with --max-lines-per-finding] --------
1509:var testAccAWSCloudFrontDistributionOriginRequestPolicyConfigDefault = fmt.Sprintf(`
1510:variable rand_id {
1511:  default = %[1]d
1512:}
1513:
1514:# log bucket
1515:%[2]s
1516:
1517:resource "aws_cloudfront_cache_policy" "example" {
1518:  name        = "test-policy%[1]d"
------- [hid 100 additional lines, adjust with --max-lines-per-finding] --------
1620:var testAccAWSCloudFrontDistributionOriginRequestPolicyConfigOrdered = fmt.Sprintf(`
1621:variable rand_id {
1622:  default = %[1]d
1623:}
1624:
1625:# log bucket
1626:%[2]s
1627:
1628:resource "aws_cloudfront_cache_policy" "example" {
1629:  name        = "test-policy%[1]d"
------- [hid 113 additional lines, adjust with --max-lines-per-finding] --------
1744:var testAccAWSCloudFrontDistributionMultiOriginConfig = fmt.Sprintf(`
1745:variable rand_id {
1746:  default = %d
1747:}
1748:
1749:# origin bucket
1750:%s
1751:
1752:# log bucket
1753:%s
------- [hid 112 additional lines, adjust with --max-lines-per-finding] --------
1867:var testAccAWSCloudFrontDistributionNoCustomErroResponseInfo = fmt.Sprintf(`
1868:variable rand_id {
1869:  default = %d
1870:}
1871:
1872:resource "aws_cloudfront_distribution" "no_custom_error_responses" {
1873:  origin {
1874:    domain_name = "www.example.com"
1875:    origin_id   = "myCustomOrigin"
1876:
-------- [hid 50 additional lines, adjust with --max-lines-per-finding] --------
1928:var testAccAWSCloudFrontDistributionNoOptionalItemsConfig = fmt.Sprintf(`
1929:variable rand_id {
1930:  default = %d
1931:}
1932:
1933:resource "aws_cloudfront_distribution" "no_optional_items" {
1934:  origin {
1935:    domain_name = "www.example.com"
1936:    origin_id   = "myCustomOrigin"
1937:
-------- [hid 41 additional lines, adjust with --max-lines-per-finding] --------
2076:var testAccAWSCloudFrontDistributionHTTP11Config = fmt.Sprintf(`
2077:variable rand_id {
2078:  default = %d
2079:}
2080:
2081:resource "aws_cloudfront_distribution" "http_1_1" {
2082:  origin {
2083:    domain_name = "www.example.com"
2084:    origin_id   = "myCustomOrigin"
2085:
-------- [hid 47 additional lines, adjust with --max-lines-per-finding] --------
2134:var testAccAWSCloudFrontDistributionIsIPV6EnabledConfig = fmt.Sprintf(`
2135:variable rand_id {
2136:  default = %d
2137:}
2138:
2139:resource "aws_cloudfront_distribution" "is_ipv6_enabled" {
2140:  origin {
2141:    domain_name = "www.example.com"
2142:    origin_id   = "myCustomOrigin"
2143:
-------- [hid 48 additional lines, adjust with --max-lines-per-finding] --------
2193:var testAccAWSCloudFrontDistributionOrderedCacheBehavior = fmt.Sprintf(`
2194:variable rand_id {
2195:  default = %d
2196:}
2197:
2198:resource "aws_cloudfront_distribution" "main" {
2199:  origin {
2200:    domain_name = "www.hashicorp.com"
2201:    origin_id   = "myCustomOrigin"
2202:
-------- [hid 86 additional lines, adjust with --max-lines-per-finding] --------
2290:var testAccAWSCloudFrontDistributionOrderedCacheBehaviorCachePolicy = fmt.Sprintf(`
2291:variable rand_id {
2292:  default = %d
2293:}
2294:
2295:resource "aws_cloudfront_distribution" "main" {
2296:  origin {
2297:    domain_name = "www.hashicorp.com"
2298:    origin_id   = "myCustomOrigin"
2299:
-------- [hid 73 additional lines, adjust with --max-lines-per-finding] --------

aws/resource_aws_elasticache_cluster_test.go
severity:warning rule:helper-acctest-RandInt-compiled: Using `acctest.RandInt()` in constant or variable declaration will execute during compilation and not randomize, pass into string generating function instead
1025:var testAccAWSElasticacheClusterInVPCConfig = fmt.Sprintf(`
1026:data "aws_availability_zones" "available" {
1027:  state = "available"
1028:
1029:  filter {
1030:    name   = "opt-in-status"
1031:    values = ["opt-in-not-required"]
1032:  }
1033:}
1034:
-------- [hid 58 additional lines, adjust with --max-lines-per-finding] --------
1094:var testAccAWSElasticacheClusterMultiAZInVPCConfig = fmt.Sprintf(`
1095:data "aws_availability_zones" "available" {
1096:  state = "available"
1097:
1098:  filter {
1099:    name   = "opt-in-status"
1100:    values = ["opt-in-not-required"]
1101:  }
1102:}
1103:
-------- [hid 65 additional lines, adjust with --max-lines-per-finding] --------

aws/resource_aws_elasticache_replication_group_test.go
severity:warning rule:helper-acctest-RandInt-compiled: Using `acctest.RandInt()` in constant or variable declaration will execute during compilation and not randomize, pass into string generating function instead
1661:var testAccAWSElasticacheReplicationGroupInVPCConfig = fmt.Sprintf(`
1662:data "aws_availability_zones" "available" {
1663:  state = "available"
1664:
1665:  filter {
1666:    name   = "opt-in-status"
1667:    values = ["opt-in-not-required"]
1668:  }
1669:}
1670:
-------- [hid 49 additional lines, adjust with --max-lines-per-finding] --------
ran 12 rules on 2158 files: 17 findings

Output from acceptance testing:

--- PASS: TestAccAWSCloudFrontDistribution_customOrigin (377.36s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (202.77s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Headers (191.20s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn (247.51s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners (199.05s)
--- PASS: TestAccAWSCloudFrontDistribution_disappears (176.21s)
--- PASS: TestAccAWSCloudFrontDistribution_Enabled (541.17s)
--- PASS: TestAccAWSCloudFrontDistribution_HTTP11Config (399.22s)
--- PASS: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (399.21s)
--- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (355.41s)
--- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (399.84s)
--- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (388.59s)
--- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehavior (373.92s)
--- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (236.34s)
--- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Headers (192.33s)
--- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn (246.39s)
--- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehaviorCachePolicy (371.56s)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (5.01s)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (0.92s)
--- PASS: TestAccAWSCloudFrontDistribution_OriginGroups (338.79s)
--- PASS: TestAccAWSCloudFrontDistribution_originPolicyDefault (400.05s)
--- PASS: TestAccAWSCloudFrontDistribution_originPolicyOrdered (342.41s)
--- PASS: TestAccAWSCloudFrontDistribution_RetainOnDelete (401.36s)
--- PASS: TestAccAWSCloudFrontDistribution_S3Origin (313.50s)
--- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (459.80s)
--- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn (152.71s)
--- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate (162.56s)
--- PASS: TestAccAWSCloudFrontDistribution_WaitForDeployment (315.88s)

--- PASS: TestAccAWSDataSourceCloudFrontDistribution_basic (400.44s)

--- PASS: TestAccAWSEcsDataSource_ecsCluster (27.24s)
--- PASS: TestAccAWSEcsDataSource_ecsClusterContainerInsights (24.25s)

--- PASS: TestAccAWSEcsServiceDataSource_basic (84.98s)

--- PASS: TestAccAWSElasticacheCluster_multiAZInVpc (747.82s)
--- PASS: TestAccAWSElasticacheCluster_vpc (614.42s)

--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (805.50s)

[YakDriver]

Looks great! 🎉

GovCloud:

--- PASS: TestAccAWSEcsDataSource_ecsCluster (32.98s)
--- PASS: TestAccAWSEcsDataSource_ecsClusterContainerInsights (32.11s)
--- PASS: TestAccAWSEcsServiceDataSource_basic (82.51s)
--- PASS: TestAccAWSElasticacheCluster_AZMode_Memcached (646.03s)
--- PASS: TestAccAWSElasticacheCluster_AZMode_Redis (605.71s)
--- PASS: TestAccAWSElasticacheCluster_Engine_Memcached (689.80s)
--- PASS: TestAccAWSElasticacheCluster_Engine_Redis (703.75s)
--- PASS: TestAccAWSElasticacheCluster_EngineVersion_Redis (1342.12s)
--- PASS: TestAccAWSElasticacheCluster_Memcached_FinalSnapshot (4.95s)
--- PASS: TestAccAWSElasticacheCluster_multiAZInVpc (665.25s)
--- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Memcached (1252.97s)
--- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Redis (1386.83s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Decrease (931.65s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Increase (1148.11s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_IncreaseWithPreferredAvailabilityZones (986.76s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Redis (5.53s)
--- PASS: TestAccAWSElasticacheCluster_ParameterGroupName_Default (621.38s)
--- PASS: TestAccAWSElasticacheCluster_Port (643.23s)
--- PASS: TestAccAWSElasticacheCluster_Port_Redis_Default (473.61s)
--- PASS: TestAccAWSElasticacheCluster_Redis_FinalSnapshot (833.65s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone (1391.21s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_MultipleReplica (1453.72s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_SingleReplica (1452.46s)
--- PASS: TestAccAWSElasticacheCluster_snapshotsWithUpdates (683.19s)
--- PASS: TestAccAWSElasticacheCluster_vpc (686.46s)
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (736.73s)
--- SKIP: TestAccAWSCloudFrontDistribution_customOrigin (0.00s)
--- SKIP: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (1.20s)
--- SKIP: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Headers (1.20s)
--- SKIP: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn (1.20s)
--- SKIP: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners (1.20s)
--- SKIP: TestAccAWSCloudFrontDistribution_disappears (0.00s)
--- SKIP: TestAccAWSCloudFrontDistribution_Enabled (0.00s)
--- SKIP: TestAccAWSCloudFrontDistribution_HTTP11Config (1.20s)
--- SKIP: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (1.20s)
--- SKIP: TestAccAWSCloudFrontDistribution_multiOrigin (1.20s)
--- SKIP: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (1.20s)
--- SKIP: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (1.20s)
--- SKIP: TestAccAWSCloudFrontDistribution_orderedCacheBehavior (1.20s)
--- SKIP: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (0.00s)
--- SKIP: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Headers (1.20s)
--- SKIP: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn (0.00s)
--- SKIP: TestAccAWSCloudFrontDistribution_orderedCacheBehaviorCachePolicy (1.20s)
--- SKIP: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (1.20s)
--- SKIP: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (1.20s)
--- SKIP: TestAccAWSCloudFrontDistribution_OriginGroups (0.00s)
--- SKIP: TestAccAWSCloudFrontDistribution_originPolicyDefault (1.20s)
--- SKIP: TestAccAWSCloudFrontDistribution_originPolicyOrdered (1.20s)
--- SKIP: TestAccAWSCloudFrontDistribution_RetainOnDelete (0.00s)
--- SKIP: TestAccAWSCloudFrontDistribution_S3Origin (0.00s)
--- SKIP: TestAccAWSCloudFrontDistribution_S3OriginWithTags (0.00s)
--- SKIP: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn (1.42s)
--- SKIP: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate (1.52s)
--- SKIP: TestAccAWSCloudFrontDistribution_WaitForDeployment (0.00s)
--- SKIP: TestAccAWSDataSourceCloudFrontDistribution_basic (1.20s)
--- SKIP: TestAccAWSElasticacheCluster_SecurityGroup_Ec2Classic (1.08s)

us-west-2:

--- PASS: TestAccAWSCloudFrontDistribution_customOrigin (306.88s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (165.77s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Headers (166.80s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn (205.37s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners (157.76s)
--- PASS: TestAccAWSCloudFrontDistribution_disappears (144.60s)
--- PASS: TestAccAWSCloudFrontDistribution_Enabled (458.46s)
--- PASS: TestAccAWSCloudFrontDistribution_HTTP11Config (283.73s)
--- PASS: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (294.01s)
--- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (317.83s)
--- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (293.94s)
--- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (314.34s)
--- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehavior (314.61s)
--- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (146.53s)
--- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Headers (177.22s)
--- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn (193.68s)
--- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehaviorCachePolicy (294.83s)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (0.92s)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (0.95s)
--- PASS: TestAccAWSCloudFrontDistribution_OriginGroups (331.90s)
--- PASS: TestAccAWSCloudFrontDistribution_originPolicyDefault (316.45s)
--- PASS: TestAccAWSCloudFrontDistribution_originPolicyOrdered (296.92s)
--- PASS: TestAccAWSCloudFrontDistribution_RetainOnDelete (307.28s)
--- PASS: TestAccAWSCloudFrontDistribution_S3Origin (277.83s)
--- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (499.71s)
--- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn (158.05s)
--- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate (153.84s)
--- PASS: TestAccAWSCloudFrontDistribution_WaitForDeployment (338.66s)
--- PASS: TestAccAWSDataSourceCloudFrontDistribution_basic (331.58s)
--- PASS: TestAccAWSEcsDataSource_ecsCluster (21.37s)
--- PASS: TestAccAWSEcsDataSource_ecsClusterContainerInsights (22.03s)
--- PASS: TestAccAWSEcsServiceDataSource_basic (61.93s)
--- PASS: TestAccAWSElasticacheCluster_Engine_Memcached (695.71s)
--- PASS: TestAccAWSElasticacheCluster_Engine_Redis (638.65s)
--- PASS: TestAccAWSElasticacheCluster_Memcached_FinalSnapshot (1.43s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Decrease (983.26s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Increase (1093.65s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_IncreaseWithPreferredAvailabilityZones (1277.14s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Redis (4.89s)
--- PASS: TestAccAWSElasticacheCluster_ParameterGroupName_Default (633.75s)
--- PASS: TestAccAWSElasticacheCluster_Port (696.56s)
--- PASS: TestAccAWSElasticacheCluster_Port_Redis_Default (457.53s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_MultipleReplica (1333.56s)
--- PASS: TestAccAWSElasticacheCluster_snapshotsWithUpdates (670.47s)
--- PASS: TestAccAWSElasticacheCluster_vpc (634.75s)
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (815.72s)
--- SKIP: TestAccAWSElasticacheCluster_SecurityGroup_Ec2Classic (1.43s)
--- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Redis (1410.76s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone (1414.84s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_SingleReplica (1435.50s)

[ghost]

This has been released in version 3.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!