Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets Manager Secret Replication #18280

Closed
wants to merge 2 commits into from
Closed

Conversation

TomTucka
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17943

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 19, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 19, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @TomTucka 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@generalov
Copy link

Just a naming thing: aws_dynamodb_table has a similar replica option:

replica {
    region_name = "us-east-2"
}

@shubydo
Copy link
Contributor

shubydo commented Apr 26, 2021

Hi @TomTucka, I'm working on a team that is looking forward to utilizing this feature and was wondering if there have been any updates on this?

Quick question on this feature: If our team wanted to replicate a secret in another region (ex. us-east-2), but then needed to run a terraform destroy, would this teardown both the secret created in the primary region and the replicated regions(s)?

@kgosietsileM
Copy link

+1

@YakDriver
Copy link
Member

@TomTucka Is this something that you are interested in continuing?

@TomTucka
Copy link
Contributor Author

@YakDriver I'm super busy with work right now and won't get round to this for a few more weeks. Happy for someone else to take what I've done and finish it off 😄

@YakDriver YakDriver self-assigned this Jul 23, 2021
@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Jul 23, 2021
@YakDriver
Copy link
Member

@TomTucka Thanks for your work on this!

I moved your commits over to another branch. You still get credit for them. Because your branch was named "main," it was easier to just cherry pick them to a new branch.

@github-actions github-actions bot added this to the v3.52.0 milestone Jul 24, 2021
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/secretsmanager Issues and PRs that pertain to the secretsmanager service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secrets Manager: Support Secret Replication
5 participants