-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secrets Manager Secret Replication #18280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @TomTucka 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Just a naming thing: aws_dynamodb_table has a similar replica {
region_name = "us-east-2"
} |
Hi @TomTucka, I'm working on a team that is looking forward to utilizing this feature and was wondering if there have been any updates on this? Quick question on this feature: If our team wanted to replicate a secret in another region (ex. |
+1 |
@TomTucka Is this something that you are interested in continuing? |
@YakDriver I'm super busy with work right now and won't get round to this for a few more weeks. Happy for someone else to take what I've done and finish it off 😄 |
@TomTucka Thanks for your work on this! I moved your commits over to another branch. You still get credit for them. Because your branch was named "main," it was easier to just cherry pick them to a new branch. |
This functionality has been released in v3.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #17943
Output from acceptance testing: