Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/resource/aws_iam_server_certificate: Add missing ErrorCheck #18413

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 25, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Previously:

aws/resource_aws_iam_server_certificate_test.go:154:36: XAT001: missing ErrorCheck
153
154		resource.ParallelTest(t, resource.TestCase{
155			PreCheck:     func() { testAccPreCheck(t) },

Output from acceptance testing:

--- PASS: TestAccAWSIAMServerCertificate_name_prefix (15.33s)

Previously:

```
aws/resource_aws_iam_server_certificate_test.go:154:36: XAT001: missing ErrorCheck
153
154		resource.ParallelTest(t, resource.TestCase{
155			PreCheck:     func() { testAccPreCheck(t) },
```

Output from acceptance testing:

```
--- PASS: TestAccAWSIAMServerCertificate_name_prefix (15.33s)
```
@bflad bflad requested a review from a team as a code owner March 25, 2021 18:22
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 25, 2021
@YakDriver YakDriver self-assigned this Mar 25, 2021
@bflad bflad merged commit 914c9a1 into main Mar 25, 2021
@bflad bflad deleted the t-aws_iam_server_certificate-ErrorCheck branch March 25, 2021 18:32
@github-actions github-actions bot added this to the v3.34.0 milestone Mar 25, 2021
github-actions bot pushed a commit that referenced this pull request Mar 25, 2021
@ghost
Copy link

ghost commented Mar 26, 2021

This has been released in version 3.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/iam Issues and PRs that pertain to the iam service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants