resource/aws_vpc_dhcp_options_association: Handle read-after-create eventual consistency

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16142
Reference: #16796

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_vpc (19.27s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_dhcp (25.61s)
--- PASS: TestAccAWSDHCPOptionsAssociation_basic (25.84s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_vpc (21.51s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_dhcp (27.55s)
--- PASS: TestAccAWSDHCPOptionsAssociation_basic (28.10s)

[YakDriver]

Looks great! 🎉

Acceptance tests on GovCloud:

--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_vpc (20.59s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears (23.82s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_dhcp (26.28s)
--- PASS: TestAccAWSDHCPOptionsAssociation_basic (26.60s)

Acceptance tests on commercial:

--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_vpc (16.52s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears (20.19s)
--- PASS: TestAccAWSDHCPOptionsAssociation_disappears_dhcp (21.90s)
--- PASS: TestAccAWSDHCPOptionsAssociation_basic (22.07s)

[bflad]

Followup adjustments look good to me 👍 I'll merge when CI thinks we're going the code right.

[YakDriver]

This PR also adjusts Delete and the CheckDestroy. Previously, on GovCloud, 7 of out 10X the TestAccAWSDHCPOptionsAssociation_disappears_dhcp test would fail with this error:

testing_new.go:63: Error running post-test destroy, there may be dangling resources: DHCP Options association is still associated to 1 VPCs.

The issue was that this line would only occasionally result in a DHCP Options ID making it to the Disappears -> Delete. Most of the time, the resource data would include dhcp_options_id = default. (Perhaps because GovCloud was so quick in deleting resources.)

testAccCheckResourceDisappears(testAccProvider, resourceAwsVpcDhcpOptions(), "aws_vpc_dhcp_options.test"),

Since aws_vpc_dhcp_options_association's Delete just associates the VPC with the default DHCP Options ID ("default"), delete wouldn't really do anything in that particular case.

In the CheckDestroy (testAccCheckDHCPOptionsAssociationDestroy), if the resource state includes dhcp_options_id = default, the options association is already deleted. But, the findVPCsByDHCPOptionsID(conn, rs.Primary.Attributes["dhcp_options_id"]) was actually findVPCsByDHCPOptionsID(conn, "default"), which is what it should look like when aws_vpc_dhcp_options_association is deleted. But, the test would error because len(vpcs) was greater than 0, because a VPC was associated with default, like any VPC will be until it is associated with VPC DHCP options.

[ghost]

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!