Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource for Macie2 Classification Job #19165

Merged
merged 29 commits into from
May 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
19a740f
feat: added resource for macie2 with classification job
Apr 17, 2021
825e421
test: added acceptance tests for macie2 classification job
Apr 17, 2021
3491c28
docs: added doc for macie2 classification job
Apr 17, 2021
60c0a31
docs: updated example
Apr 20, 2021
ff579f9
refactor: refactorized to follow the guidelines
Apr 27, 2021
a693578
delete clien token in docs
Apr 27, 2021
7ca97e3
test: delete hardcoded
Apr 27, 2021
14bfc69
refactor: refactorized to follow the guidelines
Apr 27, 2021
567f483
refactor: refactorized to follow the guidelines
Apr 27, 2021
c641890
changed macie2 to macie in comments
Apr 28, 2021
c10053b
refactor: refactorized to follow the guidelines
Apr 28, 2021
577a769
change to wrong link in doc api
Apr 29, 2021
c6b0edd
reformat: delete aws.StringValue or aws.BoolValue for d.Set because i…
Apr 30, 2021
25493f8
fixes terraform format
Apr 30, 2021
e734fa8
feat: added tags functions for macie2
May 4, 2021
4c120ba
changed to assignment values and delete some ephemeral values
May 4, 2021
f6fed1d
test: added other funcs
May 4, 2021
5762971
deleted ephemeral values
May 4, 2021
25d82ec
added changelog file
May 4, 2021
ca9055f
fix: updated validation with possibly values when cancelled a job
May 4, 2021
eea43ac
test: added dissapear func
May 4, 2021
8f94c11
fixes go generate error linter
May 4, 2021
9f3200d
refactor: added validation length, changed typeset to typelist for us…
May 4, 2021
6046fe5
test: added more check values in complete func
May 4, 2021
7efeb4e
lowercase the tests functions because it will tested in serial function
May 5, 2021
60f1710
refactor to change validation and lowercase the functions so it can b…
May 5, 2021
244a3cb
test: added serial test for macie2 along with account and classificat…
May 5, 2021
04753e3
changed length prefix
May 5, 2021
6262302
test: added random with prefix for bucket name
May 5, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/19165.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:new-resource
aws_macie2_classification_job
```
1 change: 1 addition & 0 deletions aws/internal/keyvaluetags/generators/servicetags/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ var mapServiceNames = []string{
"kinesisvideo",
"imagebuilder",
"lambda",
"macie2",
"mediaconnect",
"mediaconvert",
"medialive",
Expand Down
10 changes: 10 additions & 0 deletions aws/internal/keyvaluetags/service_tags_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions aws/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -841,6 +841,7 @@ func Provider() *schema.Provider {
"aws_load_balancer_listener_policy": resourceAwsLoadBalancerListenerPolicies(),
"aws_lb_ssl_negotiation_policy": resourceAwsLBSSLNegotiationPolicy(),
"aws_macie2_account": resourceAwsMacie2Account(),
"aws_macie2_classification_job": resourceAwsMacie2ClassificationJob(),
"aws_macie_member_account_association": resourceAwsMacieMemberAccountAssociation(),
"aws_macie_s3_bucket_association": resourceAwsMacieS3BucketAssociation(),
"aws_main_route_table_association": resourceAwsMainRouteTableAssociation(),
Expand Down
10 changes: 5 additions & 5 deletions aws/resource_aws_macie2_account_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
)

func TestAccAwsMacie2Account_basic(t *testing.T) {
func testAccAwsMacie2Account_basic(t *testing.T) {
var macie2Output macie2.GetMacieSessionOutput
resourceName := "aws_macie2_account.test"

Expand Down Expand Up @@ -40,7 +40,7 @@ func TestAccAwsMacie2Account_basic(t *testing.T) {
})
}

func TestAccAwsMacie2Account_FindingPublishingFrequency(t *testing.T) {
func testAccAwsMacie2Account_FindingPublishingFrequency(t *testing.T) {
var macie2Output macie2.GetMacieSessionOutput
resourceName := "aws_macie2_account.test"

Expand Down Expand Up @@ -81,7 +81,7 @@ func TestAccAwsMacie2Account_FindingPublishingFrequency(t *testing.T) {
})
}

func TestAccAwsMacie2Account_WithStatus(t *testing.T) {
func testAccAwsMacie2Account_WithStatus(t *testing.T) {
var macie2Output macie2.GetMacieSessionOutput
resourceName := "aws_macie2_account.test"

Expand Down Expand Up @@ -122,7 +122,7 @@ func TestAccAwsMacie2Account_WithStatus(t *testing.T) {
})
}

func TestAccAwsMacie2Account_WithFindingAndStatus(t *testing.T) {
func testAccAwsMacie2Account_WithFindingAndStatus(t *testing.T) {
var macie2Output macie2.GetMacieSessionOutput
resourceName := "aws_macie2_account.test"

Expand Down Expand Up @@ -163,7 +163,7 @@ func TestAccAwsMacie2Account_WithFindingAndStatus(t *testing.T) {
})
}

func TestAccAwsMacie2Account_disappears(t *testing.T) {
func testAccAwsMacie2Account_disappears(t *testing.T) {
var macie2Output macie2.GetMacieSessionOutput
resourceName := "aws_macie2_account.test"

Expand Down
Loading