Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/glue_crawler - s3 sample size #20203

Merged
merged 8 commits into from
Jul 19, 2021
Merged

r/glue_crawler - s3 sample size #20203

merged 8 commits into from
Jul 19, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jul 15, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20177
Closes #18174

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueCrawler_'
--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (56.98s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (59.48s)
--- PASS: TestAccAWSGlueCrawler_disappears (65.08s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (80.63s)
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (131.69s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (148.54s)
--- PASS: TestAccAWSGlueCrawler_mongoDBTarget (148.54s)
--- PASS: TestAccAWSGlueCrawler_Description (149.07s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (150.05s)
--- PASS: TestAccAWSGlueCrawler_Configuration (150.29s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (153.17s)
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (158.23s)
--- PASS: TestAccAWSGlueCrawler_Schedule (197.96s)
--- PASS: TestAccAWSGlueCrawler_RemoveTablePrefix (146.95s)
--- PASS: TestAccAWSGlueCrawler_Classifiers (206.54s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (207.00s)
--- PASS: TestAccAWSGlueCrawler_recrawlPolicy (208.01s)
--- PASS: TestAccAWSGlueCrawler_Tags (210.34s)
--- PASS: TestAccAWSGlueCrawler_mongoDBTarget_multiple (211.36s)
--- PASS: TestAccAWSGlueCrawler_mongoDBTarget_scan_all (211.42s)
--- PASS: TestAccAWSGlueCrawler_lineageConfig (211.67s)
--- PASS: TestAccAWSGlueCrawler_TablePrefix (149.02s)
--- PASS: TestAccAWSGlueCrawler_S3Target_ConnectionName (90.00s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanRate (184.81s)
--- PASS: TestAccAWSGlueCrawler_S3Target (125.84s)
--- PASS: TestAccAWSGlueCrawler_S3Target_SampleSize (128.82s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (135.05s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget (157.83s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (178.16s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget_Multiple (256.74s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanAll (171.32s)

@github-actions github-actions bot added service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Jul 15, 2021
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jul 15, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 15, 2021
@DrFaust92 @ewbankkit
Update website/docs/r/glue_crawler.html.markdown
45ac529 
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
ewbankkit
ewbankkit approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSGlueCrawler_'                     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCrawler_ -timeout 180m
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget
=== PAUSE TestAccAWSGlueCrawler_DynamodbTarget
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget_scanAll
=== PAUSE TestAccAWSGlueCrawler_DynamodbTarget_scanAll
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget_scanRate
=== PAUSE TestAccAWSGlueCrawler_DynamodbTarget_scanRate
=== RUN   TestAccAWSGlueCrawler_JdbcTarget
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Multiple
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget_Multiple
=== RUN   TestAccAWSGlueCrawler_mongoDBTarget
=== PAUSE TestAccAWSGlueCrawler_mongoDBTarget
=== RUN   TestAccAWSGlueCrawler_mongoDBTarget_scan_all
=== PAUSE TestAccAWSGlueCrawler_mongoDBTarget_scan_all
=== RUN   TestAccAWSGlueCrawler_mongoDBTarget_multiple
=== PAUSE TestAccAWSGlueCrawler_mongoDBTarget_multiple
=== RUN   TestAccAWSGlueCrawler_S3Target
=== PAUSE TestAccAWSGlueCrawler_S3Target
=== RUN   TestAccAWSGlueCrawler_S3Target_ConnectionName
=== PAUSE TestAccAWSGlueCrawler_S3Target_ConnectionName
=== RUN   TestAccAWSGlueCrawler_S3Target_SampleSize
=== PAUSE TestAccAWSGlueCrawler_S3Target_SampleSize
=== RUN   TestAccAWSGlueCrawler_S3Target_Exclusions
=== PAUSE TestAccAWSGlueCrawler_S3Target_Exclusions
=== RUN   TestAccAWSGlueCrawler_S3Target_Multiple
=== PAUSE TestAccAWSGlueCrawler_S3Target_Multiple
=== RUN   TestAccAWSGlueCrawler_CatalogTarget
=== PAUSE TestAccAWSGlueCrawler_CatalogTarget
=== RUN   TestAccAWSGlueCrawler_CatalogTarget_Multiple
=== PAUSE TestAccAWSGlueCrawler_CatalogTarget_Multiple
=== RUN   TestAccAWSGlueCrawler_disappears
=== PAUSE TestAccAWSGlueCrawler_disappears
=== RUN   TestAccAWSGlueCrawler_Classifiers
=== PAUSE TestAccAWSGlueCrawler_Classifiers
=== RUN   TestAccAWSGlueCrawler_Configuration
=== PAUSE TestAccAWSGlueCrawler_Configuration
=== RUN   TestAccAWSGlueCrawler_Description
=== PAUSE TestAccAWSGlueCrawler_Description
=== RUN   TestAccAWSGlueCrawler_Role_ARN_NoPath
=== PAUSE TestAccAWSGlueCrawler_Role_ARN_NoPath
=== RUN   TestAccAWSGlueCrawler_Role_ARN_Path
=== PAUSE TestAccAWSGlueCrawler_Role_ARN_Path
=== RUN   TestAccAWSGlueCrawler_Role_Name_Path
=== PAUSE TestAccAWSGlueCrawler_Role_Name_Path
=== RUN   TestAccAWSGlueCrawler_Schedule
=== PAUSE TestAccAWSGlueCrawler_Schedule
=== RUN   TestAccAWSGlueCrawler_SchemaChangePolicy
=== PAUSE TestAccAWSGlueCrawler_SchemaChangePolicy
=== RUN   TestAccAWSGlueCrawler_TablePrefix
=== PAUSE TestAccAWSGlueCrawler_TablePrefix
=== RUN   TestAccAWSGlueCrawler_RemoveTablePrefix
=== PAUSE TestAccAWSGlueCrawler_RemoveTablePrefix
=== RUN   TestAccAWSGlueCrawler_Tags
=== PAUSE TestAccAWSGlueCrawler_Tags
=== RUN   TestAccAWSGlueCrawler_SecurityConfiguration
=== PAUSE TestAccAWSGlueCrawler_SecurityConfiguration
=== RUN   TestAccAWSGlueCrawler_lineageConfig
=== PAUSE TestAccAWSGlueCrawler_lineageConfig
=== RUN   TestAccAWSGlueCrawler_recrawlPolicy
=== PAUSE TestAccAWSGlueCrawler_recrawlPolicy
=== CONT  TestAccAWSGlueCrawler_DynamodbTarget
=== CONT  TestAccAWSGlueCrawler_disappears
=== CONT  TestAccAWSGlueCrawler_Schedule
=== CONT  TestAccAWSGlueCrawler_recrawlPolicy
=== CONT  TestAccAWSGlueCrawler_Classifiers
=== CONT  TestAccAWSGlueCrawler_SchemaChangePolicy
=== CONT  TestAccAWSGlueCrawler_SecurityConfiguration
=== CONT  TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== CONT  TestAccAWSGlueCrawler_Role_Name_Path
=== CONT  TestAccAWSGlueCrawler_Role_ARN_Path
=== CONT  TestAccAWSGlueCrawler_Role_ARN_NoPath
=== CONT  TestAccAWSGlueCrawler_Description
=== CONT  TestAccAWSGlueCrawler_Configuration
=== CONT  TestAccAWSGlueCrawler_RemoveTablePrefix
=== CONT  TestAccAWSGlueCrawler_mongoDBTarget_multiple
=== CONT  TestAccAWSGlueCrawler_Tags
=== CONT  TestAccAWSGlueCrawler_CatalogTarget_Multiple
=== CONT  TestAccAWSGlueCrawler_lineageConfig
=== CONT  TestAccAWSGlueCrawler_CatalogTarget
=== CONT  TestAccAWSGlueCrawler_TablePrefix
--- PASS: TestAccAWSGlueCrawler_disappears (61.19s)
=== CONT  TestAccAWSGlueCrawler_S3Target_Multiple
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (62.56s)
=== CONT  TestAccAWSGlueCrawler_S3Target_ConnectionName
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (64.93s)
=== CONT  TestAccAWSGlueCrawler_S3Target_SampleSize
--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (65.13s)
=== CONT  TestAccAWSGlueCrawler_S3Target_Exclusions
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (111.08s)
=== CONT  TestAccAWSGlueCrawler_mongoDBTarget
--- PASS: TestAccAWSGlueCrawler_Description (122.12s)
=== CONT  TestAccAWSGlueCrawler_mongoDBTarget_scan_all
=== CONT  TestAccAWSGlueCrawler_DynamodbTarget_scanRate
--- PASS: TestAccAWSGlueCrawler_RemoveTablePrefix (122.15s)
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (122.78s)
=== CONT  TestAccAWSGlueCrawler_JdbcTarget
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (130.74s)
=== CONT  TestAccAWSGlueCrawler_S3Target
--- PASS: TestAccAWSGlueCrawler_Tags (140.61s)
=== CONT  TestAccAWSGlueCrawler_DynamodbTarget_scanAll
--- PASS: TestAccAWSGlueCrawler_Classifiers (153.25s)
=== CONT  TestAccAWSGlueCrawler_JdbcTarget_Multiple
--- PASS: TestAccAWSGlueCrawler_mongoDBTarget_multiple (162.44s)
--- PASS: TestAccAWSGlueCrawler_Configuration (175.26s)
--- PASS: TestAccAWSGlueCrawler_lineageConfig (186.62s)
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (191.95s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget_Multiple (202.23s)
--- PASS: TestAccAWSGlueCrawler_recrawlPolicy (202.78s)
--- PASS: TestAccAWSGlueCrawler_Schedule (206.75s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (93.06s)
--- PASS: TestAccAWSGlueCrawler_mongoDBTarget (114.31s)
--- PASS: TestAccAWSGlueCrawler_S3Target (107.63s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanRate (132.14s)
--- PASS: TestAccAWSGlueCrawler_S3Target_ConnectionName (193.79s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanAll (126.23s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget (275.30s)
--- PASS: TestAccAWSGlueCrawler_TablePrefix (292.59s)
--- PASS: TestAccAWSGlueCrawler_S3Target_SampleSize (304.62s)
--- PASS: TestAccAWSGlueCrawler_mongoDBTarget_scan_all (253.08s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (341.83s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (349.38s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (525.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	682.527s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSGlueCrawler_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCrawler_ -timeout 180m
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget
=== PAUSE TestAccAWSGlueCrawler_DynamodbTarget
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget_scanAll
=== PAUSE TestAccAWSGlueCrawler_DynamodbTarget_scanAll
=== RUN   TestAccAWSGlueCrawler_DynamodbTarget_scanRate
=== PAUSE TestAccAWSGlueCrawler_DynamodbTarget_scanRate
=== RUN   TestAccAWSGlueCrawler_JdbcTarget
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== RUN   TestAccAWSGlueCrawler_JdbcTarget_Multiple
=== PAUSE TestAccAWSGlueCrawler_JdbcTarget_Multiple
=== RUN   TestAccAWSGlueCrawler_mongoDBTarget
=== PAUSE TestAccAWSGlueCrawler_mongoDBTarget
=== RUN   TestAccAWSGlueCrawler_mongoDBTarget_scan_all
=== PAUSE TestAccAWSGlueCrawler_mongoDBTarget_scan_all
=== RUN   TestAccAWSGlueCrawler_mongoDBTarget_multiple
=== PAUSE TestAccAWSGlueCrawler_mongoDBTarget_multiple
=== RUN   TestAccAWSGlueCrawler_S3Target
=== PAUSE TestAccAWSGlueCrawler_S3Target
=== RUN   TestAccAWSGlueCrawler_S3Target_ConnectionName
=== PAUSE TestAccAWSGlueCrawler_S3Target_ConnectionName
=== RUN   TestAccAWSGlueCrawler_S3Target_SampleSize
=== PAUSE TestAccAWSGlueCrawler_S3Target_SampleSize
=== RUN   TestAccAWSGlueCrawler_S3Target_Exclusions
=== PAUSE TestAccAWSGlueCrawler_S3Target_Exclusions
=== RUN   TestAccAWSGlueCrawler_S3Target_Multiple
=== PAUSE TestAccAWSGlueCrawler_S3Target_Multiple
=== RUN   TestAccAWSGlueCrawler_CatalogTarget
=== PAUSE TestAccAWSGlueCrawler_CatalogTarget
=== RUN   TestAccAWSGlueCrawler_CatalogTarget_Multiple
=== PAUSE TestAccAWSGlueCrawler_CatalogTarget_Multiple
=== RUN   TestAccAWSGlueCrawler_disappears
=== PAUSE TestAccAWSGlueCrawler_disappears
=== RUN   TestAccAWSGlueCrawler_Classifiers
=== PAUSE TestAccAWSGlueCrawler_Classifiers
=== RUN   TestAccAWSGlueCrawler_Configuration
=== PAUSE TestAccAWSGlueCrawler_Configuration
=== RUN   TestAccAWSGlueCrawler_Description
=== PAUSE TestAccAWSGlueCrawler_Description
=== RUN   TestAccAWSGlueCrawler_Role_ARN_NoPath
=== PAUSE TestAccAWSGlueCrawler_Role_ARN_NoPath
=== RUN   TestAccAWSGlueCrawler_Role_ARN_Path
=== PAUSE TestAccAWSGlueCrawler_Role_ARN_Path
=== RUN   TestAccAWSGlueCrawler_Role_Name_Path
=== PAUSE TestAccAWSGlueCrawler_Role_Name_Path
=== RUN   TestAccAWSGlueCrawler_Schedule
=== PAUSE TestAccAWSGlueCrawler_Schedule
=== RUN   TestAccAWSGlueCrawler_SchemaChangePolicy
=== PAUSE TestAccAWSGlueCrawler_SchemaChangePolicy
=== RUN   TestAccAWSGlueCrawler_TablePrefix
=== PAUSE TestAccAWSGlueCrawler_TablePrefix
=== RUN   TestAccAWSGlueCrawler_RemoveTablePrefix
=== PAUSE TestAccAWSGlueCrawler_RemoveTablePrefix
=== RUN   TestAccAWSGlueCrawler_Tags
=== PAUSE TestAccAWSGlueCrawler_Tags
=== RUN   TestAccAWSGlueCrawler_SecurityConfiguration
=== PAUSE TestAccAWSGlueCrawler_SecurityConfiguration
=== RUN   TestAccAWSGlueCrawler_lineageConfig
=== PAUSE TestAccAWSGlueCrawler_lineageConfig
=== RUN   TestAccAWSGlueCrawler_recrawlPolicy
=== PAUSE TestAccAWSGlueCrawler_recrawlPolicy
=== CONT  TestAccAWSGlueCrawler_DynamodbTarget
=== CONT  TestAccAWSGlueCrawler_disappears
=== CONT  TestAccAWSGlueCrawler_mongoDBTarget_multiple
=== CONT  TestAccAWSGlueCrawler_mongoDBTarget_scan_all
=== CONT  TestAccAWSGlueCrawler_recrawlPolicy
=== CONT  TestAccAWSGlueCrawler_lineageConfig
=== CONT  TestAccAWSGlueCrawler_SecurityConfiguration
=== CONT  TestAccAWSGlueCrawler_Tags
=== CONT  TestAccAWSGlueCrawler_RemoveTablePrefix
=== CONT  TestAccAWSGlueCrawler_TablePrefix
=== CONT  TestAccAWSGlueCrawler_SchemaChangePolicy
=== CONT  TestAccAWSGlueCrawler_Schedule
=== CONT  TestAccAWSGlueCrawler_Role_Name_Path
=== CONT  TestAccAWSGlueCrawler_Role_ARN_Path
=== CONT  TestAccAWSGlueCrawler_DynamodbTarget_scanRate
=== CONT  TestAccAWSGlueCrawler_Role_ARN_NoPath
=== CONT  TestAccAWSGlueCrawler_Description
=== CONT  TestAccAWSGlueCrawler_JdbcTarget
=== CONT  TestAccAWSGlueCrawler_JdbcTarget_Exclusions
=== CONT  TestAccAWSGlueCrawler_S3Target_Exclusions
--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (56.77s)
=== CONT  TestAccAWSGlueCrawler_Configuration
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (58.99s)
=== CONT  TestAccAWSGlueCrawler_Classifiers
--- PASS: TestAccAWSGlueCrawler_disappears (76.54s)
=== CONT  TestAccAWSGlueCrawler_CatalogTarget
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (79.74s)
=== CONT  TestAccAWSGlueCrawler_CatalogTarget_Multiple
--- PASS: TestAccAWSGlueCrawler_TablePrefix (122.44s)
=== CONT  TestAccAWSGlueCrawler_DynamodbTarget_scanAll
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (122.85s)
=== CONT  TestAccAWSGlueCrawler_S3Target_Multiple
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (123.12s)
=== CONT  TestAccAWSGlueCrawler_mongoDBTarget
--- PASS: TestAccAWSGlueCrawler_RemoveTablePrefix (127.88s)
=== CONT  TestAccAWSGlueCrawler_JdbcTarget_Multiple
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (129.71s)
=== CONT  TestAccAWSGlueCrawler_S3Target_ConnectionName
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (130.33s)
=== CONT  TestAccAWSGlueCrawler_S3Target_SampleSize
--- PASS: TestAccAWSGlueCrawler_Description (131.72s)
=== CONT  TestAccAWSGlueCrawler_S3Target
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (132.44s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (133.18s)
--- PASS: TestAccAWSGlueCrawler_mongoDBTarget_multiple (162.14s)
--- PASS: TestAccAWSGlueCrawler_recrawlPolicy (162.49s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanRate (162.95s)
--- PASS: TestAccAWSGlueCrawler_lineageConfig (164.18s)
--- PASS: TestAccAWSGlueCrawler_mongoDBTarget_scan_all (165.31s)
--- PASS: TestAccAWSGlueCrawler_Tags (165.76s)
--- PASS: TestAccAWSGlueCrawler_Schedule (165.86s)
--- PASS: TestAccAWSGlueCrawler_S3Target_ConnectionName (54.26s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget (111.41s)
--- PASS: TestAccAWSGlueCrawler_Configuration (133.40s)
--- PASS: TestAccAWSGlueCrawler_Classifiers (131.46s)
--- PASS: TestAccAWSGlueCrawler_mongoDBTarget (77.38s)
--- PASS: TestAccAWSGlueCrawler_S3Target (74.34s)
--- PASS: TestAccAWSGlueCrawler_S3Target_SampleSize (76.08s)
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget_scanAll (96.77s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (99.75s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget_Multiple (144.02s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (96.51s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	227.487s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 4c1a490 into hashicorp:main Jul 19, 2021
@github-actions github-actions bot added this to the v3.51.0 milestone Jul 19, 2021
@DrFaust92 DrFaust92 deleted the r/glue_crawler_s3_sample_size branch July 19, 2021 16:05
@github-actions
Copy link

This functionality has been released in v3.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.51.0
2 participants
@DrFaust92 @ewbankkit