Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/elasticache_user: wait for modifying/active state to avoid inconsistent result #20339

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jul 28, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20334

Output from acceptance testing:

--- PASS: TestAccAWSElasticacheUser_tags (100.89s)
--- PASS: TestAccAWSElasticacheUser_basic (110.82s)
--- PASS: TestAccAWSElasticacheUser_disappears (118.02s)
--- PASS: TestAccAWSElasticacheUser_update (285.83s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. labels Jul 28, 2021
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jul 28, 2021
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Jul 28, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSElasticacheUser_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticacheUser_ -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.40.7
=== RUN   TestAccAWSElasticacheUser_basic
=== PAUSE TestAccAWSElasticacheUser_basic
=== RUN   TestAccAWSElasticacheUser_update
=== PAUSE TestAccAWSElasticacheUser_update
=== RUN   TestAccAWSElasticacheUser_tags
=== PAUSE TestAccAWSElasticacheUser_tags
=== RUN   TestAccAWSElasticacheUser_disappears
=== PAUSE TestAccAWSElasticacheUser_disappears
=== CONT  TestAccAWSElasticacheUser_basic
=== CONT  TestAccAWSElasticacheUser_disappears
=== CONT  TestAccAWSElasticacheUser_tags
=== CONT  TestAccAWSElasticacheUser_update
--- PASS: TestAccAWSElasticacheUser_basic (69.36s)
--- PASS: TestAccAWSElasticacheUser_tags (70.95s)
--- PASS: TestAccAWSElasticacheUser_disappears (74.78s)
--- PASS: TestAccAWSElasticacheUser_update (213.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	219.689s

@anGie44 anGie44 added this to the v3.52.0 milestone Jul 28, 2021
@anGie44 anGie44 merged commit 2ac0bad into main Jul 28, 2021
@anGie44 anGie44 deleted the b-elasticache-user-update branch July 28, 2021 16:19
github-actions bot pushed a commit that referenced this pull request Jul 28, 2021
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"aws_elasticache_user" produces perpetual diff for "access_string" and fails during apply
2 participants