build(deps): bump github.com/golangci/golangci-lint from 1.39.0 to 1.41.1 in /tools

[dependabot]

Bumps github.com/golangci/golangci-lint from 1.39.0 to 1.41.1.

Release notes

Sourced from github.com/golangci/golangci-lint's releases.

v1.41.1

Changelog

6924df8f Bump github.com/ryancurrah/gomodguard from 1.2.1 to 1.2.2 (#2065) a2074809 revive: fix exclude comment rule for const block. (#2064)

v1.41.0

Changelog

52b55141 Bump github.com/jgautheron/goconst from 0.5.6 to 0.5.7(#2044) f900232b Update errorlint to HEAD (#1996) 1c2c8ffd Update godot to 1.4.7 (#2010) 5d84fa5e Update makezero to HEAD (#2006) 46009fbd Update rowserrcheck to v1.1.0 (#1997) 2dcc761d Update wastedassign to v2.0.6 (#2020) 4c27b33c build(deps): bump actions/cache from 2.1.5 to 2.1.6 (#2023) 4e9866ad build(deps): bump github.com/ashanbrown/forbidigo from 1.1.0 to 1.2.0 (#1991) 874304dd build(deps): bump github.com/charithe/durationcheck from 0.0.6 to 0.0.7 (#1990) 6a269af7 build(deps): bump github.com/charithe/durationcheck from 0.0.7 to 0.0.8 (#2052) 4143f57a build(deps): bump github.com/fatih/color from 1.10.0 to 1.11.0 (#1992) b5d847f0 build(deps): bump github.com/mgechev/revive from 1.0.6 to 1.0.7 (#2027) 6ffa139c build(deps): bump github.com/securego/gosec/v2 from 2.7.0 to 2.8.0 (#2025) 555cde6b build(deps): bump github.com/shirou/gopsutil/v3 from 3.21.4 to 3.21.5 (#2042) fe0db3db build(deps): bump github.com/tommy-muehle/go-mnd/v2 from 2.3.2 to 2.4.0 (#2024) 55133bf4 build(deps): bump golang.org/x/tools from 0.1.2 to 0.1.3 (#2053) a68a88ee build(deps): bump honnef.co/go/tools from v0.1.4 to v0.2.0 (#2019) fd6fce9e build(deps): bump ws from 5.2.2 to 5.2.3 in /.github/peril (#2045) 505ed3c0 doc: Un-deprecate enable-all option. (#2039) 3c795d86 doc: add all integrations to docs introduction page (#2040) 7776b546 gomodguard: fix problem where duplicate issues were being reported (#2018) 6172338b nolintlint: fix false positive. (#2013) 2862ca63 output: generate HTML report (#2043) eed344f6 revive: allow to disable rule (#2055) cf8fd685 revive: fix add-constant rule support. (#2003) fb7c90d6 revive: fix excludes (#2005) 62668d41 revive: improve 'exported' rule output. (#1994) b916c931 staticcheck: configuration for staticcheck, gosimple, stylecheck (#2017)

v1.40.1

Changelog

f2ba4bc1 build(deps): bump hosted-git-info from 2.7.1 to 2.8.9 in /tools (#1968) ce672624 build(deps): bump hosted-git-info from 2.8.8 to 2.8.9 in /.github/peril (#1966) b282d301 build(deps): bump lodash from 4.17.19 to 4.17.21 in /tools (#1964) 3aeafb8a build(deps): bump lodash from 4.17.20 to 4.17.21 in /.github/peril (#1967) 47baa2c1 doc: fix example config yaml identation (#1976) f95b1ed3 golint: deprecation (#1965) 589c49ef govet: fix sigchanyzer (#1975) 625445b1 runner: non-zero exit code when a linter produces a panic (#1979)

... (truncated)

Commits

• a207480 revive: fix exclude comment rule for const block. (#2064)
• 6924df8 Bump github.com/ryancurrah/gomodguard from 1.2.1 to 1.2.2 (#2065)
• 4b4d91c docs: update for v1.41.0 (#2062)
• eed344f revive: allow to disable rule (#2055)
• 6a269af build(deps): bump github.com/charithe/durationcheck from 0.0.7 to 0.0.8 (#2052)
• 55133bf build(deps): bump golang.org/x/tools from 0.1.2 to 0.1.3 (#2053)
• fd6fce9 build(deps): bump ws from 5.2.2 to 5.2.3 in /.github/peril (#2045)
• 52b5514 Bump github.com/jgautheron/goconst from 0.5.6 to 0.5.7(#2044)
• 2862ca6 output: generate HTML report (#2043)
• 555cde6 build(deps): bump github.com/shirou/gopsutil/v3 from 3.21.4 to 3.21.5 (#2042)
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[ewbankkit]

golangci-lint failures:

aws/internal/service/amplify/id.go:37:57: mnd: Magic number: 2, in <argument> detected (gomnd)
	parts := strings.SplitN(id, branchResourceIDSeparator, 2)
	                                                       ^
aws/internal/service/elbv2/id.go:11:62: mnd: Magic number: 2, in <argument> detected (gomnd)
	parts := strings.SplitN(id, listenerCertificateIDSeparator, 2)
	                                                            ^
aws/internal/service/rds/id.go:9:37: mnd: Magic number: 2, in <argument> detected (gomnd)
	idParts := strings.SplitN(id, "/", 2)
	                                   ^
aws/internal/service/route53/waiter/waiter.go:32:47: mnd: Magic number: 10, in <argument> detected (gomnd)
		Delay:        time.Duration(rand.Int63n(20)+10) * time.Second,
		                                            ^
aws/internal/service/route53resolver/id.go:18:47: mnd: Magic number: 2, in <argument> detected (gomnd)
	parts := strings.SplitN(id, ruleIdSeparator, 2)
	                                             ^
aws/internal/service/servicecatalog/id.go:9:35: mnd: Magic number: 3, in <argument> detected (gomnd)
	parts := strings.SplitN(id, ":", 3)
	                                 ^
aws/internal/service/servicecatalog/id.go:23:35: mnd: Magic number: 3, in <argument> detected (gomnd)
	parts := strings.SplitN(id, ":", 3)
	                                 ^
aws/internal/service/servicecatalog/id.go:37:35: mnd: Magic number: 2, in <argument> detected (gomnd)
	parts := strings.SplitN(id, ":", 2)
	                                 ^
aws/internal/service/servicecatalog/id.go:51:35: mnd: Magic number: 2, in <argument> detected (gomnd)
	parts := strings.SplitN(id, ":", 2)
	                                 ^
aws/internal/service/servicecatalog/id.go:69:35: mnd: Magic number: 2, in <argument> detected (gomnd)
	parts := strings.SplitN(id, ":", 2)
	                                 ^
aws/internal/service/servicecatalog/id.go:78:35: mnd: Magic number: 3, in <argument> detected (gomnd)
	parts := strings.SplitN(id, ",", 3)
	                                 ^
aws/data_source_aws_dx_gateway.go:67:84: mnd: Magic number: 10, in <argument> detected (gomnd)
	d.Set("amazon_side_asn", strconv.FormatInt(aws.Int64Value(gateway.AmazonSideAsn), 10))
	                                                                                  ^
aws/data_source_aws_vpn_gateway.go:114:80: mnd: Magic number: 10, in <argument> detected (gomnd)
	d.Set("amazon_side_asn", strconv.FormatInt(aws.Int64Value(vgw.AmazonSideAsn), 10))
	                                                                              ^
aws/iam_policy_model.go:113:37: mnd: Magic number: 2, in <argument> detected (gomnd)
				raw[p.Type] = make([]string, 0, 2)
				                                ^
aws/resource_aws_acmpca_certificate.go:286:29: mnd: Magic number: 10, in <argument> detected (gomnd)
	return strconv.ParseInt(v, 10, 64)
	                           ^
aws/resource_aws_acmpca_certificate_authority.go:28:46: mnd: Magic number: 30, in <argument> detected (gomnd)
				d.Set("permanent_deletion_time_in_days", 30)
				                                         ^
aws/resource_aws_api_gateway_method_settings.go:306:41: mnd: Magic number: 3, in <argument> detected (gomnd)
	idParts := strings.SplitN(d.Id(), "/", 3)
	                                       ^
aws/resource_aws_api_gateway_usage_plan.go:343:80: mnd: Magic number: 64, in <argument> detected (gomnd)
					Value: aws.String(strconv.FormatFloat(d["rate_limit"].(float64), 'f', -1, 64)),
					                                                                          ^
aws/resource_aws_api_gateway_usage_plan.go:357:80: mnd: Magic number: 64, in <argument> detected (gomnd)
					Value: aws.String(strconv.FormatFloat(d["rate_limit"].(float64), 'f', -1, 64)),
					                                                                          ^
aws/resource_aws_app_cookie_stickiness_policy.go:219:35: mnd: Magic number: 3, in <argument> detected (gomnd)
	parts := strings.SplitN(id, ":", 3)
	                                 ^
aws/resource_aws_appsync_datasource.go:309:37: mnd: Magic number: 2, in <argument> detected (gomnd)
	idParts := strings.SplitN(id, "-", 2)
	                                   ^
aws/resource_aws_appsync_function.go:209:37: mnd: Magic number: 2, in <argument> detected (gomnd)
	idParts := strings.SplitN(id, "-", 2)
	                                   ^
aws/resource_aws_appsync_resolver.go:285:37: mnd: Magic number: 3, in <argument> detected (gomnd)
	idParts := strings.SplitN(id, "-", 3)
	                                   ^
aws/resource_aws_autoscaling_policy.go:177:71: mnd: Magic number: 100, in <argument> detected (gomnd)
							ValidateFunc: nullable.ValidateTypeStringNullableIntBetween(0, 100),
							                                                               ^
aws/resource_aws_autoscaling_policy.go:404:41: mnd: Magic number: 2, in <argument> detected (gomnd)
	idParts := strings.SplitN(d.Id(), "/", 2)
	                                       ^
aws/resource_aws_autoscaling_policy.go:735:139: mnd: Magic number: 10, in <argument> detected (gomnd)
		predictiveScalingConfigFlat["scheduling_buffer_time"] = strconv.FormatInt(aws.Int64Value(predictiveScalingConfig.SchedulingBufferTime), 10)
		                                                                                                                                        ^
aws/resource_aws_autoscaling_policy.go:741:133: mnd: Magic number: 10, in <argument> detected (gomnd)
		predictiveScalingConfigFlat["max_capacity_buffer"] = strconv.FormatInt(aws.Int64Value(predictiveScalingConfig.MaxCapacityBuffer), 10)
		                                                                                                                                  ^
aws/resource_aws_cloudformation_stack_set_instance.go:306:35: mnd: Magic number: 3, in <argument> detected (gomnd)
	parts := strings.SplitN(id, ",", 3)
	                                 ^
aws/resource_aws_cloudwatch_event_rule.go:358:88: mnd: Magic number: 2048, in <argument> detected (gomnd)
			errors = append(errors, fmt.Errorf("%q cannot be longer than %d characters: %q", k, 2048, json))
			                                                                                    ^
aws/resource_aws_cloudwatch_log_metric_filter.go:245:63: mnd: Magic number: 64, in <argument> detected (gomnd)
		value, _ := strconv.ParseFloat(m["default_value"].(string), 64)
		                                                            ^
aws/resource_aws_cloudwatch_log_metric_filter.go:272:95: mnd: Magic number: 64, in <argument> detected (gomnd)
		m["default_value"] = strconv.FormatFloat(aws.Float64Value(transform.DefaultValue), 'f', -1, 64)
		                                                                                            ^
aws/resource_aws_codedeploy_app.go:235:35: mnd: Magic number: 2, in <argument> detected (gomnd)
	parts := strings.SplitN(id, ":", 2)
	                                 ^
aws/resource_aws_cognito_user_pool_ui_customization.go:180:37: mnd: Magic number: 2, in <argument> detected (gomnd)
	idParts := strings.SplitN(id, ",", 2)
	                                   ^
aws/resource_aws_customer_gateway.go:94:45: mnd: Magic number: 10, in <argument> detected (gomnd)
	i64BgpAsn, err := strconv.ParseInt(bgpAsn, 10, 64)
	                                           ^
aws/resource_aws_customer_gateway.go:309:23: mnd: Magic number: 5, in <argument> detected (gomnd)
	err = resource.Retry(5*time.Minute, func() *resource.RetryError {
	                     ^
aws/resource_aws_dax_cluster.go:503:24: mnd: Magic number: 5, in <argument> detected (gomnd)
	err := resource.Retry(5*time.Minute, func() *resource.RetryError {
	                      ^
aws/resource_aws_db_instance_role_association.go:153:35: mnd: Magic number: 2, in <argument> detected (gomnd)
	parts := strings.SplitN(id, ",", 2)
	                                 ^
aws/resource_aws_db_proxy_target.go:118:37: mnd: Magic number: 4, in <argument> detected (gomnd)
	idParts := strings.SplitN(id, "/", 4)
	                                   ^
aws/resource_aws_directory_service_conditional_forwarder.go:156:35: mnd: Magic number: 2, in <argument> detected (gomnd)
	parts := strings.SplitN(id, ":", 2)
	                                 ^
aws/resource_aws_dms_replication_task.go:109:48: mnd: Magic number: 10, in <argument> detected (gomnd)
		seconds, err := strconv.ParseInt(v.(string), 10, 64)
		                                             ^
aws/resource_aws_dms_replication_task.go:204:70: mnd: Magic number: 10, in <argument> detected (gomnd)
		seconds, err := strconv.ParseInt(d.Get("cdc_start_time").(string), 10, 64)
		                                                                   ^
aws/resource_aws_dx_gateway.go:64:36: mnd: Magic number: 10, in <argument> detected (gomnd)
		if v, err := strconv.ParseInt(v, 10, 64); err == nil {
		                                 ^
aws/resource_aws_dx_gateway.go:100:83: mnd: Magic number: 10, in <argument> detected (gomnd)
	d.Set("amazon_side_asn", strconv.FormatInt(aws.Int64Value(output.AmazonSideAsn), 10))
	                                                                                 ^
aws/resource_aws_dx_hosted_private_virtual_interface.go:169:80: mnd: Magic number: 10, in <argument> detected (gomnd)
	d.Set("amazon_side_asn", strconv.FormatInt(aws.Int64Value(vif.AmazonSideAsn), 10))
	                                                                              ^
aws/resource_aws_dx_hosted_public_virtual_interface.go:166:80: mnd: Magic number: 10, in <argument> detected (gomnd)
	d.Set("amazon_side_asn", strconv.FormatInt(aws.Int64Value(vif.AmazonSideAsn), 10))
	                                                                              ^
aws/resource_aws_dx_hosted_transit_virtual_interface.go:166:80: mnd: Magic number: 10, in <argument> detected (gomnd)
	d.Set("amazon_side_asn", strconv.FormatInt(aws.Int64Value(vif.AmazonSideAsn), 10))
	                                                                              ^
aws/resource_aws_dx_private_virtual_interface.go:197:80: mnd: Magic number: 10, in <argument> detected (gomnd)
	d.Set("amazon_side_asn", strconv.FormatInt(aws.Int64Value(vif.AmazonSideAsn), 10))
	                                                                              ^
aws/resource_aws_dx_public_virtual_interface.go:174:80: mnd: Magic number: 10, in <argument> detected (gomnd)
	d.Set("amazon_side_asn", strconv.FormatInt(aws.Int64Value(vif.AmazonSideAsn), 10))
	                                                                              ^
aws/resource_aws_dx_transit_virtual_interface.go:178:80: mnd: Magic number: 10, in <argument> detected (gomnd)
	d.Set("amazon_side_asn", strconv.FormatInt(aws.Int64Value(vif.AmazonSideAsn), 10))
	                                                                              ^
aws/resource_aws_dynamodb_kinesis_streaming_destination.go:138:35: mnd: Magic number: 2, in <argument> detected (gomnd)
	parts := strings.SplitN(id, ",", 2)
	                                 ^
aws/data_source_aws_secretsmanager_secret_version.go:89:25: S1025: the argument's underlying type is a slice of bytes, should use a simple conversion instead of fmt.Sprintf (gosimple)
	d.Set("secret_binary", fmt.Sprintf("%s", output.SecretBinary))
	                       ^
aws/resource_aws_s3_bucket_object.go:542:2: S1017: should replace this `if` statement with an unconditional `strings.TrimPrefix` (gosimple)
	if strings.HasPrefix(id, "s3://") {
	^

Relates: #16753.

[github-actions]

This functionality has been released in v3.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.