Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_eks_identity_provider_config: Use CreateWithoutTimeoutet al. #20561

Merged
merged 3 commits into from
Aug 18, 2021
Merged

r/aws_eks_identity_provider_config: Use CreateWithoutTimeoutet al. #20561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9101487
r/aws_eks_identity_provider_config: Use 'CreateWithoutTimeout' et al.
ewbankkit Aug 13, 2021
140cdbb
Update documentation.
ewbankkit Aug 13, 2021
87d678e
Add CHANGELOG entry.
ewbankkit Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/20561.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_eks_identity_provider_config: Increase Create and Delete timeouts to 40 minutes
```
12 changes: 6 additions & 6 deletions aws/resource_aws_eks_identity_provider_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ import (

func resourceAwsEksIdentityProviderConfig() *schema.Resource {
return &schema.Resource{
CreateContext: resourceAwsEksIdentityProviderConfigCreate,
ReadContext: resourceAwsEksIdentityProviderConfigRead,
UpdateContext: resourceAwsEksIdentityProviderConfigUpdate,
DeleteContext: resourceAwsEksIdentityProviderConfigDelete,
CreateWithoutTimeout: resourceAwsEksIdentityProviderConfigCreate,
ReadWithoutTimeout: resourceAwsEksIdentityProviderConfigRead,
UpdateWithoutTimeout: resourceAwsEksIdentityProviderConfigUpdate,
DeleteWithoutTimeout: resourceAwsEksIdentityProviderConfigDelete,

Importer: &schema.ResourceImporter{
StateContext: schema.ImportStatePassthroughContext,
Expand All @@ -34,8 +34,8 @@ func resourceAwsEksIdentityProviderConfig() *schema.Resource {
CustomizeDiff: SetTagsDiff,

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(25 * time.Minute),
Delete: schema.DefaultTimeout(25 * time.Minute),
Create: schema.DefaultTimeout(40 * time.Minute),
Delete: schema.DefaultTimeout(40 * time.Minute),
},

Schema: map[string]*schema.Schema{
Expand Down
4 changes: 2 additions & 2 deletions website/docs/r/eks_identity_provider_config.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ In addition to all arguments above, the following attributes are exported:

`aws_eks_identity_provider_config` provides the following [Timeouts](https://www.terraform.io/docs/configuration/blocks/resources/syntax.html#operation-timeouts) configuration options:

* `create` - (Default `25 minutes`) How long to wait for the EKS Identity Provider Configuration to be associated.
* `delete` - (Default `25 minutes`) How long to wait for the EKS Identity Provider Configuration to be disassociated.
* `create` - (Default `40 minutes`) How long to wait for the EKS Identity Provider Configuration to be associated.
* `delete` - (Default `40 minutes`) How long to wait for the EKS Identity Provider Configuration to be disassociated.

## Import

Expand Down