-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new resource aws_chime_voice_connector_termination #20667
Add new resource aws_chime_voice_connector_termination #20667
Conversation
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one small change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aleks1001 , thanks again for this PR! Just a couple additional comments to address. Reach out if you have any questions 😃
Co-authored-by: angie pinilla <angie@hashicorp.com>
Co-authored-by: angie pinilla <angie@hashicorp.com>
Co-authored-by: angie pinilla <angie@hashicorp.com>
Co-authored-by: angie pinilla <angie@hashicorp.com>
Co-authored-by: angie pinilla <angie@hashicorp.com>
Co-authored-by: angie pinilla <angie@hashicorp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @aleks1001 🚀 🚀 ! I've pushed a commit to address a finding I stumbled upon during running the acceptance tests -- looks like the Voice Connector resource can at times return an API error during creation when multiple resources are created in parallel, so I've added some additional logic in our retry handlers. The tests also revealed we were still checking for the voice connector resource instead of the voice connector termination resource, so those references have also been updated.
Output of acceptance tests:
--- PASS: TestAccAWSChimeVoiceConnectorTermination_basic (17.65s)
--- PASS: TestAccAWSChimeVoiceConnectorTermination_update (25.75s)
--- PASS: TestAccAWSChimeVoiceConnectorTermination_disappears (33.22s)
This functionality has been released in v3.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates OR Closes #0000
Output from acceptance testing: