resource/aws_vpc: Set ipv6 properties even if no ipv6 is enabled to allow usage in conditionals (fixes #688) #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in conditionals (fixes #688)
radeksimko
added
bug
4 tasks
radeksimko
added
the
size/S
|
@radeksimko Can this be merged? |
|
@Ninir Do you have any opinion on this? I'd like to get this released in order to resolve terraform-aws-modules/terraform-aws-vpc#21 |
radeksimko
changed the title
|
Are there any updates for this from Terraform's side? |
john-pierce
added a commit
to QuicketSolutions/terraform-provider-aws
that referenced
this pull request
May 3, 2018
hashicorp#2103 * resource/aws_vpc: Set ipv6 properties even if no ipv6 is enabled to allow usage in conditionals (fixes hashicorp#688) hashicorp#2103
bflad
approved these changes
Nov 7, 2018
bflad
added a commit
that referenced
this pull request
Nov 8, 2018
|
This has been released in version 1.43.1 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
Thanks, Brian! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets IPv6-related attributes of a VPC to empty-string instead of leaving them undefined in case the VPC doesn't have VPC enabled. This allows us to use the attributes in a conditional as described in #688.
In a way, this feels like a very specific workaround for hashicorp/hil#50. However, it might help some people creating modules where IPv6-support is optional.
Feel free to reject this PR if you feel it adds more tech-debt than value.