Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quicksight data source resource #21093

Merged
merged 14 commits into from
Sep 30, 2021
Merged

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Sep 29, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10990
Closes #11094
Closes #20710

This PR carries over the commits made in #20710 (based off of #11094) with 2 additional commits to address needed changes

Output from acceptance testing:

--- PASS: TestAccAWSQuickSightDataSource_disappears (31.02s)
--- PASS: TestAccAWSQuickSightDataSource_basic (35.90s)
--- PASS: TestAccAWSQuickSightDataSource_Tags (86.57s)
--- PASS: TestAccAWSQuickSightDataSource_Permissions (93.90s)

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/quicksight Issues and PRs that pertain to the quicksight service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Sep 29, 2021
@anGie44 anGie44 added this to the v3.61.0 milestone Sep 29, 2021
@anGie44 anGie44 force-pushed the f_quicksight_data_source_resource branch from 77677c8 to e2672ff Compare September 30, 2021 00:09
@anGie44 anGie44 merged commit 7a9c313 into main Sep 30, 2021
@anGie44 anGie44 deleted the f_quicksight_data_source_resource branch September 30, 2021 12:33
github-actions bot pushed a commit that referenced this pull request Sep 30, 2021
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This functionality has been released in v3.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/quicksight Issues and PRs that pertain to the quicksight service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants