Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opsworks region fix #21149

Closed
wants to merge 14 commits into from

Conversation

davidkimdon
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #21148

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

I tried running:

$ make testacc TESTARGS='-run=TestAccAWSOpsworks'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSOpsworks -timeout 180m
go: downloading github.com/pquerna/otp v1.3.0
go: downloading github.com/apparentlymart/go-cidr v1.0.1
go: downloading github.com/boombuler/barcode v1.0.1-0.20190219062509-6c824513bacc
=== RUN   TestAccAWSOpsworksApplication_basic
=== PAUSE TestAccAWSOpsworksApplication_basic
. . . 

But I didn't give it any credentials. I wasn't sure what all it would do.

craiggenner and others added 7 commits August 4, 2021 10:45
ASG - correct min value on max_instance_lifetime in the docs
…orp#20701)

As shown in hashicorp#20493 the documentation does not accurately reflect the current observed behaviour of this provider. The docs say that metadata_options.http_endpoint is optional, but the provider gives an error if http_endpoint is omitted.
@github-actions github-actions bot added service/opsworks Issues and PRs that pertain to the opsworks service. needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. labels Oct 5, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @davidkimdon 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Oct 5, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. labels Oct 15, 2021
@github-actions github-actions bot removed documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. service/opsworks Issues and PRs that pertain to the opsworks service. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Oct 15, 2021
@github-actions github-actions bot added the service/opsworks Issues and PRs that pertain to the opsworks service. label Oct 15, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@ewbankkit ewbankkit added the bug Addresses a defect in current functionality. label Aug 11, 2022
@ewbankkit
Copy link
Contributor

@davidkimdon Thanks for the contribution 🎉 👏.
This work has been included in #26278.

@ewbankkit ewbankkit closed this Aug 15, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/opsworks Issues and PRs that pertain to the opsworks service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
5 participants