-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various data sources: Return empty lists rather than errors when no resources match #21219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @jordiprats 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding. Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author. For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000. For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide. |
Hi @zhelding, kind regards, |
This reverts commit 9c81e9d.
Acceptance test output: % make testacc TESTS=TestAccEC2SecurityGroupsDataSource_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2SecurityGroupsDataSource_' -timeout 180m === RUN TestAccEC2SecurityGroupsDataSource_tag === PAUSE TestAccEC2SecurityGroupsDataSource_tag === RUN TestAccEC2SecurityGroupsDataSource_filter === PAUSE TestAccEC2SecurityGroupsDataSource_filter === RUN TestAccEC2SecurityGroupsDataSource_empty === PAUSE TestAccEC2SecurityGroupsDataSource_empty === CONT TestAccEC2SecurityGroupsDataSource_tag === CONT TestAccEC2SecurityGroupsDataSource_empty === CONT TestAccEC2SecurityGroupsDataSource_filter --- PASS: TestAccEC2SecurityGroupsDataSource_empty (12.98s) --- PASS: TestAccEC2SecurityGroupsDataSource_filter (29.08s) --- PASS: TestAccEC2SecurityGroupsDataSource_tag (29.57s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 34.934s
Acceptance test output: % make testacc TESTS=TestAccEC2Instance_instanceProfileChange PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2Instance_instanceProfileChange' -timeout 180m === RUN TestAccEC2Instance_instanceProfileChange === PAUSE TestAccEC2Instance_instanceProfileChange === CONT TestAccEC2Instance_instanceProfileChange --- PASS: TestAccEC2Instance_instanceProfileChange (313.72s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 317.907s
Acceptance test output: % make testacc TESTS=TestAccEC2InstancesDataSource_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstancesDataSource_' -timeout 180m === RUN TestAccEC2InstancesDataSource_basic === PAUSE TestAccEC2InstancesDataSource_basic === RUN TestAccEC2InstancesDataSource_tags === PAUSE TestAccEC2InstancesDataSource_tags === RUN TestAccEC2InstancesDataSource_instanceStateNames === PAUSE TestAccEC2InstancesDataSource_instanceStateNames === RUN TestAccEC2InstancesDataSource_empty === PAUSE TestAccEC2InstancesDataSource_empty === CONT TestAccEC2InstancesDataSource_basic === CONT TestAccEC2InstancesDataSource_instanceStateNames === CONT TestAccEC2InstancesDataSource_empty === CONT TestAccEC2InstancesDataSource_tags --- PASS: TestAccEC2InstancesDataSource_empty (13.42s) --- PASS: TestAccEC2InstancesDataSource_instanceStateNames (111.19s) --- PASS: TestAccEC2InstancesDataSource_basic (119.68s) --- PASS: TestAccEC2InstancesDataSource_tags (121.22s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 126.560s
…ayRouteTables'. Acceptance test output: % make testacc TESTS=TestAccEC2TransitGatewayDataSource_serial/RouteTables PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2TransitGatewayDataSource_serial/RouteTables' -timeout 180m === RUN TestAccEC2TransitGatewayDataSource_serial === RUN TestAccEC2TransitGatewayDataSource_serial/RouteTables === RUN TestAccEC2TransitGatewayDataSource_serial/RouteTables/Empty === RUN TestAccEC2TransitGatewayDataSource_serial/RouteTables/basic === RUN TestAccEC2TransitGatewayDataSource_serial/RouteTables/Filter === RUN TestAccEC2TransitGatewayDataSource_serial/RouteTables/Tags --- PASS: TestAccEC2TransitGatewayDataSource_serial (1087.03s) --- PASS: TestAccEC2TransitGatewayDataSource_serial/RouteTables (1087.03s) --- PASS: TestAccEC2TransitGatewayDataSource_serial/RouteTables/Empty (10.24s) --- PASS: TestAccEC2TransitGatewayDataSource_serial/RouteTables/basic (351.09s) --- PASS: TestAccEC2TransitGatewayDataSource_serial/RouteTables/Filter (340.75s) --- PASS: TestAccEC2TransitGatewayDataSource_serial/RouteTables/Tags (384.95s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 1090.624s
Acceptance test output: % aws ec2 describe-coip-pools --pool-ids ipv4pool-coip-123a45678b0001234 An error occurred (InvalidPoolID.NotFound) when calling the DescribeCoipPools operation: The pool ID 'ipv4pool-coip-123a45678b0001234' does not exist. ewbankkit@ewbankkit-C02F408DML85 terraform-provider-aws % make testacc TESTS=TestAccEC2CoIPPoolsDataSource_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2CoIPPoolsDataSource_' -timeout 180m === RUN TestAccEC2CoIPPoolsDataSource_basic === PAUSE TestAccEC2CoIPPoolsDataSource_basic === RUN TestAccEC2CoIPPoolsDataSource_filter === PAUSE TestAccEC2CoIPPoolsDataSource_filter === CONT TestAccEC2CoIPPoolsDataSource_basic === CONT TestAccEC2CoIPPoolsDataSource_filter acctest.go:1255: skipping since no Outposts found --- SKIP: TestAccEC2CoIPPoolsDataSource_filter (1.36s) === CONT TestAccEC2CoIPPoolsDataSource_basic acctest.go:1255: skipping since no Outposts found --- SKIP: TestAccEC2CoIPPoolsDataSource_basic (1.53s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 5.178s
…uteTables'. Acceptance test output: % make testacc TESTS=TestAccEC2LocalGatewayRouteTablesDataSource_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2LocalGatewayRouteTablesDataSource_' -timeout 180m === RUN TestAccEC2LocalGatewayRouteTablesDataSource_basic === PAUSE TestAccEC2LocalGatewayRouteTablesDataSource_basic === RUN TestAccEC2LocalGatewayRouteTablesDataSource_filter === PAUSE TestAccEC2LocalGatewayRouteTablesDataSource_filter === CONT TestAccEC2LocalGatewayRouteTablesDataSource_basic === CONT TestAccEC2LocalGatewayRouteTablesDataSource_filter === CONT TestAccEC2LocalGatewayRouteTablesDataSource_basic acctest.go:1255: skipping since no Outposts found --- SKIP: TestAccEC2LocalGatewayRouteTablesDataSource_basic (2.31s) === CONT TestAccEC2LocalGatewayRouteTablesDataSource_filter acctest.go:1255: skipping since no Outposts found --- SKIP: TestAccEC2LocalGatewayRouteTablesDataSource_filter (8.82s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 12.555s
…calGatewayVirtualInterfaceGroups'. Acceptance test output: % make testacc TESTS=TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_' -timeout 180m === RUN TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_basic === PAUSE TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_basic === RUN TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_filter === PAUSE TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_filter === RUN TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_tags === PAUSE TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_tags === CONT TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_basic === CONT TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_tags === CONT TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_filter acctest.go:1255: skipping since no Outposts found --- SKIP: TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_filter (1.40s) === CONT TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_basic acctest.go:1255: skipping since no Outposts found --- SKIP: TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_basic (8.10s) === CONT TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_tags acctest.go:1255: skipping since no Outposts found --- SKIP: TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_tags (8.12s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 14.867s
Acceptance test output: % make testacc TESTS=TestAccEC2LocalGatewaysDataSource_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2LocalGatewaysDataSource_' -timeout 180m === RUN TestAccEC2LocalGatewaysDataSource_basic === PAUSE TestAccEC2LocalGatewaysDataSource_basic === CONT TestAccEC2LocalGatewaysDataSource_basic acctest.go:1255: skipping since no Outposts found --- SKIP: TestAccEC2LocalGatewaysDataSource_basic (3.35s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 9.011s
Acceptance test output: % make testacc TESTS=TestAccEC2EBSVolumesDataSource_ PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EBSVolumesDataSource_' -timeout 180m === RUN TestAccEC2EBSVolumesDataSource_basic === PAUSE TestAccEC2EBSVolumesDataSource_basic === CONT TestAccEC2EBSVolumesDataSource_basic --- PASS: TestAccEC2EBSVolumesDataSource_basic (31.42s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 36.659s
Acceptance test output: % make testacc TESTS=TestAccCognitoIDPUserPoolsDataSource_ PKG=cognitoidp ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserPoolsDataSource_' -timeout 180m === RUN TestAccCognitoIDPUserPoolsDataSource_basic === PAUSE TestAccCognitoIDPUserPoolsDataSource_basic === CONT TestAccCognitoIDPUserPoolsDataSource_basic --- PASS: TestAccCognitoIDPUserPoolsDataSource_basic (18.78s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 24.721s
Acceptance test output: % make testacc TESTS=TestAccMetaIPRangesDataSource_ PKG=meta ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/meta/... -v -count 1 -parallel 20 -run='TestAccMetaIPRangesDataSource_' -timeout 180m === RUN TestAccMetaIPRangesDataSource_basic === PAUSE TestAccMetaIPRangesDataSource_basic === RUN TestAccMetaIPRangesDataSource_url === PAUSE TestAccMetaIPRangesDataSource_url === CONT TestAccMetaIPRangesDataSource_basic === CONT TestAccMetaIPRangesDataSource_url --- PASS: TestAccMetaIPRangesDataSource_url (16.39s) --- PASS: TestAccMetaIPRangesDataSource_basic (17.24s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/meta 22.673s
Acceptance test output: % make testacc TESTS=TestAccEFSAccessPointsDataSource_ PKG=efs ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 20 -run='TestAccEFSAccessPointsDataSource_' -timeout 180m === RUN TestAccEFSAccessPointsDataSource_basic === PAUSE TestAccEFSAccessPointsDataSource_basic === RUN TestAccEFSAccessPointsDataSource_empty === PAUSE TestAccEFSAccessPointsDataSource_empty === CONT TestAccEFSAccessPointsDataSource_basic === CONT TestAccEFSAccessPointsDataSource_empty --- PASS: TestAccEFSAccessPointsDataSource_empty (29.39s) --- PASS: TestAccEFSAccessPointsDataSource_basic (39.36s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/efs 45.604s
Acceptance test output: % make testacc TESTS=TestAccEMRReleaseLabels_ PKG=emr ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20 -run='TestAccEMRReleaseLabels_' -timeout 180m === RUN TestAccEMRReleaseLabels_basic === PAUSE TestAccEMRReleaseLabels_basic === RUN TestAccEMRReleaseLabels_prefix === PAUSE TestAccEMRReleaseLabels_prefix === RUN TestAccEMRReleaseLabels_application === PAUSE TestAccEMRReleaseLabels_application === RUN TestAccEMRReleaseLabels_full === PAUSE TestAccEMRReleaseLabels_full === RUN TestAccEMRReleaseLabels_empty === PAUSE TestAccEMRReleaseLabels_empty === CONT TestAccEMRReleaseLabels_basic === CONT TestAccEMRReleaseLabels_full === CONT TestAccEMRReleaseLabels_empty === CONT TestAccEMRReleaseLabels_prefix === CONT TestAccEMRReleaseLabels_application --- PASS: TestAccEMRReleaseLabels_application (18.21s) --- PASS: TestAccEMRReleaseLabels_prefix (18.57s) --- PASS: TestAccEMRReleaseLabels_empty (18.75s) --- PASS: TestAccEMRReleaseLabels_full (18.79s) --- PASS: TestAccEMRReleaseLabels_basic (19.38s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/emr 24.816s
Acceptance test output: % make testacc TESTS=TestAccSSOAdminInstancesDataSource_ PKG=ssoadmin ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ssoadmin/... -v -count 1 -parallel 20 -run='TestAccSSOAdminInstancesDataSource_' -timeout 180m === RUN TestAccSSOAdminInstancesDataSource_basic === PAUSE TestAccSSOAdminInstancesDataSource_basic === CONT TestAccSSOAdminInstancesDataSource_basic --- PASS: TestAccSSOAdminInstancesDataSource_basic (12.10s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin 17.085s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEC2SecurityGroupsDataSource_\|TestAccEC2InstancesDataSource_\|TestAccEC2RouteTablesDataSource_\|TestAccEC2NetworkInterfacesDataSource_\|TestAccEC2NetworkACLsDataSource_\|TestAccEC2TransitGatewayDataSource_serial/RouteTables' PKG=ec2 ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 5 -run=TestAccEC2SecurityGroupsDataSource_\|TestAccEC2InstancesDataSource_\|TestAccEC2RouteTablesDataSource_\|TestAccEC2NetworkInterfacesDataSource_\|TestAccEC2NetworkACLsDataSource_\|TestAccEC2TransitGatewayDataSource_serial/RouteTables -timeout 180m
=== RUN TestAccEC2InstancesDataSource_basic
=== PAUSE TestAccEC2InstancesDataSource_basic
=== RUN TestAccEC2InstancesDataSource_tags
=== PAUSE TestAccEC2InstancesDataSource_tags
=== RUN TestAccEC2InstancesDataSource_instanceStateNames
=== PAUSE TestAccEC2InstancesDataSource_instanceStateNames
=== RUN TestAccEC2InstancesDataSource_empty
=== PAUSE TestAccEC2InstancesDataSource_empty
=== RUN TestAccEC2NetworkACLsDataSource_basic
=== PAUSE TestAccEC2NetworkACLsDataSource_basic
=== RUN TestAccEC2NetworkACLsDataSource_filter
=== PAUSE TestAccEC2NetworkACLsDataSource_filter
=== RUN TestAccEC2NetworkACLsDataSource_tags
=== PAUSE TestAccEC2NetworkACLsDataSource_tags
=== RUN TestAccEC2NetworkACLsDataSource_vpcID
=== PAUSE TestAccEC2NetworkACLsDataSource_vpcID
=== RUN TestAccEC2NetworkACLsDataSource_empty
=== PAUSE TestAccEC2NetworkACLsDataSource_empty
=== RUN TestAccEC2NetworkInterfacesDataSource_filter
=== PAUSE TestAccEC2NetworkInterfacesDataSource_filter
=== RUN TestAccEC2NetworkInterfacesDataSource_tags
=== PAUSE TestAccEC2NetworkInterfacesDataSource_tags
=== RUN TestAccEC2NetworkInterfacesDataSource_empty
=== PAUSE TestAccEC2NetworkInterfacesDataSource_empty
=== RUN TestAccEC2RouteTablesDataSource_basic
=== PAUSE TestAccEC2RouteTablesDataSource_basic
=== RUN TestAccEC2SecurityGroupsDataSource_tag
=== PAUSE TestAccEC2SecurityGroupsDataSource_tag
=== RUN TestAccEC2SecurityGroupsDataSource_filter
=== PAUSE TestAccEC2SecurityGroupsDataSource_filter
=== RUN TestAccEC2SecurityGroupsDataSource_empty
=== PAUSE TestAccEC2SecurityGroupsDataSource_empty
=== RUN TestAccEC2TransitGatewayDataSource_serial
=== RUN TestAccEC2TransitGatewayDataSource_serial/RouteTables
=== RUN TestAccEC2TransitGatewayDataSource_serial/RouteTables/Tags
=== RUN TestAccEC2TransitGatewayDataSource_serial/RouteTables/Empty
=== RUN TestAccEC2TransitGatewayDataSource_serial/RouteTables/basic
=== RUN TestAccEC2TransitGatewayDataSource_serial/RouteTables/Filter
--- PASS: TestAccEC2TransitGatewayDataSource_serial (1048.47s)
--- PASS: TestAccEC2TransitGatewayDataSource_serial/RouteTables (1048.47s)
--- PASS: TestAccEC2TransitGatewayDataSource_serial/RouteTables/Tags (346.42s)
--- PASS: TestAccEC2TransitGatewayDataSource_serial/RouteTables/Empty (10.04s)
--- PASS: TestAccEC2TransitGatewayDataSource_serial/RouteTables/basic (333.84s)
--- PASS: TestAccEC2TransitGatewayDataSource_serial/RouteTables/Filter (358.17s)
=== CONT TestAccEC2InstancesDataSource_basic
=== CONT TestAccEC2NetworkACLsDataSource_empty
=== CONT TestAccEC2NetworkACLsDataSource_basic
=== CONT TestAccEC2NetworkACLsDataSource_tags
=== CONT TestAccEC2RouteTablesDataSource_basic
--- PASS: TestAccEC2NetworkACLsDataSource_empty (9.76s)
=== CONT TestAccEC2InstancesDataSource_instanceStateNames
--- PASS: TestAccEC2NetworkACLsDataSource_basic (22.23s)
=== CONT TestAccEC2InstancesDataSource_empty
--- PASS: TestAccEC2NetworkACLsDataSource_tags (22.31s)
=== CONT TestAccEC2NetworkInterfacesDataSource_tags
--- PASS: TestAccEC2RouteTablesDataSource_basic (24.23s)
=== CONT TestAccEC2NetworkInterfacesDataSource_empty
--- PASS: TestAccEC2InstancesDataSource_empty (9.61s)
=== CONT TestAccEC2InstancesDataSource_tags
--- PASS: TestAccEC2NetworkInterfacesDataSource_empty (10.11s)
=== CONT TestAccEC2NetworkInterfacesDataSource_filter
--- PASS: TestAccEC2NetworkInterfacesDataSource_tags (27.75s)
=== CONT TestAccEC2NetworkACLsDataSource_vpcID
--- PASS: TestAccEC2NetworkInterfacesDataSource_filter (27.36s)
=== CONT TestAccEC2NetworkACLsDataSource_filter
--- PASS: TestAccEC2NetworkACLsDataSource_vpcID (21.78s)
=== CONT TestAccEC2SecurityGroupsDataSource_filter
--- PASS: TestAccEC2NetworkACLsDataSource_filter (21.27s)
=== CONT TestAccEC2SecurityGroupsDataSource_empty
--- PASS: TestAccEC2SecurityGroupsDataSource_empty (9.14s)
=== CONT TestAccEC2SecurityGroupsDataSource_tag
--- PASS: TestAccEC2SecurityGroupsDataSource_filter (25.45s)
--- PASS: TestAccEC2InstancesDataSource_instanceStateNames (97.45s)
--- PASS: TestAccEC2SecurityGroupsDataSource_tag (26.25s)
--- PASS: TestAccEC2InstancesDataSource_basic (138.83s)
--- PASS: TestAccEC2InstancesDataSource_tags (125.30s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 1209.232s
% make testacc TESTARGS='-run=TestAccEC2CoIPPoolsDataSource_\|TestAccEC2LocalGatewayRouteTablesDataSource_\|TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_\|TestAccEC2LocalGatewaysDataSource_\|TestAccEC2EBSVolumesDataSource_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2CoIPPoolsDataSource_\|TestAccEC2LocalGatewayRouteTablesDataSource_\|TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_\|TestAccEC2LocalGatewaysDataSource_\|TestAccEC2EBSVolumesDataSource_ -timeout 180m
=== RUN TestAccEC2CoIPPoolsDataSource_basic
=== PAUSE TestAccEC2CoIPPoolsDataSource_basic
=== RUN TestAccEC2CoIPPoolsDataSource_filter
=== PAUSE TestAccEC2CoIPPoolsDataSource_filter
=== RUN TestAccEC2EBSVolumesDataSource_basic
=== PAUSE TestAccEC2EBSVolumesDataSource_basic
=== RUN TestAccEC2LocalGatewayRouteTablesDataSource_basic
=== PAUSE TestAccEC2LocalGatewayRouteTablesDataSource_basic
=== RUN TestAccEC2LocalGatewayRouteTablesDataSource_filter
=== PAUSE TestAccEC2LocalGatewayRouteTablesDataSource_filter
=== RUN TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_basic
=== PAUSE TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_basic
=== RUN TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_filter
=== PAUSE TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_filter
=== RUN TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_tags
=== PAUSE TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_tags
=== RUN TestAccEC2LocalGatewaysDataSource_basic
=== PAUSE TestAccEC2LocalGatewaysDataSource_basic
=== CONT TestAccEC2CoIPPoolsDataSource_basic
=== CONT TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_basic
=== CONT TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_tags
=== CONT TestAccEC2LocalGatewayRouteTablesDataSource_basic
=== CONT TestAccEC2CoIPPoolsDataSource_filter
=== CONT TestAccEC2LocalGatewaysDataSource_basic
=== CONT TestAccEC2LocalGatewayRouteTablesDataSource_filter
=== CONT TestAccEC2EBSVolumesDataSource_basic
=== CONT TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_filter
=== CONT TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_basic
acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_basic (1.92s)
=== CONT TestAccEC2LocalGatewayRouteTablesDataSource_filter
acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2LocalGatewayRouteTablesDataSource_filter (1.97s)
=== CONT TestAccEC2LocalGatewaysDataSource_basic
acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2LocalGatewaysDataSource_basic (2.00s)
=== CONT TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_filter
acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_filter (2.01s)
=== CONT TestAccEC2CoIPPoolsDataSource_basic
acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2CoIPPoolsDataSource_basic (2.03s)
=== CONT TestAccEC2LocalGatewayRouteTablesDataSource_basic
acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2LocalGatewayRouteTablesDataSource_basic (2.03s)
=== CONT TestAccEC2CoIPPoolsDataSource_filter
acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2CoIPPoolsDataSource_filter (2.07s)
=== CONT TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_tags
acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2LocalGatewayVirtualInterfaceGroupsDataSource_tags (5.63s)
--- PASS: TestAccEC2EBSVolumesDataSource_basic (32.18s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 35.617s
% make testacc TESTS=TestAccCognitoIDPUserPoolsDataSource_ PKG=cognitoidp
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserPoolsDataSource_' -timeout 180m
=== RUN TestAccCognitoIDPUserPoolsDataSource_basic
=== PAUSE TestAccCognitoIDPUserPoolsDataSource_basic
=== CONT TestAccCognitoIDPUserPoolsDataSource_basic
--- PASS: TestAccCognitoIDPUserPoolsDataSource_basic (16.60s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 20.217s
% make testacc TESTS=TestAccMetaIPRangesDataSource_ PKG=meta
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/meta/... -v -count 1 -parallel 20 -run='TestAccMetaIPRangesDataSource_' -timeout 180m
=== RUN TestAccMetaIPRangesDataSource_basic
=== PAUSE TestAccMetaIPRangesDataSource_basic
=== RUN TestAccMetaIPRangesDataSource_url
=== PAUSE TestAccMetaIPRangesDataSource_url
=== CONT TestAccMetaIPRangesDataSource_basic
=== CONT TestAccMetaIPRangesDataSource_url
--- PASS: TestAccMetaIPRangesDataSource_url (11.46s)
--- PASS: TestAccMetaIPRangesDataSource_basic (11.89s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/meta 15.373s
% make testacc TESTS=TestAccEFSAccessPointsDataSource_ PKG=efs
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 20 -run='TestAccEFSAccessPointsDataSource_' -timeout 180m
=== RUN TestAccEFSAccessPointsDataSource_basic
=== PAUSE TestAccEFSAccessPointsDataSource_basic
=== RUN TestAccEFSAccessPointsDataSource_empty
=== PAUSE TestAccEFSAccessPointsDataSource_empty
=== CONT TestAccEFSAccessPointsDataSource_basic
=== CONT TestAccEFSAccessPointsDataSource_empty
--- PASS: TestAccEFSAccessPointsDataSource_empty (22.56s)
--- PASS: TestAccEFSAccessPointsDataSource_basic (28.59s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/efs 32.289s
% make testacc TESTS=TestAccEMRReleaseLabels_ PKG=emr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emr/... -v -count 1 -parallel 20 -run='TestAccEMRReleaseLabels_' -timeout 180m
=== RUN TestAccEMRReleaseLabels_basic
=== PAUSE TestAccEMRReleaseLabels_basic
=== RUN TestAccEMRReleaseLabels_prefix
=== PAUSE TestAccEMRReleaseLabels_prefix
=== RUN TestAccEMRReleaseLabels_application
=== PAUSE TestAccEMRReleaseLabels_application
=== RUN TestAccEMRReleaseLabels_full
=== PAUSE TestAccEMRReleaseLabels_full
=== RUN TestAccEMRReleaseLabels_empty
=== PAUSE TestAccEMRReleaseLabels_empty
=== CONT TestAccEMRReleaseLabels_basic
=== CONT TestAccEMRReleaseLabels_full
=== CONT TestAccEMRReleaseLabels_empty
=== CONT TestAccEMRReleaseLabels_prefix
=== CONT TestAccEMRReleaseLabels_application
--- PASS: TestAccEMRReleaseLabels_prefix (12.83s)
--- PASS: TestAccEMRReleaseLabels_full (12.89s)
--- PASS: TestAccEMRReleaseLabels_empty (12.94s)
--- PASS: TestAccEMRReleaseLabels_application (13.41s)
--- PASS: TestAccEMRReleaseLabels_basic (14.85s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/emr 18.580s
% make testacc TESTS=TestAccInspectorRulesPackagesDataSource_ PKG=inspector
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/inspector/... -v -count 1 -parallel 20 -run='TestAccInspectorRulesPackagesDataSource_' -timeout 180m
=== RUN TestAccInspectorRulesPackagesDataSource_basic
=== PAUSE TestAccInspectorRulesPackagesDataSource_basic
=== CONT TestAccInspectorRulesPackagesDataSource_basic
--- PASS: TestAccInspectorRulesPackagesDataSource_basic (9.55s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/inspector 13.141s
% make testacc TESTS=TestAccRDSEventCategoriesDataSource_ PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSEventCategoriesDataSource_' -timeout 180m
=== RUN TestAccRDSEventCategoriesDataSource_basic
=== PAUSE TestAccRDSEventCategoriesDataSource_basic
=== RUN TestAccRDSEventCategoriesDataSource_sourceType
=== PAUSE TestAccRDSEventCategoriesDataSource_sourceType
=== CONT TestAccRDSEventCategoriesDataSource_basic
=== CONT TestAccRDSEventCategoriesDataSource_sourceType
--- PASS: TestAccRDSEventCategoriesDataSource_sourceType (12.60s)
--- PASS: TestAccRDSEventCategoriesDataSource_basic (12.63s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 16.116s
% make testacc TESTS=TestAccSSOAdminInstancesDataSource_ PKG=ssoadmin
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ssoadmin/... -v -count 1 -parallel 20 -run='TestAccSSOAdminInstancesDataSource_' -timeout 180m
=== RUN TestAccSSOAdminInstancesDataSource_basic
=== PAUSE TestAccSSOAdminInstancesDataSource_basic
=== CONT TestAccSSOAdminInstancesDataSource_basic
--- PASS: TestAccSSOAdminInstancesDataSource_basic (11.97s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin 15.657s
@jordiprats Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
This PR updates the datasource aws_security_groups to make it compliant with terraform's Provider Design guidalines: It returns an empty list when the tags won't match any SG
Closes #8302.
Closes #17540.
Relates #20433.
Relates #22776.
Output from acceptance testing: