tls_version_and_cipher_suite and xff_client_port

[ericrichtert]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21666

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateTLSVersionAndCipherSuite' PKG_NAME=internal/service/elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run=TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateTLSVersionAndCipherSuite -timeout 180m
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateTLSVersionAndCipherSuite
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateTLSVersionAndCipherSuite
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateTLSVersionAndCipherSuite
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateTLSVersionAndCipherSuite (421.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	426.130s
...

[github-actions]

Welcome @ericrichtert 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ericrichtert]

I fixed a mergeconflict and add xff_client_port for #22049

Closes #22049

[ericrichtert]

$ make testacc TESTARGS='-run=TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateXFFClientPort' PKG_NAME=internal/service/elbv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run=TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateXFFClientPort -timeout 180m
=== RUN TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateXFFClientPort
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateXFFClientPort
=== CONT TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateXFFClientPort
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateXFFClientPort (334.17s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/elbv2 337.138s

[MatteoPierro]

Why is this still not merged? It's a useful feature, I needed it recently and I had to enable the option manually for a several ALBs 😢

[ericrichtert]

Why is this still not merged? It's a useful feature, I needed it recently and I had to enable the option manually for a several ALBs 😢

I don't know. There seems to be no attention from the maintainers for this request. I can solve the mergeconflicts, but as long as this isn't being planned to merge, I won't do that.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.