Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/elasticsearch_domin: use tags as KeyValueTags type instead of as []*elasticsearchservice.Tag in UpdateTags #21738

Merged
merged 2 commits into from
Nov 11, 2021
Merged

r/elasticsearch_domin: use tags as KeyValueTags type instead of as []*elasticsearchservice.Tag in UpdateTags #21738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f45381a
pass in keyvaluetags instead
anGie44 Nov 11, 2021
7a5bb2a
Update CHANGELOG for #21738
anGie44 Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/21738.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_elasticsearch_domain: Fix tagging on creation
```
2 changes: 1 addition & 1 deletion internal/service/elasticsearch/domain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,7 +626,7 @@ func resourceDomainCreate(d *schema.ResourceData, meta interface{}) error {
// whilst the operation is being performed), we still get the required tags on
// the resources.
if len(tags) > 0 {
if err := UpdateTags(conn, d.Id(), nil, Tags(tags.IgnoreAWS())); err != nil {
if err := UpdateTags(conn, d.Id(), nil, tags); err != nil {
anGie44 marked this conversation as resolved.
Show resolved Hide resolved
return fmt.Errorf("error adding Elasticsearch Cluster (%s) tags: %s", d.Id(), err)
}
}
Expand Down