-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2/vpc_endpoint: Fix erroneous diffs with equivalent policies #22137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccEC2VPCEndpoint_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2VPCEndpoint_' -timeout 180m
=== RUN TestAccEC2VPCEndpoint_gatewayBasic
=== PAUSE TestAccEC2VPCEndpoint_gatewayBasic
=== RUN TestAccEC2VPCEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccEC2VPCEndpoint_gatewayWithRouteTableAndPolicy
=== RUN TestAccEC2VPCEndpoint_gatewayPolicy
=== PAUSE TestAccEC2VPCEndpoint_gatewayPolicy
=== RUN TestAccEC2VPCEndpoint_ignoreEquivalent
=== PAUSE TestAccEC2VPCEndpoint_ignoreEquivalent
=== RUN TestAccEC2VPCEndpoint_interfaceBasic
=== PAUSE TestAccEC2VPCEndpoint_interfaceBasic
=== RUN TestAccEC2VPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccEC2VPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN TestAccEC2VPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccEC2VPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN TestAccEC2VPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccEC2VPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN TestAccEC2VPCEndpoint_disappears
=== PAUSE TestAccEC2VPCEndpoint_disappears
=== RUN TestAccEC2VPCEndpoint_tags
=== PAUSE TestAccEC2VPCEndpoint_tags
=== CONT TestAccEC2VPCEndpoint_gatewayBasic
=== CONT TestAccEC2VPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== CONT TestAccEC2VPCEndpoint_tags
=== CONT TestAccEC2VPCEndpoint_gatewayPolicy
=== CONT TestAccEC2VPCEndpoint_ignoreEquivalent
=== CONT TestAccEC2VPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== CONT TestAccEC2VPCEndpoint_interfaceBasic
=== CONT TestAccEC2VPCEndpoint_disappears
=== CONT TestAccEC2VPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== CONT TestAccEC2VPCEndpoint_gatewayWithRouteTableAndPolicy
--- PASS: TestAccEC2VPCEndpoint_disappears (36.13s)
--- PASS: TestAccEC2VPCEndpoint_gatewayBasic (41.14s)
--- PASS: TestAccEC2VPCEndpoint_ignoreEquivalent (56.71s)
--- PASS: TestAccEC2VPCEndpoint_gatewayPolicy (69.41s)
--- PASS: TestAccEC2VPCEndpoint_tags (80.04s)
--- PASS: TestAccEC2VPCEndpoint_gatewayWithRouteTableAndPolicy (82.31s)
--- PASS: TestAccEC2VPCEndpoint_interfaceBasic (116.77s)
--- PASS: TestAccEC2VPCEndpoint_interfaceNonAWSServiceAcceptOnCreate (302.96s)
--- PASS: TestAccEC2VPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate (316.71s)
--- PASS: TestAccEC2VPCEndpoint_interfaceWithSubnetAndSecurityGroup (560.84s)
This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #21968
Output from acceptance testing (
us-west-2
):Output from acceptance testing (GovCloud):