Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/s3_bucket: read-only versioning argument #22606

Merged
merged 7 commits into from
Feb 7, 2022
Merged

r/s3_bucket: read-only versioning argument #22606

merged 7 commits into from
Feb 7, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 15, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #4418
Relates #20433
Preceded by #5132
Output from acceptance testing:

--- PASS: TestAccSyntheticsCanary_StartCanary_codeChanges (106.18s)
--- PASS: TestAccSyntheticsCanary_artifactEncryption (81.56s)
--- PASS: TestAccSyntheticsCanary_basic (126.11s)
--- PASS: TestAccSyntheticsCanary_disappears (270.06s)
--- PASS: TestAccSyntheticsCanary_run (129.72s)
--- PASS: TestAccSyntheticsCanary_runTracing (97.99s)
--- PASS: TestAccSyntheticsCanary_runtimeVersion (160.74s)
--- PASS: TestAccSyntheticsCanary_s3 (261.51s)
--- PASS: TestAccSyntheticsCanary_startCanary (109.43s)
--- PASS: TestAccSyntheticsCanary_vpc (2100.24s)
--- PASS: TestAccSyntheticsCanary_tags (108.12s)

--- PASS: TestAccAPIGatewayDomainNameDataSource_basic (140.77s)
--- PASS: TestAccAPIGatewayDomainName_disappears (26.83s)
--- PASS: TestAccAPIGatewayDomainName_regionalCertificateARN (128.30s)
--- PASS: TestAccAPIGatewayDomainName_securityPolicy (70.09s)
--- PASS: TestAccAPIGatewayDomainName_tags (113.63s)

--- PASS: TestAccAPIGatewayV2DomainName_basic (690.64s)
--- PASS: TestAccAPIGatewayV2DomainName_disappears (442.05s)
--- PASS: TestAccAPIGatewayV2DomainName_tags (262.47s)
--- PASS: TestAccAPIGatewayV2DomainName_updateCertificate (512.81s)

--- PASS: TestAccKafkaConnectCustomPluginDataSource_basic (76.36s)
--- PASS: TestAccKafkaConnectCustomPlugin_basic (74.70s)
--- PASS: TestAccKafkaConnectCustomPlugin_contentType (93.52s)
--- PASS: TestAccKafkaConnectCustomPlugin_description (71.83s)
--- PASS: TestAccKafkaConnectCustomPlugin_objectVersion (72.25s)

--- PASS: TestAccLambdaFunctionDataSource_alias (106.83s)
--- PASS: TestAccLambdaFunctionDataSource_architectures (104.38s)
--- PASS: TestAccLambdaFunctionDataSource_basic (105.93s)
--- PASS: TestAccLambdaFunctionDataSource_environment (105.90s)
--- PASS: TestAccLambdaFunctionDataSource_fileSystem (396.58s)
--- PASS: TestAccLambdaFunctionDataSource_layers (98.92s)
--- PASS: TestAccLambdaFunctionDataSource_version (91.70s)
--- PASS: TestAccLambdaFunctionDataSource_vpc (476.88s)

--- PASS: TestAccLambdaFunctionEventInvokeConfig_DestinationOnFailure_destination (200.01s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_DestinationOnSuccess_destination (189.50s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_Destination_remove (172.57s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_Destination_swap (169.73s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_Disappears_lambdaFunction (93.63s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_Disappears_lambdaFunctionEventInvoke (94.20s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_FunctionName_arn (104.47s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_QualifierFunctionName_arn (101.26s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_Qualifier_aliasName (104.68s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_Qualifier_functionVersion (94.25s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_Qualifier_latest (96.52s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_basic (102.77s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_maximumEventAgeInSeconds (144.38s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_maximumRetryAttempts (224.50s)

--- PASS: TestAccLambdaFunction_EnvironmentVariables_noValue (110.30s)
--- PASS: TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables (101.29s)
--- PASS: TestAccLambdaFunction_LocalUpdate_nameOnly (83.66s)
--- PASS: TestAccLambdaFunction_S3Update_basic (80.99s)
--- PASS: TestAccLambdaFunction_S3Update_unversioned (78.00s)
--- PASS: TestAccLambdaFunction_VPCPublishHas_changes (301.22s)
--- PASS: TestAccLambdaFunction_VPCPublishNo_changes (1543.59s)
--- PASS: TestAccLambdaFunction_VPC_properIAMDependencies (1348.89s)
--- PASS: TestAccLambdaFunction_VPC_withInvocation (270.01s)
--- PASS: TestAccLambdaFunction_Zip_validation (8.53s)
--- PASS: TestAccLambdaFunction_architectures (168.65s)
--- PASS: TestAccLambdaFunction_architecturesUpdate (164.85s)
--- PASS: TestAccLambdaFunction_architecturesWithLayer (158.54s)
--- PASS: TestAccLambdaFunction_basic (95.11s)
--- PASS: TestAccLambdaFunction_codeSigning (238.85s)
--- PASS: TestAccLambdaFunction_concurrency (169.52s)
--- PASS: TestAccLambdaFunction_concurrencyCycle (224.18s)
--- PASS: TestAccLambdaFunction_deadLetter (174.92s)
--- PASS: TestAccLambdaFunction_deadLetterUpdated (174.37s)
--- PASS: TestAccLambdaFunction_disablePublish (159.95s)
--- PASS: TestAccLambdaFunction_disappears (89.03s)
--- PASS: TestAccLambdaFunction_emptyVPC (55.82s)
--- PASS: TestAccLambdaFunction_enablePublish (210.02s)
--- PASS: TestAccLambdaFunction_encryptedEnvVariables (171.54s)
--- PASS: TestAccLambdaFunction_envVariables (285.01s)
--- PASS: TestAccLambdaFunction_expectFilenameAndS3Attributes (36.19s)
--- PASS: TestAccLambdaFunction_fileSystem (654.39s)
--- PASS: TestAccLambdaFunction_layers (104.54s)
--- PASS: TestAccLambdaFunction_layersUpdate (140.65s)
--- PASS: TestAccLambdaFunction_localUpdate (84.12s)
--- PASS: TestAccLambdaFunction_nilDeadLetter (41.09s)
--- PASS: TestAccLambdaFunction_runtimes (426.18s)
--- PASS: TestAccLambdaFunction_s3 (64.86s)
--- PASS: TestAccLambdaFunction_tags (92.07s)
--- PASS: TestAccLambdaFunction_tracing (152.86s)
--- PASS: TestAccLambdaFunction_unpublishedCodeUpdate (161.91s)
--- PASS: TestAccLambdaFunction_versioned (102.20s)
--- PASS: TestAccLambdaFunction_versionedUpdate (225.75s)
--- PASS: TestAccLambdaFunction_vpc (428.91s)
--- PASS: TestAccLambdaFunction_vpcRemoval (269.40s)
--- PASS: TestAccLambdaFunction_vpcUpdate (670.95s)

--- PASS: TestAccMWAAEnvironment_airflowOptions (3625.80s)
--- PASS: TestAccMWAAEnvironment_basic (2183.48s)
--- PASS: TestAccMWAAEnvironment_disappears (2131.30s)
--- PASS: TestAccMWAAEnvironment_full (2005.08s)
--- PASS: TestAccMWAAEnvironment_log (2922.35s)
--- PASS: TestAccMWAAEnvironment_pluginsS3ObjectVersion (2894.48s)

--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_empty (15.27s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags (170.61s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix (170.12s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags (173.28s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_remove (168.21s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag (171.71s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default (104.94s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty (15.51s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full (104.01s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_basic (102.49s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_removed (156.95s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_updateBasic (249.56s)

--- PASS: TestAccS3BucketDataSource_basic (91.08s)
--- PASS: TestAccS3BucketDataSource_website (91.58s)

--- PASS: TestAccS3BucketIntelligentTieringConfiguration_Filter (385.84s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_basic (103.55s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_disappears (86.63s)

--- PASS: TestAccS3BucketInventory_basic (105.25s)
--- PASS: TestAccS3BucketInventory_encryptWithSSEKMS (103.03s)
--- PASS: TestAccS3BucketInventory_encryptWithSSES3 (103.35s)

--- PASS: TestAccS3BucketMetric_basic (102.96s)
--- PASS: TestAccS3BucketMetric_withEmptyFilter (16.25s)
--- PASS: TestAccS3BucketMetric_withFilterMultipleTags (171.05s)
--- PASS: TestAccS3BucketMetric_withFilterPrefix (169.50s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndMultipleTags (169.48s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndSingleTag (171.71s)
--- PASS: TestAccS3BucketMetric_withFilterSingleTag (169.72s)

--- PASS: TestAccS3BucketNotification_LambdaFunctionLambdaFunctionARN_alias (116.97s)
--- PASS: TestAccS3BucketNotification_Topic_multiple (100.55s)
--- PASS: TestAccS3BucketNotification_lambdaFunction (118.74s)
--- PASS: TestAccS3BucketNotification_queue (127.71s)
--- PASS: TestAccS3BucketNotification_topic (99.71s)
--- PASS: TestAccS3BucketNotification_update (186.15s)

--- PASS: TestAccS3BucketObjectDataSource_allParams (92.35s)
--- PASS: TestAccS3BucketObjectDataSource_basic (89.08s)
--- PASS: TestAccS3BucketObjectDataSource_basicViaAccessPoint (89.74s)
--- PASS: TestAccS3BucketObjectDataSource_bucketKeyEnabled (90.39s)
--- PASS: TestAccS3BucketObjectDataSource_kmsEncrypted (90.53s)
--- PASS: TestAccS3BucketObjectDataSource_leadingSlash (159.14s)
--- PASS: TestAccS3BucketObjectDataSource_multipleSlashes (160.37s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOff (91.84s)
--- PASS: TestAccS3BucketObjectDataSource_objectLockLegalHoldOn (87.51s)
--- PASS: TestAccS3BucketObjectDataSource_readableBody (90.06s)
--- PASS: TestAccS3BucketObjectDataSource_singleSlashAsKey (88.40s)

--- PASS: TestAccS3BucketObject_acl (254.78s)
--- PASS: TestAccS3BucketObject_bucketBucketKeyEnabled (94.74s)
--- PASS: TestAccS3BucketObject_content (101.41s)
--- PASS: TestAccS3BucketObject_contentBase64 (87.64s)
--- PASS: TestAccS3BucketObject_defaultBucketSSE (94.45s)
--- PASS: TestAccS3BucketObject_empty (100.39s)
--- PASS: TestAccS3BucketObject_etagEncryption (101.19s)
--- PASS: TestAccS3BucketObject_ignoreTags (165.24s)
--- PASS: TestAccS3BucketObject_kms (101.10s)
--- PASS: TestAccS3BucketObject_metadata (252.14s)
--- PASS: TestAccS3BucketObject_noNameNoKey (24.48s)
--- PASS: TestAccS3BucketObject_nonVersioned (101.17s)
--- PASS: TestAccS3BucketObject_objectBucketKeyEnabled (94.09s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithNone (240.51s)
--- PASS: TestAccS3BucketObject_objectLockLegalHoldStartWithOn (168.08s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithNone (240.92s)
--- PASS: TestAccS3BucketObject_objectLockRetentionStartWithSet (313.10s)
--- PASS: TestAccS3BucketObject_source (102.12s)
--- PASS: TestAccS3BucketObject_sourceHashTrigger (176.44s)
--- PASS: TestAccS3BucketObject_sse (100.38s)
--- PASS: TestAccS3BucketObject_storageClass (398.75s)
--- PASS: TestAccS3BucketObject_tags (321.27s)
--- PASS: TestAccS3BucketObject_tagsLeadingMultipleSlashes (312.68s)
--- PASS: TestAccS3BucketObject_tagsLeadingSingleSlash (324.23s)
--- PASS: TestAccS3BucketObject_tagsMultipleSlashes (310.26s)
--- PASS: TestAccS3BucketObject_updateSameFile (163.03s)
--- PASS: TestAccS3BucketObject_updates (174.78s)
--- PASS: TestAccS3BucketObject_updatesWithVersioning (175.37s)
--- PASS: TestAccS3BucketObject_updatesWithVersioningViaAccessPoint (162.71s)
--- PASS: TestAccS3BucketObject_withContentCharacteristics (88.02s)

--- PASS: TestAccS3BucketObjectsDataSource_all (171.65s)
--- PASS: TestAccS3BucketObjectsDataSource_basic (174.72s)
--- PASS: TestAccS3BucketObjectsDataSource_basicViaAccessPoint (168.75s)
--- PASS: TestAccS3BucketObjectsDataSource_encoded (169.07s)
--- PASS: TestAccS3BucketObjectsDataSource_fetchOwner (169.57s)
--- PASS: TestAccS3BucketObjectsDataSource_maxKeys (165.57s)
--- PASS: TestAccS3BucketObjectsDataSource_prefixes (171.38s)
--- PASS: TestAccS3BucketObjectsDataSource_startAfter (165.48s)

--- PASS: TestAccS3BucketOwnershipControls_Disappears_bucket (78.52s)
--- PASS: TestAccS3BucketOwnershipControls_Rule_objectOwnership (182.04s)
--- PASS: TestAccS3BucketOwnershipControls_basic (102.61s)
--- PASS: TestAccS3BucketOwnershipControls_disappears (89.54s)

--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode (385.23s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDoc (274.07s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal (290.82s)
--- PASS: TestAccS3BucketPolicy_basic (105.20s)
--- PASS: TestAccS3BucketPolicy_policyUpdate (187.53s)

--- PASS: TestAccS3BucketPublicAccessBlock_Disappears_bucket (80.41s)
--- PASS: TestAccS3BucketPublicAccessBlock_basic (107.62s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicACLs (257.09s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicPolicy (256.24s)
--- PASS: TestAccS3BucketPublicAccessBlock_disappears (91.52s)
--- PASS: TestAccS3BucketPublicAccessBlock_ignorePublicACLs (256.46s)
--- PASS: TestAccS3BucketPublicAccessBlock_restrictPublicBuckets (256.59s)

--- PASS: TestAccS3BucketReplicationConfiguration_basic (553.19s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (498.55s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (491.88s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (143.87s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (384.81s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (369.33s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (407.94s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (408.23s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (402.69s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (402.48s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (397.85s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (370.48s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (234.97s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (407.45s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (328.23s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (401.99s)

--- PASS: TestAccS3BucketVersioning_MFADelete (67.36s)
--- PASS: TestAccS3BucketVersioning_basic (105.48s)
--- PASS: TestAccS3BucketVersioning_disappears (96.21s)
--- PASS: TestAccS3BucketVersioning_update (142.36s)

--- PASS: TestAccS3Bucket_Basic_acceleration (69.85s)
--- PASS: TestAccS3Bucket_Basic_basic (70.03s)
--- PASS: TestAccS3Bucket_Basic_emptyString (69.02s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (95.26s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (95.58s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (96.34s)
--- PASS: TestAccS3Bucket_Basic_generatedName (40.49s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (74.27s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (44.31s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (65.42s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (52.39s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (224.97s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (169.96s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (94.09s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (79.95s)
--- PASS: TestAccS3Bucket_Manage_objectLock (151.23s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (180.92s)
--- PASS: TestAccS3Bucket_Replication_basic (295.99s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (71.98s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (161.75s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (167.99s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (222.45s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (219.80s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (250.26s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (113.02s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (164.36s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (153.88s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (163.48s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (84.98s)
--- PASS: TestAccS3Bucket_Security_corsDelete (72.53s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (84.62s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (144.35s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (139.04s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (71.24s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (64.31s)
--- PASS: TestAccS3Bucket_Security_grantToACL (92.76s)
--- PASS: TestAccS3Bucket_Security_logging (90.47s)
--- PASS: TestAccS3Bucket_Security_policy (114.83s)
--- PASS: TestAccS3Bucket_Security_updateACL (68.61s)
--- PASS: TestAccS3Bucket_Security_updateGrant (138.14s)
--- PASS: TestAccS3Bucket_Tags_basic (48.67s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (72.65s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (155.48s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (187.07s)
--- PASS: TestAccS3Bucket_Web_redirect (174.88s)
--- PASS: TestAccS3Bucket_Web_routingRules (111.10s)
--- PASS: TestAccS3Bucket_Web_simple (164.73s)

--- PASS: TestBucketName (0.00s)
--- PASS: TestBucketRegionalDomainName (0.00s)
--- PASS: TestFlattenImageConfigShouldNotFailWithEmptyImageConfig (0.00s)
--- PASS: TestWebsiteEndpoint (0.00s)

--- SKIP: TestAccAPIGatewayDomainName_certificateARN (0.00s)
--- SKIP: TestAccAPIGatewayDomainName_certificateName (0.00s)
--- SKIP: TestAccAPIGatewayDomainName_mutualTLSAuthentication (0.00s)
--- SKIP: TestAccAPIGatewayDomainName_regionalCertificateName (0.00s)

--- SKIP: TestAccAPIGatewayV2DomainName_mutualTLSAuthentication (0.00s)

--- SKIP: TestAccLambdaFunctionDataSource_image (1.07s)

--- SKIP: TestAccLambdaFunction_image (0.94s)

--- SKIP: TestAccS3BucketReplicationConfiguration_existingObjectReplication (0.00s)

--- SKIP: TestAccSignerSigningJobDataSource_basic (0.75s)

--- SKIP: TestAccSignerSigningJob_basic (0.87s)

@anGie44 anGie44 added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jan 15, 2022
@anGie44 anGie44 changed the title r/s3_bucket: versioning argument r/s3_bucket: read-only versioning argument Jan 15, 2022
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 15, 2022
anGie44 added a commit that referenced this pull request Jan 15, 2022
@anGie44
Update CHANGELOG for #22606
a3b0ac7
@anGie44 anGie44 changed the base branch from main to release/4.x January 15, 2022 03:21
@anGie44 anGie44 force-pushed the release/4.x branch 3 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39
@github-actions github-actions bot added service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/kafkaconnect Issues and PRs that pertain to the kafkaconnect service. service/lambda Issues and PRs that pertain to the lambda service. service/mwaa Issues and PRs that pertain to the mwaa service. service/synthetics Issues and PRs that pertain to the synthetics service. labels Jan 21, 2022
@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jan 25, 2022
@github-actions github-actions bot added service/dataexchange Issues and PRs that pertain to the dataexchange service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. sweeper Pertains to changes to or issues with the sweeper. labels Jan 25, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-versioning-deprecation branch from 77fada3 to 6c19113 Compare January 25, 2022 02:22
@github-actions github-actions bot added the service/eks Issues and PRs that pertain to the eks service. label Jan 25, 2022
@anGie44 anGie44 force-pushed the f-s3-bucket-versioning-deprecation branch from 6c19113 to 1fcd008 Compare January 25, 2022 02:24
@anGie44 anGie44 force-pushed the f-s3-bucket-versioning-deprecation branch from c3e7f2f to 1ceeae3 Compare February 1, 2022 01:56
@ewbankkit ewbankkit added this to the v4.0.0 milestone Feb 2, 2022
@YakDriver YakDriver self-assigned this Feb 2, 2022
anGie44
anGie44 commented Feb 2, 2022
View reviewed changes
.changelog/22606.txt Outdated Show resolved Hide resolved
YakDriver
YakDriver approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

% make testacc TESTS=TestAccSyntheticsCanary_ PKG=synthetics        
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/synthetics/... -v -count 1 -parallel 20 -run='TestAccSyntheticsCanary_'  -timeout 180m
--- PASS: TestAccSyntheticsCanary_disappears (64.51s)
--- PASS: TestAccSyntheticsCanary_s3 (70.15s)
--- PASS: TestAccSyntheticsCanary_artifactEncryption (92.37s)
--- PASS: TestAccSyntheticsCanary_startCanary (117.41s)
--- PASS: TestAccSyntheticsCanary_basic (119.89s)
--- PASS: TestAccSyntheticsCanary_run (129.82s)
--- PASS: TestAccSyntheticsCanary_runTracing (137.59s)
--- PASS: TestAccSyntheticsCanary_StartCanary_codeChanges (161.01s)
--- PASS: TestAccSyntheticsCanary_tags (172.94s)
--- PASS: TestAccSyntheticsCanary_runtimeVersion (175.74s)
--- PASS: TestAccSyntheticsCanary_vpc (2163.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/synthetics	2165.268s
% make testacc TESTS=TestAccAPIGatewayDomainName PKG=apigateway
--- PASS: TestAccAPIGatewayDomainName_regionalCertificateARN (22.02s)
--- PASS: TestAccAPIGatewayDomainName_disappears (100.82s)
--- PASS: TestAccAPIGatewayDomainName_tags (109.89s)
--- PASS: TestAccAPIGatewayDomainNameDataSource_basic (123.87s)
--- PASS: TestAccAPIGatewayDomainName_securityPolicy (367.68s)
--- PASS: TestAccAPIGatewayDomainName_certificateARN (982.66s)
% make testacc TESTS='TestAccAPIGatewayV2DomainName_basic|TestAccAPIGatewayV2DomainName_disapp|TestAccAPIGatewayV2DomainName_tags|TestAccAPIGatewayV2DomainName_updateCert' PKG=apigatewayv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apigatewayv2/... -v -count 1 -parallel 20 -run='TestAccAPIGatewayV2DomainName_basic|TestAccAPIGatewayV2DomainName_disapp|TestAccAPIGatewayV2DomainName_tags|TestAccAPIGatewayV2DomainName_updateCert'  -timeout 180m
--- PASS: TestAccAPIGatewayV2DomainName_disappears (24.09s)
--- PASS: TestAccAPIGatewayV2DomainName_basic (94.49s)
--- PASS: TestAccAPIGatewayV2DomainName_tags (135.77s)
--- PASS: TestAccAPIGatewayV2DomainName_updateCertificate (568.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2	571.377s
% make testacc TESTS=TestAccKafkaConnectCustomPlugin PKG=kafkaconnect
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafkaconnect/... -v -count 1 -parallel 20 -run='TestAccKafkaConnectCustomPlugin'  -timeout 180m
--- PASS: TestAccKafkaConnectCustomPlugin_description (72.11s)
--- PASS: TestAccKafkaConnectCustomPluginDataSource_basic (76.96s)
--- PASS: TestAccKafkaConnectCustomPlugin_basic (76.98s)
--- PASS: TestAccKafkaConnectCustomPlugin_objectVersion (79.71s)
--- PASS: TestAccKafkaConnectCustomPlugin_contentType (114.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect	116.379s
% make testacc TESTS=TestAccLambdaFunctionEventInvokeConfig_ PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunctionEventInvokeConfig_'  -timeout 180m
--- PASS: TestAccLambdaFunctionEventInvokeConfig_Qualifier_latest (58.98s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_basic (66.59s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_Qualifier_aliasName (73.57s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_QualifierFunctionName_arn (86.55s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_Disappears_lambdaFunctionEventInvoke (89.59s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_maximumRetryAttempts (100.29s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_Qualifier_functionVersion (107.79s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_FunctionName_arn (116.01s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_Disappears_lambdaFunction (120.56s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_Destination_remove (130.82s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_Destination_swap (148.02s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_DestinationOnFailure_destination (156.92s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_maximumEventAgeInSeconds (176.98s)
--- PASS: TestAccLambdaFunctionEventInvokeConfig_DestinationOnSuccess_destination (221.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	222.507s
% make testacc TESTS=TestAccLambdaFunctionDataSource_ PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunctionDataSource_'  -timeout 180m
--- SKIP: TestAccLambdaFunctionDataSource_image (0.79s)
--- PASS: TestAccLambdaFunctionDataSource_alias (40.25s)
--- PASS: TestAccLambdaFunctionDataSource_basic (46.50s)
--- PASS: TestAccLambdaFunctionDataSource_environment (53.23s)
--- PASS: TestAccLambdaFunctionDataSource_version (70.65s)
--- PASS: TestAccLambdaFunctionDataSource_layers (76.16s)
--- PASS: TestAccLambdaFunctionDataSource_architectures (76.25s)
--- PASS: TestAccLambdaFunctionDataSource_fileSystem (501.34s)
--- PASS: TestAccLambdaFunctionDataSource_vpc (1537.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	1539.945s
% make testacc TESTS=TestAccLambdaFunction_ PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunction_'  -timeout 180m
--- PASS: TestAccLambdaFunction_Zip_validation (9.06s)
--- PASS: TestAccLambdaFunction_s3 (42.20s)
--- PASS: TestAccLambdaFunction_emptyVPC (53.32s)
--- PASS: TestAccLambdaFunction_expectFilenameAndS3Attributes (16.78s)
--- PASS: TestAccLambdaFunction_S3Update_basic (77.28s)
--- PASS: TestAccLambdaFunction_S3Update_unversioned (77.67s)
--- PASS: TestAccLambdaFunction_basic (83.37s)
--- PASS: TestAccLambdaFunction_tags (101.22s)
--- PASS: TestAccLambdaFunction_layersUpdate (121.76s)
--- PASS: TestAccLambdaFunction_runtimes (474.90s)
--- PASS: TestAccLambdaFunction_VPCPublishNo_changes (799.90s)
--- SKIP: TestAccLambdaFunction_image (0.00s)
--- PASS: TestAccLambdaFunction_architectures (875.92s)
--- PASS: TestAccLambdaFunction_VPCPublishHas_changes (909.47s)
--- PASS: TestAccLambdaFunction_vpcRemoval (1263.07s)
--- PASS: TestAccLambdaFunction_VPC_properIAMDependencies (1392.84s)
--- PASS: TestAccLambdaFunction_localUpdate (1426.98s)
--- PASS: TestAccLambdaFunction_architecturesWithLayer (1445.77s)
--- PASS: TestAccLambdaFunction_architecturesUpdate (1453.13s)
--- PASS: TestAccLambdaFunction_layers (1395.69s)
--- PASS: TestAccLambdaFunction_versioned (1390.94s)
--- PASS: TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables (1403.15s)
--- PASS: TestAccLambdaFunction_encryptedEnvVariables (1439.17s)
--- PASS: TestAccLambdaFunction_concurrencyCycle (142.58s)
--- PASS: TestAccLambdaFunction_versionedUpdate (1529.73s)
--- PASS: TestAccLambdaFunction_codeSigning (1457.93s)
--- PASS: TestAccLambdaFunction_nilDeadLetter (445.87s)
--- PASS: TestAccLambdaFunction_deadLetter (955.83s)
--- PASS: TestAccLambdaFunction_disappears (305.58s)
--- PASS: TestAccLambdaFunction_LocalUpdate_nameOnly (1731.14s)
--- PASS: TestAccLambdaFunction_tracing (381.46s)
--- PASS: TestAccLambdaFunction_concurrency (902.94s)
--- PASS: TestAccLambdaFunction_EnvironmentVariables_noValue (314.85s)
--- PASS: TestAccLambdaFunction_disablePublish (871.82s)
--- PASS: TestAccLambdaFunction_unpublishedCodeUpdate (402.63s)
--- PASS: TestAccLambdaFunction_deadLetterUpdated (355.18s)
--- PASS: TestAccLambdaFunction_enablePublish (410.04s)
--- PASS: TestAccLambdaFunction_vpcUpdate (1875.78s)
--- PASS: TestAccLambdaFunction_envVariables (432.93s)
--- PASS: TestAccLambdaFunction_fileSystem (1591.74s)
--- PASS: TestAccLambdaFunction_VPC_withInvocation (2127.11s)
--- PASS: TestAccLambdaFunction_vpc (2358.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	2359.763s
% make testacc TESTS=TestAccS3BucketAnalyticsConfiguration_ PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketAnalyticsConfiguration_'  -timeout 180m
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_empty (2.22s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_empty (2.24s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_basic (30.16s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_default (30.22s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_full (30.26s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_removed (45.65s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_remove (48.90s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_multipleTags (50.58s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefix (50.65s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_prefixAndTags (50.69s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_WithFilter_singleTag (50.97s)
--- PASS: TestAccS3BucketAnalyticsConfiguration_updateBasic (77.63s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	79.190s
% make testacc TESTS='TestAccS3BucketDataSource_|TestAccS3BucketIntelligentTieringConfiguration_|TestAccS3BucketInventory_|TestAccS3BucketMetric_|TestAccS3BucketNotification_' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketDataSource_|TestAccS3BucketIntelligentTieringConfiguration_|TestAccS3BucketInventory_|TestAccS3BucketMetric_|TestAccS3BucketNotification_'  -timeout 180m
--- PASS: TestAccS3BucketMetric_withEmptyFilter (3.49s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_disappears (32.13s)
--- PASS: TestAccS3BucketDataSource_basic (34.54s)
--- PASS: TestAccS3BucketMetric_basic (34.98s)
--- PASS: TestAccS3BucketDataSource_website (35.50s)
--- PASS: TestAccS3BucketNotification_eventbridge (32.18s)
--- PASS: TestAccS3BucketInventory_encryptWithSSES3 (35.86s)
--- PASS: TestAccS3BucketInventory_basic (35.92s)
--- PASS: TestAccS3BucketInventory_encryptWithSSEKMS (35.94s)
--- PASS: TestAccS3BucketNotification_lambdaFunction (40.74s)
--- PASS: TestAccS3BucketNotification_Topic_multiple (38.37s)
--- PASS: TestAccS3BucketNotification_topic (38.42s)
--- PASS: TestAccS3BucketNotification_LambdaFunctionLambdaFunctionARN_alias (46.87s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndMultipleTags (50.02s)
--- PASS: TestAccS3BucketMetric_withFilterPrefixAndSingleTag (53.26s)
--- PASS: TestAccS3BucketMetric_withFilterMultipleTags (53.65s)
--- PASS: TestAccS3BucketMetric_withFilterPrefix (53.71s)
--- PASS: TestAccS3BucketMetric_withFilterSingleTag (53.73s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_basic (26.02s)
--- PASS: TestAccS3BucketNotification_queue (67.63s)
--- PASS: TestAccS3BucketNotification_update (91.13s)
--- PASS: TestAccS3BucketIntelligentTieringConfiguration_Filter (114.09s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	115.366s
% make testacc TESTS='TestAccS3BucketObjectDataSource_|TestAccS3BucketObject_|TestAccS3BucketObjectsDataSource_|TestAccS3BucketOwnershipControls_|TestAccS3BucketPolicy_' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketObjectDataSource_|TestAccS3BucketObject_|TestAccS3BucketObjectsDataSource_|TestAccS3BucketOwnershipControls_|TestAccS3BucketPolicy_'  -timeout 180m
--- PASS: TestAccS3BucketOwnershipControls_Disappears_bucket (19.05s)
--- PASS: TestAccS3BucketOwnershipControls_disappears (25.84s)
--- PASS: TestAccS3BucketPolicy_basic (29.10s)
--- PASS: TestAccS3BucketOwnershipControls_basic (33.22s)
--- PASS: TestAccS3BucketOwnershipControls_Rule_objectOwnership (49.19s)
--- PASS: TestAccS3BucketPolicy_policyUpdate (50.42s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDocNotPrincipal (94.64s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_policyDoc (130.99s)
--- PASS: TestAccS3BucketPolicy_IAMRoleOrder_jsonEncode (288.23s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	289.509s
% make testacc TESTS='TestAccS3Bucket_Replication|TestAccS3Bucket_Security|TestAccS3Bucket_Tags|TestAccS3Bucket_Web' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3Bucket_Replication|TestAccS3Bucket_Security|TestAccS3Bucket_Tags|TestAccS3Bucket_Web'  -timeout 180m
--- PASS: TestAccS3Bucket_Security_corsDelete (44.52s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenAES256IsUsed (52.32s)
--- PASS: TestAccS3Bucket_Security_enableDefaultEncryptionWhenTypical (54.37s)
--- PASS: TestAccS3Bucket_Tags_basic (54.69s)
--- PASS: TestAccS3Bucket_Replication_twoDestination (61.54s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsNonEmptyFilter (64.75s)
--- PASS: TestAccS3Bucket_Replication_multipleDestinationsEmptyFilter (67.93s)
--- PASS: TestAccS3Bucket_Security_aclToGrant (72.96s)
--- PASS: TestAccS3Bucket_Security_grantToACL (78.33s)
--- PASS: TestAccS3Bucket_Tags_ignoreTags (81.12s)
--- PASS: TestAccS3Bucket_Security_disableDefaultEncryptionWhenDefaultEncryptionIsEnabled (81.49s)
--- PASS: TestAccS3Bucket_Security_corsUpdate (89.99s)
--- PASS: TestAccS3Bucket_Web_routingRules (90.84s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAccessControlTranslation (99.13s)
--- PASS: TestAccS3Bucket_Replication_expectVersioningValidationError (25.69s)
--- PASS: TestAccS3Bucket_Replication_ruleDestinationAddAccessControlTranslation (106.85s)
--- PASS: TestAccS3Bucket_Security_logging (55.93s)
--- PASS: TestAccS3Bucket_Security_corsEmptyOrigin (40.79s)
--- PASS: TestAccS3Bucket_Replication_schemaV2SameRegion (47.10s)
--- PASS: TestAccS3Bucket_Web_redirect (117.81s)
--- PASS: TestAccS3Bucket_Security_updateACL (74.42s)
--- PASS: TestAccS3Bucket_Security_policy (120.73s)
--- PASS: TestAccS3Bucket_Web_simple (122.41s)
--- PASS: TestAccS3Bucket_Security_updateGrant (122.43s)
--- PASS: TestAccS3Bucket_Replication_withoutStorageClass (51.62s)
--- PASS: TestAccS3Bucket_Replication_withoutPrefix (61.18s)
--- PASS: TestAccS3Bucket_Tags_withNoSystemTags (143.00s)
--- PASS: TestAccS3Bucket_Replication_RTC_valid (80.74s)
--- PASS: TestAccS3Bucket_Replication_schemaV2 (145.84s)
--- PASS: TestAccS3Bucket_Replication_basic (156.21s)
--- PASS: TestAccS3Bucket_Tags_withSystemTags (165.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	220.021s
% make testacc TESTS='TestAccS3BucketPublicAccessBlock_|TestAccS3BucketReplicationConfiguration_|TestAccS3BucketVersioning_|TestAccS3Bucket_Basic|TestAccS3Bucket_Manage' PKG=s3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3BucketPublicAccessBlock_|TestAccS3BucketReplicationConfiguration_|TestAccS3BucketVersioning_|TestAccS3Bucket_Basic|TestAccS3Bucket_Manage'  -timeout 180m
--- SKIP: TestAccS3BucketReplicationConfiguration_existingObjectReplication (0.00s)
--- PASS: TestAccS3Bucket_Basic_forceDestroy (42.43s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleExpirationEmptyBlock (46.19s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithEmptyPrefixes (47.10s)
--- PASS: TestAccS3BucketVersioning_disappears (47.40s)
--- PASS: TestAccS3BucketPublicAccessBlock_basic (50.89s)
--- PASS: TestAccS3BucketVersioning_MFADelete (51.61s)
--- PASS: TestAccS3BucketVersioning_basic (51.61s)
--- PASS: TestAccS3Bucket_Manage_lifecycleRuleAbortIncompleteMultipartUploadDaysNoExpiration (52.16s)
--- PASS: TestAccS3Bucket_Basic_forceDestroyWithObjectLockEnabled (52.44s)
--- PASS: TestAccS3Bucket_Basic_keyEnabled (58.45s)
--- PASS: TestAccS3Bucket_Basic_generatedName (40.23s)
--- PASS: TestAccS3Bucket_Manage_objectLock (84.63s)
--- PASS: TestAccS3Bucket_Basic_emptyString (44.64s)
--- PASS: TestAccS3Bucket_Basic_namePrefix (45.68s)
--- PASS: TestAccS3Bucket_Basic_basic (44.68s)
--- PASS: TestAccS3Bucket_Basic_acceleration (94.12s)
--- PASS: TestAccS3Bucket_Manage_lifecycleExpireMarkerOnly (94.21s)
--- PASS: TestAccS3Bucket_Basic_requestPayer (94.92s)
--- PASS: TestAccS3BucketReplicationConfiguration_disappears (48.24s)
--- PASS: TestAccS3BucketVersioning_update (113.08s)
--- PASS: TestAccS3Bucket_Manage_lifecycleBasic (129.14s)
--- PASS: TestAccS3BucketPublicAccessBlock_Disappears_bucket (26.67s)
--- PASS: TestAccS3BucketPublicAccessBlock_restrictPublicBuckets (93.60s)
--- PASS: TestAccS3Bucket_Basic_shouldFailNotFound (15.06s)
--- PASS: TestAccS3BucketPublicAccessBlock_disappears (27.41s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicPolicy (84.66s)
--- PASS: TestAccS3BucketPublicAccessBlock_blockPublicACLs (85.89s)
--- PASS: TestAccS3BucketPublicAccessBlock_ignorePublicACLs (86.09s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2SameRegion (166.99s)
--- PASS: TestAccS3BucketReplicationConfiguration_twoDestination (294.62s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutPrefix (327.17s)
--- PASS: TestAccS3BucketReplicationConfiguration_withoutStorageClass (285.19s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_andOperator (351.11s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsEmptyFilter (313.12s)
--- PASS: TestAccS3BucketReplicationConfiguration_filter_tagFilter (284.55s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2DestinationMetrics (283.25s)
--- PASS: TestAccS3BucketReplicationConfiguration_schemaV2 (284.85s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicationTimeControl (286.14s)
--- PASS: TestAccS3BucketReplicationConfiguration_multipleDestinationsNonEmptyFilter (329.97s)
--- PASS: TestAccS3BucketReplicationConfiguration_replicaModifications (283.05s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAddAccessControlTranslation (317.55s)
--- PASS: TestAccS3BucketReplicationConfiguration_configurationRuleDestinationAccessControlTranslation (306.95s)
--- PASS: TestAccS3BucketReplicationConfiguration_basic (702.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	757.087s
% make testacc TESTS=TestAccMWAAEnvironment_ PKG=mwaa
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mwaa/... -v -count 1 -parallel 20 -run='TestAccMWAAEnvironment_'  -timeout 180m
--- PASS: TestAccMWAAEnvironment_basic (2132.26s)
--- PASS: TestAccMWAAEnvironment_full (2165.63s)
--- PASS: TestAccMWAAEnvironment_disappears (2297.45s)
--- PASS: TestAccMWAAEnvironment_log (2879.37s)
--- PASS: TestAccMWAAEnvironment_pluginsS3ObjectVersion (3158.46s)
--- PASS: TestAccMWAAEnvironment_airflowOptions (3646.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	3647.859s

@anGie44 anGie44 force-pushed the f-s3-bucket-versioning-deprecation branch from 5be289a to f18af0b Compare February 3, 2022 18:38
anGie44 added a commit that referenced this pull request Feb 3, 2022
@anGie44
Update CHANGELOG for #22606
4ee1c89
@anGie44 anGie44 force-pushed the f-s3-bucket-versioning-deprecation branch from fcc0f83 to 0220d42 Compare February 3, 2022 22:47
anGie44 added a commit that referenced this pull request Feb 5, 2022
@anGie44
Update CHANGELOG for #22606
1cc1929
@anGie44 anGie44 force-pushed the f-s3-bucket-versioning-deprecation branch from 0220d42 to da81892 Compare February 5, 2022 03:52
@anGie44
Copy link
Contributor Author

anGie44 commented Feb 5, 2022

Output of updated acceptance tests:

--- PASS: TestAccS3BucketVersioning_disappears (31.28s)
--- PASS: TestAccS3BucketVersioning_MFADelete (33.46s)
--- PASS: TestAccS3BucketVersioning_basic (33.67s)
--- PASS: TestAccS3BucketVersioning_update (81.70s)

@anGie44 anGie44 force-pushed the f-s3-bucket-versioning-deprecation branch from c0dcc3f to 1e6ab70 Compare February 7, 2022 02:45
@anGie44 anGie44 force-pushed the f-s3-bucket-versioning-deprecation branch from 5adf1c5 to 3a4a4a0 Compare February 7, 2022 03:07
@github-actions github-actions bot added the service/athena Issues and PRs that pertain to the athena service. label Feb 7, 2022
@anGie44 anGie44 merged commit 5b7c36d into main Feb 7, 2022
@anGie44 anGie44 deleted the f-s3-bucket-versioning-deprecation branch February 7, 2022 05:27
github-actions bot pushed a commit that referenced this pull request Feb 7, 2022
Update CHANGELOG.md for #22606
c758a97
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/athena Issues and PRs that pertain to the athena service. service/kafkaconnect Issues and PRs that pertain to the kafkaconnect service. service/lambda Issues and PRs that pertain to the lambda service. service/mwaa Issues and PRs that pertain to the mwaa service. service/s3 Issues and PRs that pertain to the s3 service. service/synthetics Issues and PRs that pertain to the synthetics service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anGie44 @YakDriver @ewbankkit