Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 4 Upgrade Guide Base #22818

Merged
merged 7 commits into from
Feb 2, 2022
Merged

Version 4 Upgrade Guide Base #22818

merged 7 commits into from
Feb 2, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 28, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #20433

Output from acceptance testing:

N/A

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. size/M Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. labels Jan 28, 2022
@anGie44 anGie44 modified the milestones: v3.75.0, v4.0.0 Jan 28, 2022
@anGie44 anGie44 added the documentation Introduces or discusses updates to documentation. label Jan 28, 2022
@ewbankkit ewbankkit mentioned this pull request Jan 28, 2022
Merged
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jan 28, 2022
@ewbankkit ewbankkit mentioned this pull request Jan 28, 2022
Merged
anGie44
anGie44 commented Jan 28, 2022
View reviewed changes
website/docs/guides/version-4-upgrade.html.md
@@ -200,4 +209,21 @@ resource "aws_batch_compute_environment" "test" {

Default values


## EC2-Classic Resource and Data Source Support
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure if this should live in this guide or the link above in the note should suffice 🤔

@anGie44 anGie44 force-pushed the version-4-upgrade-guide branch 2 times, most recently from 6a21fdf to 4ee2f8a Compare January 28, 2022 21:04
@anGie44 anGie44 force-pushed the version-4-upgrade-guide branch 2 times, most recently from d1fc062 to 44c1c50 Compare January 28, 2022 22:14
@anGie44 anGie44 force-pushed the version-4-upgrade-guide branch from 44c1c50 to cf6db0b Compare January 28, 2022 22:15
@anGie44 anGie44 force-pushed the version-4-upgrade-guide branch 2 times, most recently from 237ada5 to ed2d9af Compare January 28, 2022 22:27
@anGie44 anGie44 force-pushed the version-4-upgrade-guide branch 2 times, most recently from 6ee5f6d to 9f2c36b Compare January 29, 2022 00:04
@anGie44 anGie44 force-pushed the version-4-upgrade-guide branch from 9f2c36b to 1903baa Compare January 31, 2022 20:15
@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudwatchlogs labels Jan 31, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Feb 1, 2022
@ewbankkit
Remove aws_vpn_connection sections.
f11af52 
The implementation does not set `Default` values on attributes and is backwards compatible.
@github-actions github-actions bot added service/cloudwatchlogs size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Feb 2, 2022
@anGie44 anGie44 force-pushed the version-4-upgrade-guide branch 2 times, most recently from 744524c to 42de57c Compare February 2, 2022 15:58
@anGie44 anGie44 marked this pull request as ready for review February 2, 2022 16:30
@anGie44 anGie44 force-pushed the version-4-upgrade-guide branch from 1fb80e6 to 430eff1 Compare February 2, 2022 16:31
@ewbankkit ewbankkit mentioned this pull request Feb 2, 2022
Merged
This was referenced Feb 2, 2022
Merged
Merged
ewbankkit
ewbankkit approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 merged commit 43984d3 into main Feb 2, 2022
@anGie44 anGie44 deleted the version-4-upgrade-guide branch February 2, 2022 17:15
github-actions bot pushed a commit that referenced this pull request Feb 2, 2022
Update CHANGELOG.md for #22818
9c4743c
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

PatMyron added a commit to PatMyron/terraform-provider-aws that referenced this pull request Feb 11, 2022
@PatMyron
docs: instance_interruption_behaviour -> instance_interruption_behavi…
85c6afa 
…or upgrade typo

hashicorp#22818
@PatMyron PatMyron mentioned this pull request Feb 11, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anGie44 @bflad @ewbankkit