Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prototype: Mux with Terraform Plugin Framework #23948

Closed
wants to merge 79 commits into from
Closed

prototype: Mux with Terraform Plugin Framework #23948

wants to merge 79 commits into from

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

This PR implements a prototype of combining resource and data source implemented in either Terraform Plugin SDK v2 or Terraform Plugin Framework using terraform-plugin-mux

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. size/XL Managed by automation to categorize the size of a PR. labels Mar 30, 2022
@ewbankkit

This comment was marked as outdated.

Sign in to view
ewbankkit added 19 commits March 31, 2022 08:26
@ewbankkit
Default value PlanModifier copied from https://github.com/hashicorp/t…
bec8155 
…erraform-provider-awscc/blob/main/internal/generic/default_value.go.
@ewbankkit
Revert "Default value PlanModifier copied from https://github.com/has…
dffe106 
…hicorp/terraform-provider-awscc/blob/main/internal/generic/default_value.go."

This reverts commit bec8155.
@ewbankkit
Remove v5 provider schema 'Default's.
d2217f5 
This is necessary for muxing with the v5 provider which has no ability to specify attribute default values in schema.
* All except 'max_retries' are unnecessary as they are the type's zero value
* The default value of 25 for 'max_retries' can be implemented in code
@ewbankkit
Duration type copied from https://github.com/hashicorp/terraform-prov…
953c2ef 
…ider-awscc/blob/main/internal/types/duration.go.
@ewbankkit
Read configuration data.
3449603
@ewbankkit
Successfully read configuration.
d88b0fe
@ewbankkit
Read nested configuration blocks.
28b62e3
@ewbankkit
Read endpoints into map[string]string.
476d3fa
@ewbankkit
Use '*string' instead of 'types.String' in configuration structures.
7c6a412
@ewbankkit
Use '*bool' instead of 'types.Bool' in configuration structures.
ae471de
@ewbankkit
Use '*int64' instead of 'types.Int64' in configuration structures.
b2a68cd
@ewbankkit
Use '[]string' instead of 'types.List(types.String)' or 'types.Set(ty…
5a4d303 
…pes.String)' in configuration structures.
@ewbankkit
Simplify 'defaultTagsConfig' and 'ignoreTagsConfig'.
5ce49cf
@ewbankkit
Use '*[]string' instead of '[]string' in configuration structures for…
f55bc92 
… lists of strings.
@ewbankkit
No need to manually unpack 'assume_role', 'default_tags' or 'ignore_t…
55f11b5 
…ags'.
@ewbankkit
Run 'go get github.com/mitchellh/cli@v1.1.2'.
84a6981
@ewbankkit
Run 'go mod tidy'.
f57b9c5
@ewbankkit
Add Terraform Resource Schema Migrator.
f0f0fc2
@ewbankkit
Run 'go get github.com/mitchellh/cli@v1.1.2'.
09b30b2
@ewbankkit
d/aws_arn: Accceptance tests passing with data source implemented wit…
2583092 
…h 'terraform-plugin-framework'.

Acceptance test output:

% make testacc TESTS=TestAccMetaARNDataSource_basic PKG=meta
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/meta/... -v -count 1 -parallel 20 -run='TestAccMetaARNDataSource_basic'  -timeout 180m
=== RUN   TestAccMetaARNDataSource_basic
=== PAUSE TestAccMetaARNDataSource_basic
=== CONT  TestAccMetaARNDataSource_basic
--- PASS: TestAccMetaARNDataSource_basic (14.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	21.527s
@github-actions github-actions bot added service/apigateway Issues and PRs that pertain to the apigateway service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/cur Issues and PRs that pertain to the cur service. service/fms Issues and PRs that pertain to the fms service. service/lightsail Issues and PRs that pertain to the lightsail service. service/meta service/pricing Issues and PRs that pertain to the pricing service. service/route53 Issues and PRs that pertain to the route53 service. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 2, 2022
@ewbankkit ewbankkit mentioned this pull request May 5, 2022
Closed
@ewbankkit ewbankkit mentioned this pull request May 20, 2022
Closed
@ewbankkit ewbankkit mentioned this pull request Jun 28, 2022
Merged
This was referenced Jul 6, 2022
Merged
Merged
Merged
@ewbankkit
Copy link
Contributor Author

Superseded by #25606, #25715, #25733 and #25770.

@ewbankkit ewbankkit closed this Jul 11, 2022
@ewbankkit ewbankkit deleted the f-protov5-mux-terraform-plugin-framework branch July 11, 2022 13:47
@ewbankkit ewbankkit mentioned this pull request Jul 28, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/apigateway Issues and PRs that pertain to the apigateway service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/cur Issues and PRs that pertain to the cur service. service/fms Issues and PRs that pertain to the fms service. service/lightsail Issues and PRs that pertain to the lightsail service. service/pricing Issues and PRs that pertain to the pricing service. service/route53 Issues and PRs that pertain to the route53 service. service/waf Issues and PRs that pertain to the waf service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ewbankkit