Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-20146 Add username parameter to RDS proxy auth #24264

Merged
merged 10 commits into from
Apr 18, 2022
Merged

Issue-20146 Add username parameter to RDS proxy auth #24264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1aa4831
Issue-20146 Add username parameter to RDS proxy auth
enicholson125 Apr 15, 2022
a67c2b3
Add changelog
enicholson125 Apr 15, 2022
7105f92
Tweak CHANGELOG entry.
ewbankkit Apr 18, 2022
b45098f
r/aws_db_proxy: Alphabetize attributes.
ewbankkit Apr 18, 2022
ff2fbc8
r/aws_db_proxy: Order CRUD handler functions.
ewbankkit Apr 18, 2022
24a6400
r/aws_db_proxy: Use 'FindDBProxyByName'.
ewbankkit Apr 18, 2022
f30baef
r/aws_db_proxy: Tidy up resource Create.
ewbankkit Apr 18, 2022
b43e176
r/aws_db_proxy: Tidy up resource Delete.
ewbankkit Apr 18, 2022
df74866
r/aws_db_proxy: Tidy up resource Update.
ewbankkit Apr 18, 2022
d46e725
Update proxy_test.go
ewbankkit Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/24264.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:note
resource/aws_db_proxy: Add `auth.username` argument
```
11 changes: 10 additions & 1 deletion internal/service/rds/find.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,16 @@ func FindDBProxyByName(conn *rds.RDS, name string) (*rds.DBProxy, error) {
return nil, tfresource.NewEmptyResultError(input)
}

return output.DBProxies[0], nil
dbProxy := output.DBProxies[0]

// Eventual consistency check.
if aws.StringValue(dbProxy.DBProxyName) != name {
return nil, &resource.NotFoundError{
LastRequest: input,
}
}

return dbProxy, nil
}

func FindEventSubscriptionByID(conn *rds.RDS, id string) (*rds.EventSubscription, error) {
Expand Down
Loading