Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/opworks: updates to pass semgrep rule prefer-aws-go-sdk-pointer-conversion-assignment #24484

Merged
merged 1 commit into from
May 3, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Apr 30, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12992

Output from acceptance testing:

$  semgrep
Running 31 rules...
100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|31/31
ran 31 rules on 2344 files: 0 findings
make testacc TESTARGS='-run=TestAccOpsWorksApplication\|TestAccOpsWorksInstance_\|TestAccOpsWorksLayers_\|TestAccOpsWorksStack_' PKG=opsworks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opsworks/... -v -count 1 -parallel 20  -run=TestAccOpsWorksApplication\|TestAccOpsWorksInstance_\|TestAccOpsWorksLayers_\|TestAccOpsWorksStack_ -timeout 180m
=== RUN   TestAccOpsWorksApplication_basic
=== PAUSE TestAccOpsWorksApplication_basic
=== RUN   TestAccOpsWorksInstance_basic
=== PAUSE TestAccOpsWorksInstance_basic
=== RUN   TestAccOpsWorksInstance_updateHostNameForceNew
=== PAUSE TestAccOpsWorksInstance_updateHostNameForceNew
=== RUN   TestAccOpsWorksStack_noVPCBasic
=== PAUSE TestAccOpsWorksStack_noVPCBasic
=== RUN   TestAccOpsWorksStack_noVPCChangeServiceRoleForceNew
=== PAUSE TestAccOpsWorksStack_noVPCChangeServiceRoleForceNew
=== RUN   TestAccOpsWorksStack_vpc
=== PAUSE TestAccOpsWorksStack_vpc
=== RUN   TestAccOpsWorksStack_noVPCCreateTags
=== PAUSE TestAccOpsWorksStack_noVPCCreateTags
=== RUN   TestAccOpsWorksStack_CustomCookbooks_setPrivateProperties
=== PAUSE TestAccOpsWorksStack_CustomCookbooks_setPrivateProperties
=== RUN   TestAccOpsWorksStack_classicEndpoints
--- PASS: TestAccOpsWorksStack_classicEndpoints (65.70s)
=== CONT  TestAccOpsWorksApplication_basic
=== CONT  TestAccOpsWorksStack_noVPCChangeServiceRoleForceNew
=== CONT  TestAccOpsWorksInstance_updateHostNameForceNew
=== CONT  TestAccOpsWorksStack_noVPCCreateTags
=== CONT  TestAccOpsWorksInstance_basic
=== CONT  TestAccOpsWorksStack_CustomCookbooks_setPrivateProperties
=== CONT  TestAccOpsWorksStack_vpc
=== CONT  TestAccOpsWorksStack_noVPCBasic
--- PASS: TestAccOpsWorksStack_noVPCBasic (32.22s)
--- PASS: TestAccOpsWorksStack_CustomCookbooks_setPrivateProperties (35.33s)
--- PASS: TestAccOpsWorksStack_noVPCCreateTags (47.92s)
--- PASS: TestAccOpsWorksApplication_basic (49.02s)
--- PASS: TestAccOpsWorksStack_vpc (49.60s)
--- PASS: TestAccOpsWorksStack_noVPCChangeServiceRoleForceNew (56.47s)
--- PASS: TestAccOpsWorksInstance_updateHostNameForceNew (78.89s)
--- PASS: TestAccOpsWorksInstance_basic (84.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opsworks	152.982s

@anGie44 anGie44 added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Apr 30, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. linter Pertains to changes to or issues with the various linters. service/opsworks Issues and PRs that pertain to the opsworks service. labels Apr 30, 2022
@anGie44 anGie44 force-pushed the opworkds-semgrep-exclusions branch from bb24e01 to bc949f1 Compare April 30, 2022 01:56
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Apr 30, 2022
@anGie44 anGie44 closed this Apr 30, 2022
@anGie44 anGie44 force-pushed the opworkds-semgrep-exclusions branch from bc949f1 to 76bbd14 Compare April 30, 2022 01:58
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/opsworks Issues and PRs that pertain to the opsworks service. linter Pertains to changes to or issues with the various linters. size/L Managed by automation to categorize the size of a PR. labels Apr 30, 2022
@anGie44 anGie44 reopened this Apr 30, 2022
@github-actions github-actions bot added linter Pertains to changes to or issues with the various linters. service/opsworks Issues and PRs that pertain to the opsworks service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Apr 30, 2022
@anGie44 anGie44 force-pushed the opworkds-semgrep-exclusions branch from bc949f1 to 723d292 Compare April 30, 2022 02:00
@anGie44 anGie44 marked this pull request as ready for review April 30, 2022 02:01
@anGie44 anGie44 force-pushed the opworkds-semgrep-exclusions branch from 723d292 to 47a24aa Compare April 30, 2022 03:25
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Apr 30, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 force-pushed the opworkds-semgrep-exclusions branch from 47a24aa to bd0aaac Compare May 3, 2022 13:03
@anGie44 anGie44 added this to the v4.13.0 milestone May 3, 2022
@anGie44 anGie44 merged commit ae0e844 into main May 3, 2022
@anGie44 anGie44 deleted the opworkds-semgrep-exclusions branch May 3, 2022 13:03
@github-actions
Copy link

github-actions bot commented May 5, 2022

This functionality has been released in v4.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linter Pertains to changes to or issues with the various linters. service/opsworks Issues and PRs that pertain to the opsworks service. size/XL Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants